From 924f59fad0a0bc7be0568910f0300f5f237c1379 Mon Sep 17 00:00:00 2001
From: Carles Fernandez <carles.fernandez@gmail.com>
Date: Tue, 18 Feb 2020 22:46:22 +0100
Subject: [PATCH] Remove unused includes, improve README

---
 src/utils/rinex-tools/CMakeLists.txt  | 5 ++++-
 src/utils/rinex-tools/README.md       | 3 ++-
 src/utils/rinex-tools/obsdiff.cc      | 6 +-----
 src/utils/rinex-tools/obsdiff_flags.h | 1 -
 4 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/src/utils/rinex-tools/CMakeLists.txt b/src/utils/rinex-tools/CMakeLists.txt
index 23f9d5261..40ddefb30 100644
--- a/src/utils/rinex-tools/CMakeLists.txt
+++ b/src/utils/rinex-tools/CMakeLists.txt
@@ -34,6 +34,10 @@ if("${ARMADILLO_VERSION_STRING}" VERSION_GREATER "9.800" OR (NOT ARMADILLO_FOUND
     if(NOT MATIO_FOUND OR MATIO_VERSION_STRING VERSION_LESS ${GNSSSDR_MATIO_MIN_VERSION})
         add_dependencies(obsdiff matio-${GNSSSDR_MATIO_LOCAL_VERSION})
     endif()
+    find_package(Gnuplot QUIET)
+    if(GNUPLOT_FOUND)
+        add_definitions(-DGNUPLOT_EXECUTABLE="${GNUPLOT_EXECUTABLE}")
+    endif()
 
     target_link_libraries(obsdiff
         PUBLIC
@@ -41,7 +45,6 @@ if("${ARMADILLO_VERSION_STRING}" VERSION_GREATER "9.800" OR (NOT ARMADILLO_FOUND
             Threads::Threads
             Gflags::gflags
             Matio::matio
-            core_system_parameters
             ${GPSTK_LIBRARY}
     )
 
diff --git a/src/utils/rinex-tools/README.md b/src/utils/rinex-tools/README.md
index d574677d5..32f525d4f 100644
--- a/src/utils/rinex-tools/README.md
+++ b/src/utils/rinex-tools/README.md
@@ -19,7 +19,8 @@ Requirements:
  * [GPSTK](https://github.com/SGL-UT/GPSTk): The GPS Toolkit, used for RINEX files reading. If not found in your system, the latest version will be downloaded, built and linked for you at building time.
  * [Matio](https://github.com/tbeu/matio): A MATLAB MAT File I/O Library, version >= 1.5.3. If it is not found, or an older version is found, CMake will download, build and link a recent version for you at building time.
 
-
+Optional:
+ * [Gnuplot](http://www.gnuplot.info/): a portable command-line driven graphing utility.
 
 This program is built along with GNSS-SDR if the options `ENABLE_UNIT_TESTING_EXTRA` or `ENABLE_SYSTEM_TESTING_EXTRA` are set to `ON` when calling CMake:
 
diff --git a/src/utils/rinex-tools/obsdiff.cc b/src/utils/rinex-tools/obsdiff.cc
index b2db9bafd..0f5d7130f 100644
--- a/src/utils/rinex-tools/obsdiff.cc
+++ b/src/utils/rinex-tools/obsdiff.cc
@@ -1,6 +1,6 @@
 /*!
  * \file obsdiff.cc
- * \brief  This class implements a single difference and double difference
+ * \brief This program implements a single difference and double difference
  * comparison algorithm to evaluate receiver's performance at observable level
  * \authors <ul>
  *          <li> Javier Arribas, 2020. jarribas(at)cttc.es
@@ -21,7 +21,6 @@
  * -------------------------------------------------------------------------
  */
 
-#include "MATH_CONSTANTS.h"
 #include "gnuplot_i.h"
 #include "obsdiff_flags.h"
 #include <armadillo>
@@ -33,13 +32,10 @@
 #include <matio.h>
 #include <algorithm>
 #include <array>
-#include <chrono>
 #include <cmath>
 #include <fstream>
 #include <map>
-#include <numeric>
 #include <set>
-#include <thread>
 
 
 // Create the lists of GNSS satellites
diff --git a/src/utils/rinex-tools/obsdiff_flags.h b/src/utils/rinex-tools/obsdiff_flags.h
index 77d6808d3..d5cb59cda 100644
--- a/src/utils/rinex-tools/obsdiff_flags.h
+++ b/src/utils/rinex-tools/obsdiff_flags.h
@@ -22,7 +22,6 @@
 #define GNSS_SDR_OBSDIFF_FLAGS_H
 
 #include <gflags/gflags.h>
-#include <limits>
 
 DEFINE_double(skip_obs_transitory_s, 30.0, "Skip the initial observable outputs to avoid transitory results [s]");
 DEFINE_double(skip_obs_ends_s, 5.0, "Skip the lasts observable outputs to avoid transitory results [s]");