From 7fc58001ecfbdff7ee5f36675bc030ad2ccc3dd1 Mon Sep 17 00:00:00 2001 From: Leonardo Tonetto Date: Mon, 5 May 2014 11:21:18 +0200 Subject: [PATCH] Avoid memory leak According to the best practices for boost, the shared_ptr constructor should not be called inside a function call (return in this case). Ref: http://www.boost.org/doc/libs/1_55_0/libs/smart_ptr/shared_ptr.htm Signed-off-by: Javier Arribas --- src/algorithms/libs/gnss_sdr_valve.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/algorithms/libs/gnss_sdr_valve.cc b/src/algorithms/libs/gnss_sdr_valve.cc index 9e07f7a20..d7dcf8237 100644 --- a/src/algorithms/libs/gnss_sdr_valve.cc +++ b/src/algorithms/libs/gnss_sdr_valve.cc @@ -49,7 +49,8 @@ boost::shared_ptr gnss_sdr_make_valve (size_t sizeof_stream_item, unsigned long long nitems, gr::msg_queue::sptr queue) { - return boost::shared_ptr (new gnss_sdr_valve (sizeof_stream_item, nitems, queue)); + boost::shared_ptr valve_(new gnss_sdr_valve(sizeof_stream_item, nitems, queue)); + return valve_; }