mirrors
/
gnss-sdr
mirror of https://github.com/gnss-sdr/gnss-sdr
1
0
Fork 0
Code Issues Releases Wiki Activity

Fix compiler warning, avoid using std::strncat

This commit is contained in:
Carles Fernandez 2023-11-14 14:29:41 +01:00
parent f739eb698c
commit 7cfdcd3ae1
No known key found for this signature in database
GPG Key ID: 4C583C52B0C3877D
1 changed files with 16 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/algorithms/PVT/libs/rtcm.h
View File

@ -587,16 +587,24 @@ private:
inline bool decode_header()
{
char header[header_length + 1] = "";
std::strncat(header, data_.data(), header_length);
std::string header(data_.data(), header_length);
if (header[0] != 'G' || header[1] != 'S')
{
return false;
}
char header2_[header_length - 1] = "";
std::strncat(header2_, data_.data() + 2, header_length - 2);
body_length_ = std::atoi(header2_);
auto header2 = header.substr(2);
try
{
body_length_ = std::stoi(header2);
}
catch (const std::exception& e)
{
// invalid stoi conversion
body_length_ = 0;
return false;
}
if (body_length_ == 0)
{
return false;
@ -612,11 +620,11 @@ private:
inline void encode_header()
{
char header[header_length + 1] = "";
std::stringstream ss;
ss << "GS" << std::setw(4) << std::max(std::min(static_cast<int>(body_length_), static_cast<int>(max_body_length)), 0);
std::copy_n(ss.str().c_str(), header_length + 1, header);
std::copy_n(header, header_length, data_.data());
std::string header = ss.str();
header.resize(header_length, ' ');
std::copy(header.begin(), header.end(), data_.begin());
}
private: