fixing coverity issues

src/algorithms/acquisition/adapters/galileo_e1_pcps_8ms_ambiguous_acquisition.cc

@@ -106,7 +106,7 @@ GalileoE1Pcps8msAmbiguousAcquisition::GalileoE1Pcps8msAmbiguousAcquisition(
             LOG(WARNING) << item_type_
                     << " unknown acquisition item type";
         }
-    gnss_synchro_ = {0};
+    gnss_synchro_ = new Gnss_Synchro();
 }
 
 

src/algorithms/acquisition/adapters/galileo_e1_pcps_ambiguous_acquisition.cc

@@ -106,17 +106,14 @@ GalileoE1PcpsAmbiguousAcquisition::GalileoE1PcpsAmbiguousAcquisition(
                     shift_resolution_, if_, fs_in_, samples_per_ms, code_length_,
                     bit_transition_flag_, queue_, dump_, dump_filename_);
             stream_to_vector_ = gr::blocks::stream_to_vector::make(item_size_, vector_length_);
-            DLOG(INFO) << "stream_to_vector("
+            DLOG(INFO) << "stream_to_vector(" << stream_to_vector_->unique_id() << ")";
-                    << stream_to_vector_->unique_id() << ")";
+            DLOG(INFO) << "acquisition(" << acquisition_cc_->unique_id() << ")";
-            DLOG(INFO) << "acquisition(" << acquisition_cc_->unique_id()
-                    << ")";
         }
     else
         {
-            LOG(WARNING) << item_type_
+            LOG(WARNING) << item_type_ << " unknown acquisition item type";
-                    << " unknown acquisition item type";
         }
-    gnss_synchro_ = {0};
+    gnss_synchro_ = new Gnss_Synchro();
 }
 
 

src/algorithms/acquisition/adapters/galileo_e1_pcps_cccwsr_ambiguous_acquisition.cc

@@ -106,7 +106,7 @@ GalileoE1PcpsCccwsrAmbiguousAcquisition::GalileoE1PcpsCccwsrAmbiguousAcquisition
             LOG(WARNING) << item_type_
                     << " unknown acquisition item type";
         }
-    gnss_synchro_ = {0};
+    gnss_synchro_ = new Gnss_Synchro();
 }
 
 

src/algorithms/acquisition/adapters/galileo_e1_pcps_quicksync_ambiguous_acquisition.cc

@@ -140,7 +140,7 @@ GalileoE1PcpsQuickSyncAmbiguousAcquisition::GalileoE1PcpsQuickSyncAmbiguousAcqui
             LOG(WARNING) << item_type_
                     << " unknown acquisition item type";
         }
-    gnss_synchro_ = {0};
+    gnss_synchro_ = new Gnss_Synchro();
 }
 
 

src/algorithms/acquisition/adapters/galileo_e1_pcps_tong_ambiguous_acquisition.cc

@@ -107,7 +107,7 @@ GalileoE1PcpsTongAmbiguousAcquisition::GalileoE1PcpsTongAmbiguousAcquisition(
             LOG(WARNING) << item_type_
                     << " unknown acquisition item type";
         }
-    gnss_synchro_ = {0};
+    gnss_synchro_ = new Gnss_Synchro();
 }
 
 

src/algorithms/acquisition/adapters/galileo_e5a_noncoherent_iq_acquisition_caf.cc

@@ -114,15 +114,17 @@ GalileoE5aNoncoherentIQAcquisitionCaf::GalileoE5aNoncoherentIQAcquisitionCaf(
             LOG(WARNING) << item_type_
                     << " unknown acquisition item type";
         }
-    gnss_synchro_ = {0};
+    gnss_synchro_ = new Gnss_Synchro();
 }
 
+
 GalileoE5aNoncoherentIQAcquisitionCaf::~GalileoE5aNoncoherentIQAcquisitionCaf()
 {
-	delete[] codeI_;
+    delete[] codeI_;
-	delete[] codeQ_;
+    delete[] codeQ_;
 }
 
+
 void GalileoE5aNoncoherentIQAcquisitionCaf::set_channel(unsigned int channel)
 {
     channel_ = channel;

src/algorithms/acquisition/adapters/gps_l1_ca_pcps_acquisition.cc

@@ -121,13 +121,13 @@ GpsL1CaPcpsAcquisition::GpsL1CaPcpsAcquisition(
     threshold_ = 0.0;
     doppler_max_ = 0;
     doppler_step_ = 0;
-    gnss_synchro_ = {0};
+    gnss_synchro_ = new Gnss_Synchro();
 }
 
 
 GpsL1CaPcpsAcquisition::~GpsL1CaPcpsAcquisition()
 {
-	delete[] code_;
+    delete[] code_;
 }
 
 

src/algorithms/acquisition/adapters/gps_l1_ca_pcps_acquisition_fine_doppler.cc

@@ -86,13 +86,13 @@ GpsL1CaPcpsAcquisitionFineDoppler::GpsL1CaPcpsAcquisitionFineDoppler(
     {
         LOG(WARNING) << item_type_ << " unknown acquisition item type";
     }
-    gnss_synchro_ = {0};
+    gnss_synchro_ = new Gnss_Synchro();
 }
 
 
 GpsL1CaPcpsAcquisitionFineDoppler::~GpsL1CaPcpsAcquisitionFineDoppler()
 {
-	delete[] code_;
+    delete[] code_;
 }
 
 

src/algorithms/acquisition/adapters/gps_l1_ca_pcps_assisted_acquisition.cc

@@ -85,13 +85,13 @@ GpsL1CaPcpsAssistedAcquisition::GpsL1CaPcpsAssistedAcquisition(
     {
         LOG(WARNING) << item_type_ << " unknown acquisition item type";
     }
-    gnss_synchro_ = {0};
+    gnss_synchro_ = new Gnss_Synchro();
 }
 
 
 GpsL1CaPcpsAssistedAcquisition::~GpsL1CaPcpsAssistedAcquisition()
 {
-	delete[] code_;
+    delete[] code_;
 }
 
 

src/algorithms/acquisition/adapters/gps_l1_ca_pcps_multithread_acquisition.cc

@@ -103,13 +103,13 @@ GpsL1CaPcpsMultithreadAcquisition::GpsL1CaPcpsMultithreadAcquisition(
     {
         LOG(WARNING) << item_type_ << " unknown acquisition item type";
     }
-    gnss_synchro_ = {0};
+    gnss_synchro_ = new Gnss_Synchro();
 }
 
 
 GpsL1CaPcpsMultithreadAcquisition::~GpsL1CaPcpsMultithreadAcquisition()
 {
-	delete[] code_;
+    delete[] code_;
 }
 
 

src/algorithms/acquisition/adapters/gps_l1_ca_pcps_opencl_acquisition.cc

@@ -93,22 +93,20 @@ GpsL1CaPcpsOpenClAcquisition::GpsL1CaPcpsOpenClAcquisition(
 
         stream_to_vector_ = gr::blocks::stream_to_vector::make(item_size_, vector_length_);
 
-        DLOG(INFO) << "stream_to_vector(" << stream_to_vector_->unique_id()
+        DLOG(INFO) << "stream_to_vector(" << stream_to_vector_->unique_id() << ")";
-                << ")";
+        DLOG(INFO) << "acquisition(" << acquisition_cc_->unique_id() << ")";
-        DLOG(INFO) << "acquisition(" << acquisition_cc_->unique_id()
-                << ")";
     }
     else
     {
         LOG(WARNING) << item_type_ << " unknown acquisition item type";
     }
-    gnss_synchro_ = {0};
+    gnss_synchro_ = new Gnss_Synchro();
 }
 
 
 GpsL1CaPcpsOpenClAcquisition::~GpsL1CaPcpsOpenClAcquisition()
 {
-	delete[] code_;
+    delete[] code_;
 }
 
 

src/algorithms/acquisition/adapters/gps_l1_ca_pcps_quicksync_acquisition.cc

@@ -135,7 +135,7 @@ GpsL1CaPcpsQuickSyncAcquisition::GpsL1CaPcpsQuickSyncAcquisition(
             LOG(WARNING) << item_type_ << " unknown acquisition item type";
         }
 
-    gnss_synchro_ = {0};
+    gnss_synchro_ = new Gnss_Synchro();
 }
 
 

src/algorithms/acquisition/adapters/gps_l1_ca_pcps_tong_acquisition.cc

@@ -95,13 +95,13 @@ GpsL1CaPcpsTongAcquisition::GpsL1CaPcpsTongAcquisition(
         {
             LOG(WARNING) << item_type_ << " unknown acquisition item type";
         }
-    gnss_synchro_ = {0};
+    gnss_synchro_ = new Gnss_Synchro();
 }
 
 
 GpsL1CaPcpsTongAcquisition::~GpsL1CaPcpsTongAcquisition()
 {
-	delete[] code_;
+    delete[] code_;
 }
 
 

src/algorithms/acquisition/adapters/gps_l2_m_pcps_acquisition.cc

@@ -118,13 +118,13 @@ GpsL2MPcpsAcquisition::GpsL2MPcpsAcquisition(
     //     LOG(WARNING) << item_type_
     //             << " unknown acquisition item type";
     // }
-    gnss_synchro_ = {0};
+    gnss_synchro_ = new Gnss_Synchro();
 }
 
 
 GpsL2MPcpsAcquisition::~GpsL2MPcpsAcquisition()
 {
-	delete[] code_;
+    delete[] code_;
 }
 
 
@@ -144,7 +144,7 @@ void GpsL2MPcpsAcquisition::set_threshold(float threshold)
 
     if(pfa == 0.0)
         {
-            pfa = configuration_->property(role_+".pfa", 0.0);
+            pfa = configuration_->property(role_ + ".pfa", 0.0);
         }
     if(pfa == 0.0)
         {

src/tests/gnss_block/galileo_e1_dll_pll_veml_tracking_test.cc

@@ -59,7 +59,7 @@ protected:
         item_size = sizeof(gr_complex);
         stop = false;
         message = 0;
-        gnss_synchro = {0};
+        gnss_synchro = Gnss_Synchro();
     }
 
     ~GalileoE1DllPllVemlTrackingInternalTest()

src/tests/gnss_block/galileo_e1_pcps_8ms_ambiguous_acquisition_gsoc2013_test.cc

@@ -61,7 +61,7 @@ protected:
         stop = false;
         message = 0;
         factory = std::make_shared<GNSSBlockFactory>();
-        gnss_synchro = {0};
+        gnss_synchro = Gnss_Synchro();
         init();
     }
 

src/tests/gnss_block/galileo_e1_pcps_ambiguous_acquisition_gsoc2013_test.cc

@@ -61,7 +61,7 @@ protected:
         item_size = sizeof(gr_complex);
         stop = false;
         message = 0;
-        gnss_synchro = {0};
+        gnss_synchro = Gnss_Synchro();
     }
 
     ~GalileoE1PcpsAmbiguousAcquisitionGSoC2013Test()

src/tests/gnss_block/galileo_e1_pcps_ambiguous_acquisition_gsoc_test.cc

@@ -70,7 +70,7 @@ protected:
         item_size = sizeof(gr_complex);
         stop = false;
         message = 0;
-        gnss_synchro = {0};
+        gnss_synchro = Gnss_Synchro();
     }
 
     ~GalileoE1PcpsAmbiguousAcquisitionGSoCTest()

src/tests/gnss_block/galileo_e1_pcps_ambiguous_acquisition_test.cc

@@ -60,7 +60,7 @@ protected:
         item_size = sizeof(gr_complex);
         stop = false;
         message = 0;
-        gnss_synchro = {0};
+        gnss_synchro = Gnss_Synchro();
 }
 
     ~GalileoE1PcpsAmbiguousAcquisitionTest()

src/tests/gnss_block/galileo_e1_pcps_cccwsr_ambiguous_acquisition_gsoc2013_test.cc

@@ -61,7 +61,7 @@ protected:
         item_size = sizeof(gr_complex);
         stop = false;
         message = 0;
-        gnss_synchro = {0};
+        gnss_synchro = Gnss_Synchro();
         init();
     }
 

src/tests/gnss_block/galileo_e1_pcps_quicksync_ambiguous_acquisition_gsoc2014_test.cc

@@ -67,7 +67,7 @@ protected:
         item_size = sizeof(gr_complex);
         stop = false;
         message = 0;
-        gnss_synchro = {0};
+        gnss_synchro = Gnss_Synchro();
         init();
 }
 

src/tests/gnss_block/galileo_e1_pcps_tong_ambiguous_acquisition_gsoc2013_test.cc

@@ -67,7 +67,7 @@ protected:
         item_size = sizeof(gr_complex);
         stop = false;
         message = 0;
-        gnss_synchro = {0};
+        gnss_synchro = Gnss_Synchro();
         init();
     }
 

src/tests/gnss_block/galileo_e5a_pcps_acquisition_gsoc2014_gensource_test.cc

@@ -62,7 +62,7 @@ protected:
         item_size = sizeof(gr_complex);
         stop = false;
         message = 0;
-        gnss_synchro = {0};
+        gnss_synchro = Gnss_Synchro();
         init();
 }
 

src/tests/gnss_block/galileo_e5a_tracking_test.cc

@@ -58,7 +58,7 @@ protected:
         item_size = sizeof(gr_complex);
         stop = false;
         message = 0;
-        gnss_synchro = {0};
+        gnss_synchro = Gnss_Synchro();
     }
 
     ~GalileoE5aTrackingTest()

src/tests/gnss_block/gps_l1_ca_pcps_acquisition_gsoc2013_test.cc

@@ -62,7 +62,7 @@ protected:
         item_size = sizeof(gr_complex);
         stop = false;
         message = 0;
-        gnss_synchro = {0};
+        gnss_synchro = Gnss_Synchro();
     }
 
     ~GpsL1CaPcpsAcquisitionGSoC2013Test()

src/tests/gnss_block/gps_l1_ca_pcps_acquisition_test.cc

@@ -62,7 +62,7 @@ protected:
         item_size = sizeof(gr_complex);
         stop = false;
         message = 0;
-        gnss_synchro = {0};
+        gnss_synchro = Gnss_Synchro();
     }
 
     ~GpsL1CaPcpsAcquisitionTest()

src/tests/gnss_block/gps_l1_ca_pcps_multithread_acquisition_gsoc2013_test.cc

@@ -66,7 +66,7 @@ protected:
         item_size = sizeof(gr_complex);
         stop = false;
         message = 0;
-        gnss_synchro = {0};
+        gnss_synchro = Gnss_Synchro();
     }
 
     ~GpsL1CaPcpsMultithreadAcquisitionGSoC2013Test()

src/tests/gnss_block/gps_l1_ca_pcps_opencl_acquisition_gsoc2013_test.cc

@@ -62,7 +62,7 @@ protected:
         item_size = sizeof(gr_complex);
         stop = false;
         message = 0;
-        gnss_synchro = {0};
+        gnss_synchro = Gnss_Synchro();
         init();
     }
 

src/tests/gnss_block/gps_l1_ca_pcps_quicksync_acquisition_gsoc2014_test.cc

@@ -66,7 +66,7 @@ protected:
         item_size = sizeof(gr_complex);
         stop = false;
         message = 0;
-        gnss_synchro = {0};
+        gnss_synchro = Gnss_Synchro();
 }
 
     ~GpsL1CaPcpsQuickSyncAcquisitionGSoC2014Test()

src/tests/gnss_block/gps_l1_ca_pcps_tong_acquisition_gsoc2013_test.cc

@@ -63,7 +63,7 @@ protected:
         item_size = sizeof(gr_complex);
         stop = false;
         message = 0;
-        gnss_synchro = {0};
+        gnss_synchro = Gnss_Synchro();
     }
 
     ~GpsL1CaPcpsTongAcquisitionGSoC2013Test()

src/tests/gnss_block/gps_l2_m_dll_pll_tracking_test.cc

@@ -60,7 +60,7 @@ protected:
         item_size = sizeof(gr_complex);
         stop = false;
         message = 0;
-        gnss_synchro = {0};
+        gnss_synchro = Gnss_Synchro();
     }
 
     ~GpsL2MDllPllTrackingTest()

src/tests/gnss_block/gps_l2_m_pcps_acquisition_test.cc

@@ -68,7 +68,7 @@ protected:
         message = 0;
         sampling_freqeuncy_hz = 0;
         nsamples = 0;
-        gnss_synchro = {0};
+        gnss_synchro = Gnss_Synchro();
     }
 
     ~GpsL2MPcpsAcquisitionTest()