mirrors/gnss-sdr
1
0
Fork 0
mirror of https://github.com/gnss-sdr/gnss-sdr synced 2025-05-05 08:54:11 +00:00
Code Issues Releases Wiki Activity

fix defect detected by coverity scan

Browse Source 
aStr->find('.', startPos) can return a negative number, but idx was
passed to a parameter that cannot be negative. Now the function returns
the string as is in case of no decimal point found.
This commit is contained in:
Carles Fernandez 2016-01-06 14:30:15 +01:00
parent 5b2645a964
commit 5743f0f631
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/algorithms/PVT/libs/rinex_printer.h
View File

@ -515,9 +515,10 @@ inline std::string & Rinex_Printer::sci2for(std::string & aStr,
bool redoexp =! checkSwitch; bool redoexp =! checkSwitch;
// Check for decimal place within specified boundaries // Check for decimal place within specified boundaries
if ((idx == 0) || (idx >= (startPos + length - expLen - 1))) if ((idx <= 0) || (idx >= (startPos + length - expLen - 1)))
{ {
// Error: no decimal point in string // Error: no decimal point in string
return aStr;
} }
// Here, account for the possibility that there are // Here, account for the possibility that there are
@ -525,12 +526,12 @@ inline std::string & Rinex_Printer::sci2for(std::string & aStr,
// account for the possibility of non-scientific // account for the possibility of non-scientific
// notation (more than one digit to the left of the // notation (more than one digit to the left of the
// decimal) // decimal)
if ((idx > startPos) && (idx >= 1)) if (idx > startPos)
{ {
redoexp = true; redoexp = true;
// Swap digit and decimal. // Swap digit and decimal.
aStr[static_cast<unsigned int>(idx)] = aStr[static_cast<unsigned int>(idx - 1)]; aStr[idx] = aStr[idx - 1];
aStr[static_cast<unsigned int>(idx - 1)] = '.'; aStr[idx - 1] = '.';
// Only add one to the exponent if the number is non-zero // Only add one to the exponent if the number is non-zero
if (asDouble(aStr.substr(startPos, length)) != 0.0) if (asDouble(aStr.substr(startPos, length)) != 0.0)
expAdd = 1; expAdd = 1;