mirror of
				https://github.com/gnss-sdr/gnss-sdr
				synced 2025-10-29 22:42:59 +00:00 
			
		
		
		
	reverted LOG4CPP work-around
The existing CMake logic is broken-ish; or rather log4cpp is broken-ish, and this inhibits the use of C++17 std::filesystem. All of the static libraries created are brittle; consider changing from STATIC to OBJECT in the future?
This commit is contained in:
		| @@ -607,7 +607,7 @@ if(NOT ENABLE_OWN_GPSTK) | |||||||
|         PURPOSE "Used in some Extra Tests." |         PURPOSE "Used in some Extra Tests." | ||||||
|     ) |     ) | ||||||
| endif() | endif() | ||||||
| #if(NOT (GNURADIO_VERSION VERSION_LESS 3.8) AND LOG4CPP_READY_FOR_CXX17) | if(NOT (GNURADIO_VERSION VERSION_LESS 3.8) AND LOG4CPP_READY_FOR_CXX17) | ||||||
|     # Check if we have std::filesystem |     # Check if we have std::filesystem | ||||||
|     if(NOT (CMAKE_VERSION VERSION_LESS 3.8)) |     if(NOT (CMAKE_VERSION VERSION_LESS 3.8)) | ||||||
|         if(NOT GPSTK_FOUND OR NOT (GPSTK_FOUND AND GPSTK_OLDER_THAN_8))  # Fix for GPSTk < 8.0.0 |         if(NOT GPSTK_FOUND OR NOT (GPSTK_FOUND AND GPSTK_OLDER_THAN_8))  # Fix for GPSTk < 8.0.0 | ||||||
| @@ -628,12 +628,7 @@ endif() | |||||||
|             set(CMAKE_CXX_STANDARD_REQUIRED ON) |             set(CMAKE_CXX_STANDARD_REQUIRED ON) | ||||||
|         endif() |         endif() | ||||||
|     endif() |     endif() | ||||||
| #endif() | endif() | ||||||
| message(ALERT " debugging CMake ..." |  | ||||||
| "\n     GNURADIO_VERSION=${GNURADIO_VERSION}" |  | ||||||
| #"\n     LOG4CPP_READY_FOR_CXX17=${LOG4CPP_READY_FOR_CXX17}" |  | ||||||
| "\n     CMAKE_CXX_STANDARD=${CMAKE_CXX_STANDARD}" |  | ||||||
| ) |  | ||||||
|  |  | ||||||
|  |  | ||||||
|  |  | ||||||
|   | |||||||
		Reference in New Issue
	
	Block a user
	 Jim Melton
					Jim Melton