diff --git a/CMakeLists.txt b/CMakeLists.txt index 62771f913..69f301fd0 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -402,6 +402,11 @@ if(NOT (${CMAKE_SYSTEM_NAME} MATCHES "Darwin")) endif() endif() +################################################################################ +# pkg-config - Helper tool used when compiling applications and libraries. +################################################################################ +set(PKG_CONFIG_USE_CMAKE_PREFIX_PATH TRUE) +find_package(PkgConfig) ################################################################################ diff --git a/cmake/Modules/FindGLOG.cmake b/cmake/Modules/FindGLOG.cmake index 396430aff..3cb6ff3e4 100644 --- a/cmake/Modules/FindGLOG.cmake +++ b/cmake/Modules/FindGLOG.cmake @@ -36,8 +36,6 @@ else() set(LIB_PATHS ${GLOG_ROOT} ${GLOG_ROOT}/lib) endif() -set(PKG_CONFIG_USE_CMAKE_PREFIX_PATH TRUE) -include(FindPkgConfig) pkg_check_modules(PC_GLOG libglog) macro(_FIND_GLOG_LIBRARIES _var) diff --git a/cmake/Modules/FindGNURADIO.cmake b/cmake/Modules/FindGNURADIO.cmake index c2f96b313..b68d5e04e 100644 --- a/cmake/Modules/FindGNURADIO.cmake +++ b/cmake/Modules/FindGNURADIO.cmake @@ -14,10 +14,6 @@ if(NOT COMMAND feature_summary) include(FeatureSummary) endif() -set(PKG_CONFIG_USE_CMAKE_PREFIX_PATH TRUE) -include(FindPkgConfig) -include(FindPackageHandleStandardArgs) - # if GR_REQUIRED_COMPONENTS is not defined, it will be set to the following list if(NOT GR_REQUIRED_COMPONENTS) set(GR_REQUIRED_COMPONENTS RUNTIME PMT BLOCKS FFT FILTER ANALOG) @@ -131,7 +127,9 @@ function(GR_MODULE EXTVAR PCNAME INCFILE LIBFILE) set(GNURADIO_ALL_INCLUDE_DIRS ${GNURADIO_ALL_INCLUDE_DIRS} ${GNURADIO_${EXTVAR}_INCLUDE_DIRS} PARENT_SCOPE) set(GNURADIO_ALL_LIBRARIES ${GNURADIO_ALL_LIBRARIES} ${GNURADIO_${EXTVAR}_LIBRARIES} PARENT_SCOPE) - find_package_handle_standard_args(GNURADIO_${EXTVAR} DEFAULT_MSG GNURADIO_${EXTVAR}_LIBRARIES GNURADIO_${EXTVAR}_INCLUDE_DIRS) + if(GNURADIO_${EXTVAR}_LIBRARIES AND GNURADIO_${EXTVAR}_INCLUDE_DIRS) + set(GNURADIO_${EXTVAR}_FOUND TRUE) + endif() message(STATUS "GNURADIO_${EXTVAR}_FOUND = ${GNURADIO_${EXTVAR}_FOUND}") set(GNURADIO_${EXTVAR}_FOUND ${GNURADIO_${EXTVAR}_FOUND} PARENT_SCOPE) @@ -334,8 +332,9 @@ if(GNURADIO_VERSION VERSION_GREATER 3.8.99) message(STATUS " * INCLUDES=${GNURADIO_IIO_INCLUDE_DIRS}") message(STATUS " * LIBS=${GNURADIO_IIO_LIBRARIES}") endif() - find_package_handle_standard_args(GNURADIO_IIO DEFAULT_MSG GNURADIO_IIO_LIBRARIES GNURADIO_IIO_INCLUDE_DIRS) - + if(GNURADIO_IIO_LIBRARIES AND GNURADIO_IIO_INCLUDE_DIRS) + set(GNURADIO_IIO_FOUND TRUE) + endif() if(GNURADIO_IIO_FOUND) message(STATUS "GNURADIO_IIO_FOUND = ${GNURADIO_IIO_FOUND}") # append to all includes and libs list diff --git a/cmake/Modules/FindGOOGLETEST.cmake b/cmake/Modules/FindGOOGLETEST.cmake index 9f5b9c65d..2b9013576 100644 --- a/cmake/Modules/FindGOOGLETEST.cmake +++ b/cmake/Modules/FindGOOGLETEST.cmake @@ -21,8 +21,6 @@ if(NOT COMMAND feature_summary) include(FeatureSummary) endif() -set(PKG_CONFIG_USE_CMAKE_PREFIX_PATH TRUE) -include(FindPkgConfig) pkg_check_modules(PC_GTEST gtest) find_path(LIBGTEST_DEV_DIR diff --git a/cmake/Modules/FindGRDBFCTTC.cmake b/cmake/Modules/FindGRDBFCTTC.cmake index 2ded49a1c..f6d1af18c 100644 --- a/cmake/Modules/FindGRDBFCTTC.cmake +++ b/cmake/Modules/FindGRDBFCTTC.cmake @@ -15,8 +15,6 @@ # Gnuradio::dbfcttc # -set(PKG_CONFIG_USE_CMAKE_PREFIX_PATH TRUE) -include(FindPkgConfig) pkg_check_modules(PC_GR_DBFCTTC gr-dbfcttc) find_path( diff --git a/cmake/Modules/FindGRGN3S.cmake b/cmake/Modules/FindGRGN3S.cmake index 3b0b83f9e..ed0ae640b 100644 --- a/cmake/Modules/FindGRGN3S.cmake +++ b/cmake/Modules/FindGRGN3S.cmake @@ -15,8 +15,6 @@ # Gnuradio::gn3s # -set(PKG_CONFIG_USE_CMAKE_PREFIX_PATH TRUE) -include(FindPkgConfig) pkg_check_modules(PC_GR_GN3S gr-gn3s) find_path( diff --git a/cmake/Modules/FindGRIIO.cmake b/cmake/Modules/FindGRIIO.cmake index 8e3bcd6ea..947258747 100644 --- a/cmake/Modules/FindGRIIO.cmake +++ b/cmake/Modules/FindGRIIO.cmake @@ -15,8 +15,6 @@ if(NOT COMMAND feature_summary) include(FeatureSummary) endif() -set(PKG_CONFIG_USE_CMAKE_PREFIX_PATH TRUE) -include(FindPkgConfig) pkg_check_modules(PC_IIO gnuradio-iio) find_path(IIO_INCLUDE_DIRS diff --git a/cmake/Modules/FindGROSMOSDR.cmake b/cmake/Modules/FindGROSMOSDR.cmake index aa495e1fb..59fcf49b8 100644 --- a/cmake/Modules/FindGROSMOSDR.cmake +++ b/cmake/Modules/FindGROSMOSDR.cmake @@ -33,8 +33,6 @@ if(NOT COMMAND feature_summary) include(FeatureSummary) endif() -set(PKG_CONFIG_USE_CMAKE_PREFIX_PATH TRUE) -include(FindPkgConfig) pkg_check_modules(GROSMOSDR_PKG gnuradio-osmosdr) find_path(GROSMOSDR_INCLUDE_DIR diff --git a/cmake/Modules/FindLIBAD9361.cmake b/cmake/Modules/FindLIBAD9361.cmake index cde0a4dd5..1bcaf4c9c 100644 --- a/cmake/Modules/FindLIBAD9361.cmake +++ b/cmake/Modules/FindLIBAD9361.cmake @@ -15,8 +15,6 @@ if(NOT COMMAND feature_summary) include(FeatureSummary) endif() -set(PKG_CONFIG_USE_CMAKE_PREFIX_PATH TRUE) -include(FindPkgConfig) pkg_check_modules(PC_LIBAD9361 libad9361) find_path(LIBAD9361_INCLUDE_DIRS diff --git a/cmake/Modules/FindLIBIIO.cmake b/cmake/Modules/FindLIBIIO.cmake index 07888bcb1..d4243b1d2 100644 --- a/cmake/Modules/FindLIBIIO.cmake +++ b/cmake/Modules/FindLIBIIO.cmake @@ -15,8 +15,6 @@ if(NOT COMMAND feature_summary) include(FeatureSummary) endif() -set(PKG_CONFIG_USE_CMAKE_PREFIX_PATH TRUE) -include(FindPkgConfig) pkg_check_modules(PC_LIBIIO libiio) find_path( diff --git a/cmake/Modules/FindLOG4CPP.cmake b/cmake/Modules/FindLOG4CPP.cmake index ef0d86e4e..f377ddde5 100644 --- a/cmake/Modules/FindLOG4CPP.cmake +++ b/cmake/Modules/FindLOG4CPP.cmake @@ -21,8 +21,6 @@ if(NOT COMMAND feature_summary) include(FeatureSummary) endif() -set(PKG_CONFIG_USE_CMAKE_PREFIX_PATH TRUE) -include(FindPkgConfig) pkg_check_modules(PC_LOG4CPP log4cpp QUIET) if(LOG4CPP_INCLUDE_DIR) diff --git a/cmake/Modules/FindORC.cmake b/cmake/Modules/FindORC.cmake index 60c958c02..0d3286c6f 100644 --- a/cmake/Modules/FindORC.cmake +++ b/cmake/Modules/FindORC.cmake @@ -10,8 +10,6 @@ if(NOT COMMAND feature_summary) include(FeatureSummary) endif() -set(PKG_CONFIG_USE_CMAKE_PREFIX_PATH TRUE) -include(FindPkgConfig) pkg_check_modules(PC_ORC "orc-0.4 > 0.4.22") find_program(ORCC_EXECUTABLE orcc diff --git a/cmake/Modules/FindPCAP.cmake b/cmake/Modules/FindPCAP.cmake index bb5b703e0..25e64ef8e 100644 --- a/cmake/Modules/FindPCAP.cmake +++ b/cmake/Modules/FindPCAP.cmake @@ -27,8 +27,6 @@ if(NOT COMMAND feature_summary) include(FeatureSummary) endif() -set(PKG_CONFIG_USE_CMAKE_PREFIX_PATH TRUE) -include(FindPkgConfig) pkg_check_modules(PC_PCAP libpcap QUIET) if(EXISTS $ENV{PCAPDIR}) diff --git a/cmake/Modules/FindPUGIXML.cmake b/cmake/Modules/FindPUGIXML.cmake index d2b5c279d..b3c70afa9 100644 --- a/cmake/Modules/FindPUGIXML.cmake +++ b/cmake/Modules/FindPUGIXML.cmake @@ -22,8 +22,6 @@ if(NOT COMMAND feature_summary) include(FeatureSummary) endif() -set(PKG_CONFIG_USE_CMAKE_PREFIX_PATH TRUE) -include(FindPkgConfig) pkg_check_modules(PC_PUGIXML pugixml QUIET) find_path(PUGIXML_INCLUDE_DIR diff --git a/cmake/Modules/FindTELEORBIT.cmake b/cmake/Modules/FindTELEORBIT.cmake index 5989fefe6..9dfe44209 100644 --- a/cmake/Modules/FindTELEORBIT.cmake +++ b/cmake/Modules/FindTELEORBIT.cmake @@ -15,8 +15,6 @@ if(NOT COMMAND feature_summary) include(FeatureSummary) endif() -set(PKG_CONFIG_USE_CMAKE_PREFIX_PATH TRUE) -include(FindPkgConfig) pkg_check_modules(PC_TELEORBIT teleorbit QUIET) find_path(TELEORBIT_INCLUDE_DIRS diff --git a/cmake/Modules/FindUHD.cmake b/cmake/Modules/FindUHD.cmake index 396629a54..dde27ccc9 100644 --- a/cmake/Modules/FindUHD.cmake +++ b/cmake/Modules/FindUHD.cmake @@ -18,8 +18,6 @@ if(NOT COMMAND feature_summary) include(FeatureSummary) endif() -set(PKG_CONFIG_USE_CMAKE_PREFIX_PATH TRUE) -include(FindPkgConfig) pkg_check_modules(PC_UHD uhd) find_path(UHD_INCLUDE_DIRS diff --git a/cmake/Modules/FindVOLK.cmake b/cmake/Modules/FindVOLK.cmake index 3ffd3972e..5e10e54fa 100644 --- a/cmake/Modules/FindVOLK.cmake +++ b/cmake/Modules/FindVOLK.cmake @@ -18,8 +18,6 @@ if(NOT COMMAND feature_summary) include(FeatureSummary) endif() -set(PKG_CONFIG_USE_CMAKE_PREFIX_PATH TRUE) -include(FindPkgConfig) pkg_check_modules(PC_VOLK volk QUIET) find_path(VOLK_INCLUDE_DIRS diff --git a/cmake/Modules/FindVOLKGNSSSDR.cmake b/cmake/Modules/FindVOLKGNSSSDR.cmake index 0a7d833ed..66435b08d 100644 --- a/cmake/Modules/FindVOLKGNSSSDR.cmake +++ b/cmake/Modules/FindVOLKGNSSSDR.cmake @@ -19,8 +19,6 @@ if(NOT COMMAND feature_summary) include(FeatureSummary) endif() -set(PKG_CONFIG_USE_CMAKE_PREFIX_PATH TRUE) -include(FindPkgConfig) pkg_check_modules(PC_VOLK_GNSSSDR QUIET volk_gnsssdr) find_path(VOLK_GNSSSDR_INCLUDE_DIRS diff --git a/docs/changelog b/docs/changelog index 5427fe4bb..f08b35892 100644 --- a/docs/changelog +++ b/docs/changelog @@ -69,6 +69,7 @@ SPDX-License-Identifier: GPL-3.0-or-later - Now the volk_gnsssdr library can be built on Microsoft Windows. - Now the volk_gnsssdr library makes use of C11 aligned_alloc where available. - Improved CMake script for cross-compilation and for the detection of AVX, AVX2 and NEON (v7 and v8) instructions. +- Fixed warnings raised by CMake 3.17. ### Improvements in Reliability: