From 48b62e958544a055b4a69dc65a009f88cfd8f9b0 Mon Sep 17 00:00:00 2001
From: Carles Fernandez <carles.fernandez@gmail.com>
Date: Fri, 24 Sep 2021 16:52:13 +0200
Subject: [PATCH] If dump_filename points to a non-existing folder, try to
 create it

---
 docs/CHANGELOG.md                             |  5 +++
 .../adapters/uhd_signal_source.cc             | 36 ++++++++++++++++---
 2 files changed, 37 insertions(+), 4 deletions(-)

diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
index 6727a84dc..384855c81 100644
--- a/docs/CHANGELOG.md
+++ b/docs/CHANGELOG.md
@@ -34,6 +34,11 @@ All notable changes to GNSS-SDR will be documented in this file.
   `TelemetryDecoder_XX.dump_crc_stats_filename=./crc_stats` in the configuration
   file. At the end of the processing (or exiting with `q` + `[Enter]`), the CRC
   check success rate will be reported in a file.
+- The `UHD_Signal_Source` learned to dump data in folders that do not exist,
+  *e.g.*, if `SignalSource.dump=true`,
+  `SignalSource.dump_filename=./non-existing/data.dat`, and the `non-existing`
+  folder does not exist, it will be created if the running user has writing
+  permissions. This also works for absolute paths.
 
 See the definitions of concepts and metrics at
 https://gnss-sdr.org/design-forces/
diff --git a/src/algorithms/signal_source/adapters/uhd_signal_source.cc b/src/algorithms/signal_source/adapters/uhd_signal_source.cc
index 16bf5cb83..cbb151480 100644
--- a/src/algorithms/signal_source/adapters/uhd_signal_source.cc
+++ b/src/algorithms/signal_source/adapters/uhd_signal_source.cc
@@ -17,6 +17,8 @@
 #include "uhd_signal_source.h"
 #include "GPS_L1_CA.h"
 #include "configuration_interface.h"
+#include "gnss_sdr_create_directory.h"
+#include "gnss_sdr_filesystem.h"
 #include "gnss_sdr_string_literals.h"
 #include "gnss_sdr_valve.h"
 #include <glog/logging.h>
@@ -66,8 +68,21 @@ UhdSignalSource::UhdSignalSource(const ConfigurationInterface* configuration,
         {
             // Single RF channel UHD operation (backward compatible config file format)
             samples_.push_back(configuration->property(role + ".samples", 0));
-            dump_.push_back(configuration->property(role + ".dump", false));
-            dump_filename_.push_back(configuration->property(role + ".dump_filename", default_dump_file));
+            bool dump_source = configuration->property(role + ".dump", false);
+            dump_.push_back(dump_source);
+            std::string dump_source_filename = configuration->property(role + ".dump_filename", default_dump_file);
+            dump_filename_.push_back(dump_source_filename);
+            if (dump_source)
+                {
+                    std::string::size_type pos = dump_source_filename.find_last_of(fs::path::preferred_separator);
+                    if (pos != std::string::npos)
+                        {
+                            if (!gnss_sdr_create_directory(dump_source_filename.substr(0, pos)))
+                                {
+                                    std::cerr << "GNSS-SDR cannot create the " << dump_source_filename.substr(0, pos) << " folder. Wrong permissions?\n";
+                                }
+                        }
+                }
 
             freq_.push_back(configuration->property(role + ".freq", GPS_L1_FREQ_HZ));
             gain_.push_back(configuration->property(role + ".gain", 50.0));
@@ -81,8 +96,21 @@ UhdSignalSource::UhdSignalSource(const ConfigurationInterface* configuration,
                 {
                     // Single RF channel UHD operation (backward compatible config file format)
                     samples_.push_back(configuration->property(role + ".samples" + std::to_string(i), 0));
-                    dump_.push_back(configuration->property(role + ".dump" + std::to_string(i), false));
-                    dump_filename_.push_back(configuration->property(role + ".dump_filename" + std::to_string(i), default_dump_file));
+                    bool dump_source = configuration->property(role + ".dump" + std::to_string(i), false);
+                    dump_.push_back(dump_source);
+                    std::string dump_source_filename = configuration->property(role + ".dump_filename" + std::to_string(i), std::to_string(i) + "_"s + default_dump_file);
+                    dump_filename_.push_back(dump_source_filename);
+                    if (dump_source)
+                        {
+                            std::string::size_type pos = dump_source_filename.find_last_of(fs::path::preferred_separator);
+                            if (pos != std::string::npos)
+                                {
+                                    if (!gnss_sdr_create_directory(dump_source_filename.substr(0, pos)))
+                                        {
+                                            std::cerr << "GNSS-SDR cannot create the " << dump_source_filename.substr(0, pos) << " folder. Wrong permissions?\n";
+                                        }
+                                }
+                        }
 
                     freq_.push_back(configuration->property(role + ".freq" + std::to_string(i), GPS_L1_FREQ_HZ));
                     gain_.push_back(configuration->property(role + ".gain" + std::to_string(i), 50.0));