clang-tidy: apply modernize-pass-by-value fix. See http://clang.llvm.org/extra/clang-tidy/checks/modernize-pass-by-value.html#modernize-pass-by-value

src/algorithms/conditioner/adapters/array_signal_conditioner.cc

@@ -32,6 +32,8 @@
 #include "array_signal_conditioner.h"
 #include <glog/logging.h>
 
+#include <utility>
+
 
 using google::LogMessage;
 
@@ -41,11 +43,11 @@ ArraySignalConditioner::ArraySignalConditioner(ConfigurationInterface *configura
     std::shared_ptr<GNSSBlockInterface> in_filt,
     std::shared_ptr<GNSSBlockInterface> res,
     std::string role,
-    std::string implementation) : data_type_adapt_(data_type_adapt),
+    std::string implementation) : data_type_adapt_(std::move(data_type_adapt)),
-                                  in_filt_(in_filt),
+                                  in_filt_(std::move(in_filt)),
-                                  res_(res),
+                                  res_(std::move(res)),
-                                  role_(role),
+                                  role_(std::move(role)),
-                                  implementation_(implementation)
+                                  implementation_(std::move(implementation))
 {
     connected_ = false;
     if (configuration)

src/algorithms/conditioner/adapters/signal_conditioner.cc

@@ -32,6 +32,8 @@
 #include "signal_conditioner.h"
 #include <glog/logging.h>
 
+#include <utility>
+
 
 using google::LogMessage;
 
@@ -41,11 +43,11 @@ SignalConditioner::SignalConditioner(ConfigurationInterface *configuration,
     std::shared_ptr<GNSSBlockInterface> in_filt,
     std::shared_ptr<GNSSBlockInterface> res,
     std::string role,
-    std::string implementation) : data_type_adapt_(data_type_adapt),
+    std::string implementation) : data_type_adapt_(std::move(data_type_adapt)),
-                                  in_filt_(in_filt),
+                                  in_filt_(std::move(in_filt)),
-                                  res_(res),
+                                  res_(std::move(res)),
-                                  role_(role),
+                                  role_(std::move(role)),
-                                  implementation_(implementation)
+                                  implementation_(std::move(implementation))
 {
     connected_ = false;
     if (configuration)

src/algorithms/data_type_adapter/adapters/byte_to_short.cc

@@ -32,11 +32,13 @@
 #include "configuration_interface.h"
 #include <glog/logging.h>
 
+#include <utility>
+
 
 using google::LogMessage;
 
 ByteToShort::ByteToShort(ConfigurationInterface* configuration, std::string role,
-    unsigned int in_streams, unsigned int out_streams) : config_(configuration), role_(role), in_streams_(in_streams), out_streams_(out_streams)
+    unsigned int in_streams, unsigned int out_streams) : config_(configuration), role_(std::move(role)), in_streams_(in_streams), out_streams_(out_streams)
 {
     std::string default_input_item_type = "byte";
     std::string default_output_item_type = "short";

src/algorithms/input_filter/adapters/fir_filter.cc

@@ -32,6 +32,7 @@
 #include "fir_filter.h"
 #include "configuration_interface.h"
 #include <boost/lexical_cast.hpp>
+#include <utility>
 #include <gnuradio/filter/pm_remez.h>
 #include <glog/logging.h>
 #include <volk/volk.h>
@@ -40,7 +41,7 @@
 using google::LogMessage;
 
 FirFilter::FirFilter(ConfigurationInterface* configuration, std::string role,
-    unsigned int in_streams, unsigned int out_streams) : config_(configuration), role_(role), in_streams_(in_streams), out_streams_(out_streams)
+    unsigned int in_streams, unsigned int out_streams) : config_(configuration), role_(std::move(role)), in_streams_(in_streams), out_streams_(out_streams)
 {
     size_t item_size;
     (*this).init();

src/algorithms/input_filter/adapters/freq_xlating_fir_filter.cc

@@ -32,6 +32,7 @@
 #include "freq_xlating_fir_filter.h"
 #include "configuration_interface.h"
 #include <boost/lexical_cast.hpp>
+#include <utility>
 #include <gnuradio/blocks/file_sink.h>
 #include <gnuradio/filter/pm_remez.h>
 #include <gnuradio/filter/firdes.h>
@@ -41,7 +42,7 @@
 using google::LogMessage;
 
 FreqXlatingFirFilter::FreqXlatingFirFilter(ConfigurationInterface* configuration, std::string role,
-    unsigned int in_streams, unsigned int out_streams) : config_(configuration), role_(role), in_streams_(in_streams), out_streams_(out_streams)
+    unsigned int in_streams, unsigned int out_streams) : config_(configuration), role_(std::move(role)), in_streams_(in_streams), out_streams_(out_streams)
 {
     std::string default_input_item_type = "gr_complex";
     std::string default_output_item_type = "gr_complex";

src/algorithms/input_filter/adapters/pulse_blanking_filter.cc

@@ -33,13 +33,14 @@
 #include <boost/lexical_cast.hpp>
 #include <glog/logging.h>
 #include <gnuradio/filter/firdes.h>
+#include <utility>
 #include <vector>
 #include <cmath>
 
 using google::LogMessage;
 
 PulseBlankingFilter::PulseBlankingFilter(ConfigurationInterface* configuration, std::string role,
-    unsigned int in_streams, unsigned int out_streams) : config_(configuration), role_(role), in_streams_(in_streams), out_streams_(out_streams)
+    unsigned int in_streams, unsigned int out_streams) : config_(configuration), role_(std::move(role)), in_streams_(in_streams), out_streams_(out_streams)
 {
     size_t item_size;
     xlat_ = false;

src/algorithms/libs/gnss_sdr_valve.cc

@@ -37,6 +37,7 @@
 #include <gnuradio/io_signature.h>
 #include <algorithm>  // for min
 #include <cstring>    // for memcpy
+#include <utility>
 
 gnss_sdr_valve::gnss_sdr_valve(size_t sizeof_stream_item,
     unsigned long long nitems,
@@ -46,7 +47,7 @@ gnss_sdr_valve::gnss_sdr_valve(size_t sizeof_stream_item,
                                gr::io_signature::make(1, 1, sizeof_stream_item)),
                            d_nitems(nitems),
                            d_ncopied_items(0),
-                           d_queue(queue),
+                           d_queue(std::move(queue)),
                            d_stop_flowgraph(stop_flowgraph)
 {
     d_open_valve = false;

src/algorithms/signal_generator/adapters/signal_generator.cc

@@ -38,12 +38,14 @@
 #include "GLONASS_L1_L2_CA.h"
 #include <glog/logging.h>
 
+#include <utility>
+
 
 using google::LogMessage;
 
 SignalGenerator::SignalGenerator(ConfigurationInterface* configuration,
     std::string role, unsigned int in_stream,
-    unsigned int out_stream, boost::shared_ptr<gr::msg_queue> queue) : role_(role), in_stream_(in_stream), out_stream_(out_stream), queue_(queue)
+    unsigned int out_stream, boost::shared_ptr<gr::msg_queue> queue) : role_(role), in_stream_(in_stream), out_stream_(out_stream), queue_(std::move(queue))
 {
     std::string default_item_type = "gr_complex";
     std::string default_dump_file = "./data/gen_source.dat";

src/algorithms/signal_generator/gnuradio_blocks/signal_generator_c.cc

@@ -40,6 +40,7 @@
 #include <gnuradio/io_signature.h>
 #include <volk_gnsssdr/volk_gnsssdr.h>
 #include <fstream>
+#include <utility>
 
 
 /*
@@ -63,22 +64,22 @@ signal_make_generator_c(std::vector<std::string> signal1, std::vector<std::strin
 signal_generator_c::signal_generator_c(std::vector<std::string> signal1,
     std::vector<std::string> system,
     const std::vector<unsigned int> &PRN,
-    const std::vector<float> &CN0_dB,
+    std::vector<float> CN0_dB,
-    const std::vector<float> &doppler_Hz,
+    std::vector<float> doppler_Hz,
-    const std::vector<unsigned int> &delay_chips,
+    std::vector<unsigned int> delay_chips,
-    const std::vector<unsigned int> &delay_sec,
+    std::vector<unsigned int> delay_sec,
     bool data_flag,
     bool noise_flag,
     unsigned int fs_in,
     unsigned int vector_length,
     float BW_BB) : gr::block("signal_gen_cc", gr::io_signature::make(0, 0, sizeof(gr_complex)), gr::io_signature::make(1, 1, sizeof(gr_complex) * vector_length)),
-                   signal_(signal1),
+                   signal_(std::move(signal1)),
-                   system_(system),
+                   system_(std::move(system)),
                    PRN_(PRN),
-                   CN0_dB_(CN0_dB),
+                   CN0_dB_(std::move(CN0_dB)),
-                   doppler_Hz_(doppler_Hz),
+                   doppler_Hz_(std::move(doppler_Hz)),
-                   delay_chips_(delay_chips),
+                   delay_chips_(std::move(delay_chips)),
-                   delay_sec_(delay_sec),
+                   delay_sec_(std::move(delay_sec)),
                    data_flag_(data_flag),
                    noise_flag_(noise_flag),
                    fs_in_(fs_in),

src/algorithms/signal_generator/gnuradio_blocks/signal_generator_c.h

@@ -87,8 +87,8 @@ private:
         unsigned int fs_in, unsigned int vector_length, float BW_BB);
 
     signal_generator_c(std::vector<std::string> signal1, std::vector<std::string> system, const std::vector<unsigned int> &PRN,
-        const std::vector<float> &CN0_dB, const std::vector<float> &doppler_Hz,
+        std::vector<float> CN0_dB, std::vector<float> doppler_Hz,
-        const std::vector<unsigned int> &delay_chips, const std::vector<unsigned int> &delay_sec, bool data_flag, bool noise_flag,
+        std::vector<unsigned int> delay_chips, std::vector<unsigned int> delay_sec, bool data_flag, bool noise_flag,
         unsigned int fs_in, unsigned int vector_length, float BW_BB);
 
     void init();

src/algorithms/signal_source/adapters/file_signal_source.cc

@@ -39,6 +39,7 @@
 #include <fstream>
 #include <iomanip>
 #include <exception>
+#include <utility>
 
 
 using google::LogMessage;
@@ -46,7 +47,7 @@ using google::LogMessage;
 
 FileSignalSource::FileSignalSource(ConfigurationInterface* configuration,
     std::string role, unsigned int in_streams, unsigned int out_streams,
-    boost::shared_ptr<gr::msg_queue> queue) : role_(role), in_streams_(in_streams), out_streams_(out_streams), queue_(queue)
+    boost::shared_ptr<gr::msg_queue> queue) : role_(role), in_streams_(in_streams), out_streams_(out_streams), queue_(std::move(queue))
 {
     std::string default_filename = "./example_capture.dat";
     std::string default_item_type = "short";

src/algorithms/signal_source/adapters/gen_signal_source.cc

@@ -37,6 +37,7 @@
 #include <gnuradio/message.h>
 #include <glog/logging.h>
 #include <sstream>
+#include <utility>
 
 using google::LogMessage;
 
@@ -44,8 +45,8 @@ using google::LogMessage;
 GenSignalSource::GenSignalSource(GNSSBlockInterface *signal_generator, GNSSBlockInterface *filter,
     std::string role, boost::shared_ptr<gr::msg_queue> queue) : signal_generator_(signal_generator),
                                                                 filter_(filter),
-                                                                role_(role),
+                                                                role_(std::move(role)),
-                                                                queue_(queue)
+                                                                queue_(std::move(queue))
 {
     connected_ = false;
 }

src/algorithms/signal_source/adapters/labsat_signal_source.cc

@@ -33,11 +33,13 @@
 #include "labsat23_source.h"
 #include <glog/logging.h>
 
+#include <utility>
+
 
 using google::LogMessage;
 
 LabsatSignalSource::LabsatSignalSource(ConfigurationInterface* configuration,
-    std::string role, unsigned int in_stream, unsigned int out_stream, gr::msg_queue::sptr queue) : role_(role), in_stream_(in_stream), out_stream_(out_stream), queue_(queue)
+    std::string role, unsigned int in_stream, unsigned int out_stream, gr::msg_queue::sptr queue) : role_(role), in_stream_(in_stream), out_stream_(out_stream), queue_(std::move(queue))
 {
     std::string default_item_type = "gr_complex";
     std::string default_dump_file = "./data/source.bin";

src/algorithms/signal_source/adapters/nsr_file_signal_source.cc

@@ -39,6 +39,7 @@
 #include <fstream>
 #include <iomanip>
 #include <iostream>
+#include <utility>
 
 
 using google::LogMessage;
@@ -46,7 +47,7 @@ using google::LogMessage;
 
 NsrFileSignalSource::NsrFileSignalSource(ConfigurationInterface* configuration,
     std::string role, unsigned int in_streams, unsigned int out_streams,
-    boost::shared_ptr<gr::msg_queue> queue) : role_(role), in_streams_(in_streams), out_streams_(out_streams), queue_(queue)
+    boost::shared_ptr<gr::msg_queue> queue) : role_(role), in_streams_(in_streams), out_streams_(out_streams), queue_(std::move(queue))
 {
     std::string default_filename = "../data/my_capture.dat";
     std::string default_item_type = "byte";

src/algorithms/signal_source/adapters/rtl_tcp_signal_source.cc

@@ -37,6 +37,7 @@
 #include <boost/format.hpp>
 #include <glog/logging.h>
 #include <iostream>
+#include <utility>
 
 
 using google::LogMessage;
@@ -44,7 +45,7 @@ using google::LogMessage;
 
 RtlTcpSignalSource::RtlTcpSignalSource(ConfigurationInterface* configuration,
     std::string role, unsigned int in_stream, unsigned int out_stream,
-    boost::shared_ptr<gr::msg_queue> queue) : role_(role), in_stream_(in_stream), out_stream_(out_stream), queue_(queue)
+    boost::shared_ptr<gr::msg_queue> queue) : role_(std::move(role)), in_stream_(in_stream), out_stream_(out_stream), queue_(queue)
 {
     // DUMP PARAMETERS
     std::string empty = "";

src/algorithms/signal_source/adapters/spir_file_signal_source.cc

@@ -38,6 +38,7 @@
 #include <fstream>
 #include <iomanip>
 #include <iostream>
+#include <utility>
 
 
 using google::LogMessage;
@@ -45,7 +46,7 @@ using google::LogMessage;
 
 SpirFileSignalSource::SpirFileSignalSource(ConfigurationInterface* configuration,
     std::string role, unsigned int in_streams, unsigned int out_streams,
-    boost::shared_ptr<gr::msg_queue> queue) : role_(role), in_streams_(in_streams), out_streams_(out_streams), queue_(queue)
+    boost::shared_ptr<gr::msg_queue> queue) : role_(role), in_streams_(in_streams), out_streams_(out_streams), queue_(std::move(queue))
 {
     std::string default_filename = "../data/my_capture.dat";
     std::string default_item_type = "int";

src/algorithms/signal_source/adapters/spir_gss6450_file_signal_source.cc

@@ -36,13 +36,14 @@
 #include <fstream>
 #include <iomanip>
 #include <iostream>
+#include <utility>
 
 
 using google::LogMessage;
 
 
 SpirGSS6450FileSignalSource::SpirGSS6450FileSignalSource(ConfigurationInterface* configuration,
-    std::string role, uint32_t in_streams, uint32_t out_streams, gr::msg_queue::sptr queue) : role_(role), in_streams_(in_streams), out_streams_(out_streams), queue_(queue)
+    std::string role, uint32_t in_streams, uint32_t out_streams, gr::msg_queue::sptr queue) : role_(role), in_streams_(in_streams), out_streams_(out_streams), queue_(std::move(queue))
 {
     std::string default_filename = "../data/my_capture.dat";
     std::string default_dump_filename = "../data/my_capture_dump.dat";

src/algorithms/signal_source/adapters/two_bit_cpx_file_signal_source.cc

@@ -38,6 +38,7 @@
 #include <fstream>
 #include <iomanip>
 #include <iostream>
+#include <utility>
 
 
 using google::LogMessage;
@@ -50,7 +51,7 @@ TwoBitCpxFileSignalSource::TwoBitCpxFileSignalSource(ConfigurationInterface* con
     boost::shared_ptr<gr::msg_queue> queue) : role_(role),
                                               in_streams_(in_streams),
                                               out_streams_(out_streams),
-                                              queue_(queue)
+                                              queue_(std::move(queue))
 {
     std::string default_filename = "../data/my_capture.dat";
     std::string default_item_type = "byte";

src/algorithms/signal_source/adapters/two_bit_packed_file_signal_source.cc

@@ -40,6 +40,7 @@
 #include <fstream>
 #include <iomanip>
 #include <iostream>
+#include <utility>
 
 
 using google::LogMessage;
@@ -52,7 +53,7 @@ TwoBitPackedFileSignalSource::TwoBitPackedFileSignalSource(ConfigurationInterfac
     boost::shared_ptr<gr::msg_queue> queue) : role_(role),
                                               in_streams_(in_streams),
                                               out_streams_(out_streams),
-                                              queue_(queue)
+                                              queue_(std::move(queue))
 {
     std::string default_filename = "../data/my_capture.dat";
     std::string default_item_type = "byte";

src/algorithms/signal_source/adapters/uhd_signal_source.cc

@@ -37,13 +37,14 @@
 #include <uhd/exception.hpp>
 #include <volk/volk.h>
 #include <iostream>
+#include <utility>
 
 
 using google::LogMessage;
 
 UhdSignalSource::UhdSignalSource(ConfigurationInterface* configuration,
     std::string role, unsigned int in_stream, unsigned int out_stream,
-    boost::shared_ptr<gr::msg_queue> queue) : role_(role), in_stream_(in_stream), out_stream_(out_stream), queue_(queue)
+    boost::shared_ptr<gr::msg_queue> queue) : role_(role), in_stream_(in_stream), out_stream_(out_stream), queue_(std::move(queue))
 {
     // DUMP PARAMETERS
     std::string empty = "";

src/algorithms/tracking/adapters/galileo_e1_tcp_connector_tracking.cc

@@ -37,6 +37,8 @@
 
 #include "galileo_e1_tcp_connector_tracking.h"
 #include <glog/logging.h>
+
+#include <utility>
 #include "Galileo_E1.h"
 #include "configuration_interface.h"
 #include "gnss_sdr_flags.h"
@@ -47,7 +49,7 @@ using google::LogMessage;
 
 GalileoE1TcpConnectorTracking::GalileoE1TcpConnectorTracking(
     ConfigurationInterface* configuration, std::string role,
-    unsigned int in_streams, unsigned int out_streams) : role_(role), in_streams_(in_streams), out_streams_(out_streams)
+    unsigned int in_streams, unsigned int out_streams) : role_(std::move(role)), in_streams_(in_streams), out_streams_(out_streams)
 {
     DLOG(INFO) << "role " << role;
     //################# CONFIGURATION PARAMETERS ########################

src/algorithms/tracking/adapters/gps_l1_ca_tcp_connector_tracking.cc

@@ -37,6 +37,8 @@
 
 #include "gps_l1_ca_tcp_connector_tracking.h"
 #include <glog/logging.h>
+
+#include <utility>
 #include "GPS_L1_CA.h"
 #include "configuration_interface.h"
 
@@ -46,7 +48,7 @@ using google::LogMessage;
 
 GpsL1CaTcpConnectorTracking::GpsL1CaTcpConnectorTracking(
     ConfigurationInterface* configuration, std::string role,
-    unsigned int in_streams, unsigned int out_streams) : role_(role), in_streams_(in_streams), out_streams_(out_streams)
+    unsigned int in_streams, unsigned int out_streams) : role_(std::move(role)), in_streams_(in_streams), out_streams_(out_streams)
 {
     DLOG(INFO) << "role " << role;
     //################# CONFIGURATION PARAMETERS ########################