From 1e356ad8dc74eb6cc17331f34667190cd3d23fa5 Mon Sep 17 00:00:00 2001 From: Carles Fernandez Date: Thu, 21 Feb 2019 13:36:21 +0100 Subject: [PATCH] clang-tidy: add and apply misc-unused-using-decls check --- .clang-tidy | 1 + src/algorithms/input_filter/adapters/CMakeLists.txt | 2 ++ src/algorithms/input_filter/gnuradio_blocks/CMakeLists.txt | 2 -- src/algorithms/input_filter/gnuradio_blocks/notch_cc.cc | 2 -- .../input_filter/gnuradio_blocks/notch_lite_cc.cc | 2 -- .../input_filter/gnuradio_blocks/pulse_blanking_cc.cc | 2 -- src/algorithms/resampler/gnuradio_blocks/CMakeLists.txt | 3 --- .../gnuradio_blocks/direct_resampler_conditioner_cb.cc | 3 --- .../gnuradio_blocks/direct_resampler_conditioner_cc.cc | 2 -- .../gnuradio_blocks/direct_resampler_conditioner_cs.cc | 6 +++--- 10 files changed, 6 insertions(+), 19 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 0cabf7daf..dbcac08e4 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -18,6 +18,7 @@ Checks: '-*, misc-static-assert, misc-throw-by-value-catch-by-reference, misc-uniqueptr-reset-release, + misc-unused-using-decls, modernize-loop-convert, modernize-pass-by-value, modernize-raw-string-literal, diff --git a/src/algorithms/input_filter/adapters/CMakeLists.txt b/src/algorithms/input_filter/adapters/CMakeLists.txt index f1709bf7f..8459dea90 100644 --- a/src/algorithms/input_filter/adapters/CMakeLists.txt +++ b/src/algorithms/input_filter/adapters/CMakeLists.txt @@ -51,6 +51,8 @@ target_link_libraries(input_filter_adapters input_filter_gr_blocks algorithms_libs PRIVATE + Gflags::gflags + Glog::glog Volk::volk ) diff --git a/src/algorithms/input_filter/gnuradio_blocks/CMakeLists.txt b/src/algorithms/input_filter/gnuradio_blocks/CMakeLists.txt index 72cb7962c..e45410533 100644 --- a/src/algorithms/input_filter/gnuradio_blocks/CMakeLists.txt +++ b/src/algorithms/input_filter/gnuradio_blocks/CMakeLists.txt @@ -46,8 +46,6 @@ target_link_libraries(input_filter_gr_blocks Gnuradio::filter Volkgnsssdr::volkgnsssdr PRIVATE - Gflags::gflags - Glog::glog Log4cpp::log4cpp ) diff --git a/src/algorithms/input_filter/gnuradio_blocks/notch_cc.cc b/src/algorithms/input_filter/gnuradio_blocks/notch_cc.cc index 3a3c9f8a3..dee531eaf 100644 --- a/src/algorithms/input_filter/gnuradio_blocks/notch_cc.cc +++ b/src/algorithms/input_filter/gnuradio_blocks/notch_cc.cc @@ -30,13 +30,11 @@ #include "notch_cc.h" #include -#include #include #include #include #include -using google::LogMessage; notch_sptr make_notch_filter(float pfa, float p_c_factor, int32_t length_, int32_t n_segments_est, int32_t n_segments_reset) diff --git a/src/algorithms/input_filter/gnuradio_blocks/notch_lite_cc.cc b/src/algorithms/input_filter/gnuradio_blocks/notch_lite_cc.cc index 03a3639db..d73b5cbb8 100644 --- a/src/algorithms/input_filter/gnuradio_blocks/notch_lite_cc.cc +++ b/src/algorithms/input_filter/gnuradio_blocks/notch_lite_cc.cc @@ -30,13 +30,11 @@ #include "notch_lite_cc.h" #include -#include #include #include #include #include -using google::LogMessage; notch_lite_sptr make_notch_filter_lite(float p_c_factor, float pfa, int32_t length_, int32_t n_segments_est, int32_t n_segments_reset, int32_t n_segments_coeff) { diff --git a/src/algorithms/input_filter/gnuradio_blocks/pulse_blanking_cc.cc b/src/algorithms/input_filter/gnuradio_blocks/pulse_blanking_cc.cc index 02c98fb5c..593339bc6 100644 --- a/src/algorithms/input_filter/gnuradio_blocks/pulse_blanking_cc.cc +++ b/src/algorithms/input_filter/gnuradio_blocks/pulse_blanking_cc.cc @@ -30,12 +30,10 @@ #include "pulse_blanking_cc.h" #include -#include #include #include #include -using google::LogMessage; pulse_blanking_cc_sptr make_pulse_blanking_cc(float pfa, int32_t length_, int32_t n_segments_est, int32_t n_segments_reset) diff --git a/src/algorithms/resampler/gnuradio_blocks/CMakeLists.txt b/src/algorithms/resampler/gnuradio_blocks/CMakeLists.txt index e5193d7eb..33dd7b6ab 100644 --- a/src/algorithms/resampler/gnuradio_blocks/CMakeLists.txt +++ b/src/algorithms/resampler/gnuradio_blocks/CMakeLists.txt @@ -43,9 +43,6 @@ target_link_libraries(resampler_gr_blocks PUBLIC Gnuradio::runtime Volk::volk - PRIVATE - Gflags::gflags - Glog::glog ) if(ENABLE_CLANG_TIDY) diff --git a/src/algorithms/resampler/gnuradio_blocks/direct_resampler_conditioner_cb.cc b/src/algorithms/resampler/gnuradio_blocks/direct_resampler_conditioner_cb.cc index 39bf2883a..99948c3bb 100644 --- a/src/algorithms/resampler/gnuradio_blocks/direct_resampler_conditioner_cb.cc +++ b/src/algorithms/resampler/gnuradio_blocks/direct_resampler_conditioner_cb.cc @@ -33,12 +33,9 @@ #include "direct_resampler_conditioner_cb.h" -#include #include -using google::LogMessage; - direct_resampler_conditioner_cb_sptr direct_resampler_make_conditioner_cb( double sample_freq_in, double sample_freq_out) { diff --git a/src/algorithms/resampler/gnuradio_blocks/direct_resampler_conditioner_cc.cc b/src/algorithms/resampler/gnuradio_blocks/direct_resampler_conditioner_cc.cc index a288cd4da..09d6c2e6c 100644 --- a/src/algorithms/resampler/gnuradio_blocks/direct_resampler_conditioner_cc.cc +++ b/src/algorithms/resampler/gnuradio_blocks/direct_resampler_conditioner_cc.cc @@ -37,8 +37,6 @@ #include -using google::LogMessage; - direct_resampler_conditioner_cc_sptr direct_resampler_make_conditioner_cc( double sample_freq_in, double sample_freq_out) { diff --git a/src/algorithms/resampler/gnuradio_blocks/direct_resampler_conditioner_cs.cc b/src/algorithms/resampler/gnuradio_blocks/direct_resampler_conditioner_cs.cc index 3506879b6..6a4b5a8d3 100644 --- a/src/algorithms/resampler/gnuradio_blocks/direct_resampler_conditioner_cs.cc +++ b/src/algorithms/resampler/gnuradio_blocks/direct_resampler_conditioner_cs.cc @@ -33,10 +33,8 @@ #include "direct_resampler_conditioner_cs.h" -#include #include -using google::LogMessage; direct_resampler_conditioner_cs_sptr direct_resampler_make_conditioner_cs( double sample_freq_in, double sample_freq_out) @@ -49,7 +47,9 @@ direct_resampler_conditioner_cs_sptr direct_resampler_make_conditioner_cs( direct_resampler_conditioner_cs::direct_resampler_conditioner_cs( double sample_freq_in, - double sample_freq_out) : gr::block("direct_resampler_make_conditioner_cs", gr::io_signature::make(1, 1, sizeof(lv_16sc_t)), gr::io_signature::make(1, 1, sizeof(lv_16sc_t))), + double sample_freq_out) : gr::block("direct_resampler_make_conditioner_cs", + gr::io_signature::make(1, 1, sizeof(lv_16sc_t)), + gr::io_signature::make(1, 1, sizeof(lv_16sc_t))), d_sample_freq_in(sample_freq_in), d_sample_freq_out(sample_freq_out), d_phase(0),