1
0
mirror of https://github.com/Jermolene/TiddlyWiki5 synced 2024-11-23 10:07:19 +00:00
TiddlyWiki5/core/modules
Jeremy Ruston b95723a022
Fix syncer to handler errors properly (#4373)
* First commit

* Add throttling of saves

Now we refuse to save a tiddler more often than once per second.

* Wait for a timeout before trying again after an error

* Modest optimisations of isDirty() method

* Synchronise system tiddlers and deletions from the server

Fixes two long-standing issues:

* Changes to system tiddlers are not synchronised from the server to the browser
* Deletions of tiddlers on the server are not propagated to browser clients

* Make sure we update the dirty status even if there isn't a task to perform

* Replace save-wiki button with popup sync menu

* Remove the "Server" control panel tab

We don't need it with the enhanced sync dropdown

* Add indentation to the save-wiki button

* Fix spacing in dropdown menu items

* Switch between cloud icons according to dirty status

* Add a menu item to copy syncer logs to the clipboard

* Improve animated icon

* Remove indentation from save-wiki button

@pmario the annoying thing is that using `\trim whitespace` trims significant whitespace too, so it means we have to use <$text text=" "/> when we need a space that won't be trimmed. For the moment, I've removed the indentation but will keep thinking about it.

* Further icon, UI and copy text tweaks

Move the icons and styles from the core into the TiddlyWeb plugin

* Clean up PR diff

* Tweak animation durations

* Break the actions from the syncer dropdown into separate tiddlers

@pmario I think this makes things a bit easier to follow

* Refactor syncadaptor creation and logging

The goal is for the syncadaptor to be able to log to the same logger as the syncer, so that the "copy syncer logs to clipboard" data is more useful.

* Don't transition the dirty indicator container colour, just the SVG's colour

* Only trigger a sync for changes to tiddlers we're interested in

Otherwise it is triggered by the creation of the alert tiddlers used to display errors.

* Restore deleting local tiddlers removed from the server

(I had commented it out for some testing and accidentally commited it).

* Guard against missing adaptor info

* We still need to trigger a timeout when there was no task to process

* Avoid repeatedly polling for changes

Instead we only trigger a timeout call at if there is a pending task (ie a tiddler that has changed but isn't yet old enough to save).

* Lazy loading: include skinny versions of lazily loaded tiddlers in the index.html

* Introduce _is_skinny field for indicating that a tiddler is subject to lazy loading

* Remove savetrail plugin from prerelease

It doesn't yet work with the new syncer

* Make the savetrail plugin work again

* Clear outstanding alerts when synchronisation is restored

* Logger: only remove alerts from the same component

Missed off 9f5c0de07

* Make the saving throttle interval configurable (#4385)

After switching Bob to use the core syncer the throttle interval makes saving feel very sluggish compared to the message queue setup that I had before.
The editing lock that I use to prevent conflicts with multiple users doesn't go away until the save is completed, and with the 1 second delay it means that if you edit a tiddler and save it than you have to wait one second before you can edit it again.

* Tweaks to appearance of alerts

* Exclude temp tiddlers from offline snapshots

Otherwise alerts will persist

* Tweak appearance of status line in dropdown

* Update release note

* Web server: Don't include full path in error messages

Fixes #3724

* In change event handler check for deletions

* Disable the official plugin library when the tiddlyweb plugin is loaded

* Hide error details from browser for /files/ route

See https://github.com/Jermolene/TiddlyWiki5/issues/3724#issuecomment-565702492 -- thanks @pmario

* Revert all the changes to the relationship between the syncer and the syncadaptor

Previously we had some major rearrangements to make it possible for the syncadaptor to route it's logging to the logger used by the syncer. The motivation is so that the "copy logs to clipboard" button is more useful.

On reflection, changing the interface this drastically is undesirable from a backwards compatibility perspective, so I'm going to investigate other ways to achieve the logger sharing

* Make the tiddlyweb adaptor use the syncer's logger

So that both are availavble when copying the syncer logs to the clipboard

* Update release note

* Support setting port=0 to get an OS assigned port

Quite useful

* Update code comment

* UI: Use "Get latest changes from server" instead of "Refresh"

* Add getUpdatedTiddlers() method to syncadaptor API

See https://github.com/Jermolene/TiddlyWiki5/pull/4373#issuecomment-573579495

* Refactor revision handling within the syncer

Thanks @pmario

* Fix typo in tiddlywebadaptor

* Improve presentation of errors

See https://github.com/Jermolene/TiddlyWiki5/pull/4373#issuecomment-573695267

* Add docs for getTiddlerRevision()

* Remove unused error animation

* Update comment for GET /recipes/default/tiddlers/tiddlers.json

* Optimise SVG cloud image

* Add optional list of allowed filters for get all tiddlers route

An attempt to address @Arlen22's concern here:

https://github.com/Jermolene/TiddlyWiki5/pull/4373#pullrequestreview-342146190

* Fix network error alert text translatability

* Fix error code and logging for GET /recipes/default/tiddlers/tiddlers.json

Thanks @Arlen22

* Flip GET /recipes/default/tiddlers/tiddlers.json allowed filter handling to be secure by default

* Validate updates received from getUpdatedTiddlers()

* Add syncer method to force loading of a tiddler from the server

* Remove the release note update to remove the merge conflict

* Fix crash when there's no config section in the tiddlywiki.info file

* Use config tiddler title to check filter query (merge into fix-syncer) (#4478)

* Use config tiddler title to check filter query

* Create config-tiddlers-filter.tid

* Add config switch to enable all filters on GET /recipes/default/tiddlers/tiddlers.json

And update docs

* Fix bug when deleting a tiddler with a shadow

Reported by @kookma at https://github.com/Jermolene/TiddlyWiki5/pull/4373#issuecomment-604027528

Co-authored-by: jed <inmysocks@fastmail.com>
Co-authored-by: Arlen22 <arlenbee@gmail.com>
2020-03-30 15:24:05 +01:00
..
commands Dynamic plugins: Change "contains JavaScript" to "requires reload" 2019-09-27 16:47:55 +01:00
editor Revert "Fix test for needing to update text editor DOM" 2020-03-15 14:23:10 +00:00
filters Adding [is[binary]] filter -- Missed off 1150c87ed 2019-09-16 16:16:03 +01:00
indexers Add backlinks indexer (#4421) 2020-03-26 13:15:02 +00:00
info Add $:/info/browser/language to the info mechanism 2019-03-07 18:42:49 +00:00
macros Fix the datauri macro to work with _canonical_uri tiddlers 2020-03-30 10:55:37 +01:00
parsers Add download button/link to binary tiddler warning banners in view and edit mode (#4423) 2020-01-31 09:13:28 +00:00
savers Use CamelCase for Gitea (#4496) 2020-03-13 17:36:05 +00:00
server Fix syncer to handler errors properly (#4373) 2020-03-30 15:24:05 +01:00
startup Fix syncer to handler errors properly (#4373) 2020-03-30 15:24:05 +01:00
storyviews Pop storyview: fix bug where targetElement is null (#4143) 2019-08-02 08:51:16 +01:00
upgraders Dynamic plugins: Change "contains JavaScript" to "requires reload" 2019-09-27 16:47:55 +01:00
utils Fix syncer to handler errors properly (#4373) 2020-03-30 15:24:05 +01:00
widgets Improve ability to disable drag and drop 2020-03-20 10:46:17 +00:00
commander.js Module-ize server routes, add static file support and other enhancements(#2679) 2018-07-18 16:54:43 +01:00
config.js Move the wikilink regexps into global config 2014-11-26 11:12:25 +00:00
deserializers.js Add support for JSON files containing a single tiddler 2017-03-17 14:19:43 +00:00
filters.js Add support for = prefix for filter runs that doesn't remove duplicates 2019-06-10 17:54:20 +01:00
keyboard.js Add support for global keyboard shortcuts (#3493) 2018-11-06 13:34:51 +00:00
language.js Make lazy loading message be translateable 2015-09-08 10:41:27 +01:00
pluginswitcher.js Dynamic plugins: Fix registration of themes and languages 2019-09-16 13:17:09 +01:00
saver-handler.js SaverHandler: Don't generate file if autosave disabled 2019-03-05 15:43:14 +00:00
story.js Fix issues with creation and modification dates 2015-09-11 13:34:01 +01:00
syncer.js Fix syncer to handler errors properly (#4373) 2020-03-30 15:24:05 +01:00
tiddler.js Ensure tiddler.getFieldStringBlock uses a deterministic ordering 2019-04-14 14:23:49 +01:00
wiki-bulkops.js Fix unnecessary "list" field creation when renaming tiddlers 2019-07-30 17:10:53 +01:00
wiki.js Fix syncer to handler errors properly (#4373) 2020-03-30 15:24:05 +01:00