1
0
mirror of https://github.com/Jermolene/TiddlyWiki5 synced 2024-11-15 22:34:51 +00:00
TiddlyWiki5/core/ui
FlashSystems 80442b7f7f
Fix for bug #7054 (#7092)
* Fix Bug #7054: Reuse of $:/core/ui/EditTemplate/fields broken

This fixes Bug #7054 by creating a new variable
`safeNewFieldValueTiddlerPrefix` that is always set to a valid,
temporary prefix. This variable is used within `$action-deletetiddler`.
If the passed `newFieldValueTiddlerPrefix` variable is empty a new
prefix will be generated by the same logic that creates the original
`newFieldValueTiddlerPrefix` variable.

To be even more defensive, the prefix-filter was prepended with another
prefix filter that limits matches to `$:/temp/NewFieldValue`. This
prevents a bogus but non empty value in `newFieldValueTiddlerPrefix`
to delete arbitrary tiddlers.

* Add a default for `newFieldValueTiddlerPrefix`

This fixes a problem that was identified while fixing bug #7054. If the
tiddler `$:/core/ui/EditTemplate/fields` is transcluded directly and
`newFieldValueTiddlerPrefix` is not set, it will be generated. This
makes sure that this value is defined. It can not be redefined
unconditionally because if this tiddler is transcluded from
`EditTemplate.tid` these two tiddlers must agree on the same prefix
because the clean-up is duplicated between `EditTemplate.tid` and
`fields.tid`.

This would make `safeNewFieldValueTiddlerPrefix` obsolete, but I leave
it in there to make the macros safe and prevent any problems if the
`newFieldValueTiddlerPrefix` is unset by a later change.
2022-12-05 22:05:20 +00:00
..
AboveStory Fix tw2-plugin-check warning so that more than one plugin is displayed 2016-09-30 18:27:45 +01:00
Actions New image shortcut should not add journal tags 2022-10-02 18:55:26 +01:00
AdvancedSearch Exclude drafts from the advanced search filter dropdown 2022-12-03 17:53:42 +00:00
Components Trim Saga: Advanced Search and actions (#6604) 2022-04-16 17:40:27 +01:00
ControlPanel Revert "Revert "add table utility classes and some docs how to use them. fix problem with control-panel basics tab shown in story river (#7039)"" 2022-11-23 21:52:36 +00:00
EditorToolbar Trim Saga: Control panel and Editor Toolbar (#6600) 2022-04-06 08:27:05 +01:00
EditTemplate Fix for bug #7054 (#7092) 2022-12-05 22:05:20 +00:00
EditToolbar Add whitespace trims to EditToolbar Buttons (#5076) 2020-11-19 16:37:36 +00:00
Filters Add advanced search canned filter for "tiddlers modified this session" 2019-02-08 11:07:06 +00:00
ImportPreviews Trim Saga: All snippets, language tiddlers, and typed (#6275) 2022-04-01 12:10:29 +01:00
KeyboardShortcuts Fix advanced search keyboard shortcut navigation 2022-11-26 11:22:24 +00:00
Manager Trim Saga: I think this is the last batch (#6611) 2022-04-16 17:19:05 +01:00
MoreSideBar Another batch of whitespace trims (#6587) 2022-04-05 16:48:07 +01:00
PageControls Add layout switcher page control button (#7076) 2022-12-04 16:25:13 +00:00
PageTemplate Various accessibility improvements (#6742) 2022-06-28 14:05:52 +01:00
SideBar Add hidden option to make "More" sidebar tabs be horizontal (#7063) 2022-11-30 09:57:14 +00:00
SideBarSegments Various accessibility improvements (#6742) 2022-06-28 14:05:52 +01:00
TiddlerInfo Another batch of whitespace trims (#6587) 2022-04-05 16:48:07 +01:00
TopRightBar Another batch of whitespace trims (#6587) 2022-04-05 16:48:07 +01:00
ViewTemplate Ensure unfold indicator is always visible 2022-12-04 11:19:54 +00:00
ViewToolbar Trim Saga: Making existing trim tiddlers consistent (#6272) 2022-03-26 15:18:42 +00:00
AdvancedSearch.tid Trim Saga: I think this is the last batch (#6611) 2022-04-16 17:19:05 +01:00
AlertTemplate.tid Trim Saga: Advanced Search and actions (#6604) 2022-04-16 17:40:27 +01:00
BinaryWarning.tid Add download button/link to binary tiddler warning banners in view and edit mode (#4423) 2020-01-31 09:13:28 +00:00
ControlPanel.tid Trim Saga: I think this is the last batch (#6611) 2022-04-16 17:19:05 +01:00
DefaultSearchResultList.tid Trim Saga: Control panel and Editor Toolbar (#6600) 2022-04-06 08:27:05 +01:00
EditTemplate.tid Fix for bug #7054 (#7092) 2022-12-05 22:05:20 +00:00
ExportTiddlyWikiCore.tid Another batch of whitespace trims (#6587) 2022-04-05 16:48:07 +01:00
ImportListing.tid Refactor import preview to not use a hidden table row (#7057) 2022-11-23 21:53:21 +00:00
LayoutSwitcher.tid Trim Saga: All snippets, language tiddlers, and typed (#6275) 2022-04-01 12:10:29 +01:00
ListItemTemplate.tid Another batch of whitespace trims (#6587) 2022-04-05 16:48:07 +01:00
ListTaggedCascade.tid Trim Saga: All snippets, language tiddlers, and typed (#6275) 2022-04-01 12:10:29 +01:00
Manager.tid Trim Saga: whitespace trimming three big tiddlers (#6265) 2022-04-01 12:09:30 +01:00
MissingTemplate.tid Another batch of whitespace trims (#6587) 2022-04-05 16:48:07 +01:00
PageControls.tid Fix currentTiddler in pagecontrol buttons 2019-10-03 12:13:29 +01:00
PageStylesheet.tid Another batch of whitespace trims (#6587) 2022-04-05 16:48:07 +01:00
PageTemplate.tid Extend page template with filter assigned classes (#6976) 2022-10-28 12:58:58 +01:00
PaletteManager.tid Fix double palette entries 2022-05-20 17:13:12 +01:00
PluginInfo.tid Another batch of whitespace trims (#6587) 2022-04-05 16:48:07 +01:00
PluginInfoDefaultContents.tid Another batch of whitespace trims (#6587) 2022-04-05 16:48:07 +01:00
PluginListItemTemplate.tid Improve sidebar plugin listing 2021-12-07 13:17:15 +00:00
RootTemplate.tid Ensure root template contents is parsed in block mode 2020-11-09 17:08:34 +00:00
SearchResults.tid Another batch of whitespace trims (#6587) 2022-04-05 16:48:07 +01:00
SideBarLists.tid Modularize the sidebar 2018-08-02 13:22:21 +01:00
StoryTiddlerTemplate.tid Cascades: Ignore draft configuration tiddlers 2021-12-06 16:25:51 +00:00
SwitcherModal.tid Optionally allow click outside to close modals (#7072) 2022-12-03 17:26:44 +00:00
TagManager.tid Add indentation to $:/TagManager (#6923) 2022-11-14 17:42:17 +00:00
TagPickerTagTemplate.tid Cascades: Ignore draft configuration tiddlers 2021-12-06 16:25:51 +00:00
TagTemplate.tid Cascades: Ignore draft configuration tiddlers 2021-12-06 16:25:51 +00:00
TiddlerFields.tid Another batch of whitespace trims (#6587) 2022-04-05 16:48:07 +01:00
TiddlerFieldTemplate.tid Another batch of whitespace trims (#6587) 2022-04-05 16:48:07 +01:00
TiddlerIcon.tid Cascades: Ignore draft configuration tiddlers 2021-12-06 16:25:51 +00:00
TiddlerInfo.tid Another batch of whitespace trims (#6587) 2022-04-05 16:48:07 +01:00
UntaggedTemplate.tid Another batch of whitespace trims (#6587) 2022-04-05 16:48:07 +01:00
ViewTemplate.tid Extend page template with filter assigned classes (#6976) 2022-10-28 12:58:58 +01:00