1
0
mirror of https://github.com/Jermolene/TiddlyWiki5 synced 2024-09-27 14:48:19 +00:00
TiddlyWiki5/core
Simon Baird 39e4e69ae7
Show server response as error message in put saver (#6589)
* Show server response as error message in put saver

I'd like to use this on Tiddlyhost so users can get more informative
error messages if the put save fails for whatever reason.

This would make the put saver a viable replacement for the legacy
upload saver, which is what Tiddlyhost uses currently.

I'm not sure what standard WebDAV servers do, but I would guess they
don't provide any response body for put requests, and hence this
patch would have no impact for a standard WebDAV server. (That said,
it would be a good idea to test it to make sure there aren't any
unexpected regressions for WebDAV or other put saver compatible
services.)

* Access http response status directly in put saver

There's no need to extract it from the error string created inside
tw.utils.httpRequest if we can get it directly from the xhr object.

* Add 'Save starting' notification for put saver

There are two related changes here:

1. Add a 'Save starting' notification for the put saver, similar to
   the upload saver. Not sure if it was intentionally omitted for
   the put saver, but it seems reasonable to have the two be
   consistent.

2. Send the 'Save starting' notifications in both upload and put
   save right before the actual request is sent. While testing I
   noticed that the save might have failed before the "Save
   starting" notification appeared which doesn't seem useful.
2022-04-05 17:06:56 +01:00
..
images Run the SVG optimiser on the new plus/minus icons 2021-04-16 09:25:07 +01:00
language Trim Saga: Edit and View templates (#6276) 2022-03-26 14:16:01 +00:00
modules Show server response as error message in put saver (#6589) 2022-04-05 17:06:56 +01:00
palettes Add color-scheme: dark/light to the root element ... (#5720) 2021-05-25 22:22:21 +01:00
templates Fix processing of $:/tags/RawMarkupWikified/TopHead tiddlers 2022-01-11 17:16:50 +00:00
ui Another batch of whitespace trims (#6587) 2022-04-05 16:48:07 +01:00
wiki Another batch of whitespace trims (#6587) 2022-04-05 16:48:07 +01:00
acknowledgements.tid Remove extraneous text/vnd.tiddlywiki from system tiddlers in light of #2883 2017-06-09 15:42:32 +01:00
copyright.tid It's 2022 2022-01-03 20:22:52 +00:00
icon.tid Experimental SVG Compression 2015-03-31 14:39:36 +01:00
plugin.info Minor tweaks to plugin library listings 2020-04-06 10:15:18 +01:00
readme.tid Add/update plugin readmes 2014-08-07 15:49:52 +01:00
sjcl-license.tid Move SJCL license file into core plugin 2017-04-23 09:53:18 +01:00

title: $:/core/readme

This plugin contains TiddlyWiki's core components, comprising:

* JavaScript code modules
* Icons
* Templates needed to create TiddlyWiki's user interface
* British English (''en-GB'') translations of the localisable strings used by the core