First commit

.gitignore

@@ -4,4 +4,3 @@
 tmp/
 output/
 node_modules/
-

bin/build-site.sh

@@ -5,7 +5,7 @@
 # Default to the current version number for building the plugin library
 
 if [  -z "$TW5_BUILD_VERSION" ]; then
-    TW5_BUILD_VERSION=v5.2.8
+    TW5_BUILD_VERSION=v5.2.3
 fi
 
 echo "Using TW5_BUILD_VERSION as [$TW5_BUILD_VERSION]"
@@ -233,15 +233,6 @@ node $TW5_BUILD_TIDDLYWIKI \
 	--build index \
 	|| exit 1
 
-# /editions/twitter-archivist/index.html	Twitter Archivist edition
-node $TW5_BUILD_TIDDLYWIKI \
-	./editions/twitter-archivist \
-	--verbose \
-	--load $TW5_BUILD_OUTPUT/build.tid \
-	--output $TW5_BUILD_OUTPUT/editions/twitter-archivist/ \
-	--build index \
-	|| exit 1
-
 ######################################################
 #
 # Plugin demos
@@ -359,14 +350,14 @@ node $TW5_BUILD_TIDDLYWIKI \
 
 # Delete any existing static content
 
-rm -rf $TW5_BUILD_OUTPUT/languages/de-AT/static/*
+rm $TW5_BUILD_OUTPUT/languages/de-AT/static/*
-rm -rf $TW5_BUILD_OUTPUT/languages/de-DE/static/*
+rm $TW5_BUILD_OUTPUT/languages/de-DE/static/*
-rm -rf $TW5_BUILD_OUTPUT/languages/es-ES/static/*
+rm $TW5_BUILD_OUTPUT/languages/es-ES/static/*
-rm -rf $TW5_BUILD_OUTPUT/languages/fr-FR/static/*
+rm $TW5_BUILD_OUTPUT/languages/fr-FR/static/*
-rm -rf $TW5_BUILD_OUTPUT/languages/ja-JP/static/*
+rm $TW5_BUILD_OUTPUT/languages/ja-JP/static/*
-rm -rf $TW5_BUILD_OUTPUT/languages/ko-KR/static/*
+rm $TW5_BUILD_OUTPUT/languages/ko-KR/static/*
-rm -rf $TW5_BUILD_OUTPUT/languages/zh-Hans/static/*
+rm $TW5_BUILD_OUTPUT/languages/zh-Hans/static/*
-rm -rf $TW5_BUILD_OUTPUT/languages/zh-Hant/static/*
+rm $TW5_BUILD_OUTPUT/languages/zh-Hant/static/*
 
 # /languages/de-AT/index.html		Demo wiki with de-AT language
 # /languages/de-AT/empty.html		Empty wiki with de-AT language
@@ -459,7 +450,7 @@ node $TW5_BUILD_TIDDLYWIKI \
 	--verbose \
 	--load $TW5_BUILD_OUTPUT/build.tid \
 	--output $TW5_BUILD_OUTPUT/library/$TW5_BUILD_VERSION \
-	--build library\
+	--build \
 	|| exit 1
 
 # Delete the temporary build tiddler

bin/clean.sh

@@ -2,4 +2,4 @@
 
 # Remove any output files
 
-find . -regex "^./editions/.*/output/.*" -delete
+find . -regex "^./editions/[a-z0-9\.-]*/output/.*" -delete

bin/test.sh

@@ -9,7 +9,6 @@ node ./tiddlywiki.js \
 	--verbose \
 	--version \
 	--rendertiddler $:/core/save/all test.html text/plain \
-	--test \
 	|| exit 1
 
 echo To run the tests in a browser, open "editions/test/output/test.html"

boot/boot.js

@@ -313,7 +313,7 @@ $tw.utils.getLocationHash = function() {
 	var idx = href.indexOf('#');
 	if(idx === -1) {
 		return "#";
-	} else if(href.substr(idx + 1,1) === "#" ||  href.substr(idx + 1,3) === "%23") {
+	} else if(idx < href.length-1 && href[idx+1] === '#') {
 		// Special case: ignore location hash if it itself starts with a #
 		return "#";
 	} else {
@@ -375,7 +375,7 @@ $tw.utils.stringifyList = function(value) {
 		var result = new Array(value.length);
 		for(var t=0, l=value.length; t<l; t++) {
 			var entry = value[t] || "";
-			if(entry.match(/[^\S\xA0]/mg)) {
+			if(entry.indexOf(" ") !== -1) {
 				result[t] = "[[" + entry + "]]";
 			} else {
 				result[t] = entry;
@@ -1881,7 +1881,7 @@ A default set of files for TiddlyWiki to ignore during load.
 This matches what NPM ignores, and adds "*.meta" to ignore tiddler
 metadata files.
 */
-$tw.boot.excludeRegExp = /^\.DS_Store$|^.*\.meta$|^\..*\.swp$|^\._.*$|^\.git$|^\.github$|^\.vscode$|^\.hg$|^\.lock-wscript$|^\.svn$|^\.wafpickle-.*$|^CVS$|^npm-debug\.log$/;
+$tw.boot.excludeRegExp = /^\.DS_Store$|^.*\.meta$|^\..*\.swp$|^\._.*$|^\.git$|^\.hg$|^\.lock-wscript$|^\.svn$|^\.wafpickle-.*$|^CVS$|^npm-debug\.log$/;
 
 /*
 Load all the tiddlers recursively from a directory, including honouring `tiddlywiki.files` files for drawing in external files. Returns an array of {filepath:,type:,tiddlers: [{..fields...}],hasMetaFile:}. Note that no file information is returned for externally loaded tiddlers, just the `tiddlers` property.
@@ -1920,7 +1920,7 @@ $tw.loadTiddlersFromSpecification = function(filepath,excludeRegExp) {
 	// Read the specification
 	var filesInfo = $tw.utils.parseJSONSafe(fs.readFileSync(filepath + path.sep + "tiddlywiki.files","utf8"));
 	// Helper to process a file
-	var processFile = function(filename,isTiddlerFile,fields,isEditableFile,rootPath) {
+	var processFile = function(filename,isTiddlerFile,fields,isEditableFile) {
 		var extInfo = $tw.config.fileExtensionInfo[path.extname(filename)],
 			type = (extInfo || {}).type || fields.type || "text/plain",
 			typeInfo = $tw.config.contentTypeInfo[type] || {},
@@ -1941,12 +1941,6 @@ $tw.loadTiddlersFromSpecification = function(filepath,excludeRegExp) {
 				} else {
 					var value = tiddler[name];
 					switch(fieldInfo.source) {
-						case "subdirectories":
-							value = path.relative(rootPath, filename).split('/').slice(0, -1);
-							break;
-						case "filepath":
-							value = path.relative(rootPath, filename);
-							break;
 						case "filename":
 							value = path.basename(filename);
 							break;
@@ -2029,7 +2023,7 @@ $tw.loadTiddlersFromSpecification = function(filepath,excludeRegExp) {
 					var thisPath = path.relative(filepath, files[t]),
 					filename = path.basename(thisPath);
 					if(filename !== "tiddlywiki.files" && !metaRegExp.test(filename) && fileRegExp.test(filename)) {
-						processFile(thisPath,dirSpec.isTiddlerFile,dirSpec.fields,dirSpec.isEditableFile,dirSpec.path);
+						processFile(thisPath,dirSpec.isTiddlerFile,dirSpec.fields,dirSpec.isEditableFile);
 					}
 				}
 			} else {
@@ -2409,12 +2403,11 @@ $tw.boot.initStartup = function(options) {
 	$tw.utils.registerFileType("application/x-font-ttf","base64",".woff");
 	$tw.utils.registerFileType("application/font-woff2","base64",".woff2");
 	$tw.utils.registerFileType("audio/ogg","base64",".ogg");
-	$tw.utils.registerFileType("audio/mp4","base64",[".mp4",".m4a"]);
 	$tw.utils.registerFileType("video/ogg","base64",[".ogm",".ogv",".ogg"]);
 	$tw.utils.registerFileType("video/webm","base64",".webm");
 	$tw.utils.registerFileType("video/mp4","base64",".mp4");
 	$tw.utils.registerFileType("audio/mp3","base64",".mp3");
-	$tw.utils.registerFileType("audio/mpeg","base64");
+	$tw.utils.registerFileType("audio/mp4","base64",[".mp4",".m4a"]);
 	$tw.utils.registerFileType("text/markdown","utf8",[".md",".markdown"],{deserializerType:"text/x-markdown"});
 	$tw.utils.registerFileType("text/x-markdown","utf8",[".md",".markdown"]);
 	$tw.utils.registerFileType("application/enex+xml","utf8",".enex");

core/copyright.tid

@@ -4,7 +4,7 @@ type: text/plain
 TiddlyWiki created by Jeremy Ruston, (jeremy [at] jermolene [dot] com)
 
 Copyright (c) 2004-2007, Jeremy Ruston
-Copyright (c) 2007-2023, UnaMesa Association
+Copyright (c) 2007-2022, UnaMesa Association
 All rights reserved.
 
 Redistribution and use in source and binary forms, with or without

core/images/layout-button.tid

@@ -1,4 +0,0 @@
-title: $:/core/images/layout-button
-tags: $:/tags/Image
-
-<svg width="22pt" height="22pt" class="tc-image-layout-button tc-image-button" viewBox="0 0 24 24" stroke-width="1" stroke="none"><path d="M0 0h24v24H0z" fill="none"/><rect x="2" y="2" width="7" height="7" rx="2"/><rect x="2" y="13" width="7" height="9" rx="2"/><rect x="12" y="2" width="10" height="20" rx="2"/></svg>

core/images/mastodon.tid

@@ -1,6 +0,0 @@
-title: $:/core/images/mastodon
-tags: $:/tags/Image
-
-<svg width="22pt" height="22pt" class="tc-image-mastodon tc-image-button" viewBox="0 0 128 128">
-  <path d="M112.716,76.735C111.231,85.764 99.411,95.646 85.836,97.561C78.757,98.559 71.787,99.476 64.355,99.073C52.201,98.415 42.61,95.646 42.61,95.646C42.61,97.044 42.683,98.374 42.829,99.619C44.409,113.79 54.723,114.639 64.493,115.035C74.354,115.434 83.134,112.163 83.134,112.163L83.539,122.695C83.539,122.695 76.642,127.071 64.355,127.875C57.58,128.315 49.167,127.674 39.369,124.61C18.118,117.965 14.463,91.202 13.904,64.048C13.733,55.985 13.839,48.383 13.839,42.024C13.839,14.257 29.238,6.118 29.238,6.118C37.002,1.905 50.326,0.134 64.177,-0L64.517,-0C78.369,0.134 91.701,1.905 99.465,6.118C99.465,6.118 114.864,14.257 114.864,42.024C114.864,42.024 115.057,62.511 112.716,76.735ZM96.7,44.179C96.7,37.307 95.219,31.847 92.245,27.807C89.177,23.767 85.16,21.696 80.174,21.696C74.403,21.696 70.034,24.316 67.146,29.556L64.337,35.118L61.529,29.556C58.64,24.316 54.271,21.696 48.501,21.696C43.514,21.696 39.497,23.767 36.43,27.807C33.455,31.847 31.974,37.307 31.974,44.179L31.974,77.8L43.249,77.8L43.249,45.167C43.249,38.288 45.699,34.796 50.599,34.796C56.017,34.796 58.733,38.938 58.733,47.128L58.733,64.99L69.941,64.99L69.941,47.128C69.941,38.938 72.657,34.796 78.075,34.796C82.975,34.796 85.425,38.288 85.425,45.167L85.425,77.8L96.7,77.8L96.7,44.179Z"/>
-</svg>

core/images/save-button-dynamic.tid

@@ -1,12 +0,0 @@
-title: $:/core/images/save-button-dynamic
-tags: $:/tags/Image
-
-<svg width="22pt" height="22pt" class="tc-image-save-button-dynamic tc-image-button" viewBox="0 0 128 128">
-<g class="tc-image-save-button-dynamic-clean">
-<path fill-rule="evenodd" d="M120.783 34.33c4.641 8.862 7.266 18.948 7.266 29.646 0 35.347-28.653 64-64 64-35.346 0-64-28.653-64-64 0-35.346 28.654-64 64-64 18.808 0 35.72 8.113 47.43 21.03l2.68-2.68c3.13-3.13 8.197-3.132 11.321-.008 3.118 3.118 3.121 8.193-.007 11.32l-4.69 4.691zm-12.058 12.058a47.876 47.876 0 013.324 17.588c0 26.51-21.49 48-48 48s-48-21.49-48-48 21.49-48 48-48c14.39 0 27.3 6.332 36.098 16.362L58.941 73.544 41.976 56.578c-3.127-3.127-8.201-3.123-11.32-.005-3.123 3.124-3.119 8.194.006 11.319l22.617 22.617a7.992 7.992 0 005.659 2.347c2.05 0 4.101-.783 5.667-2.349l44.12-44.12z"/>
-</g>
-<g class="tc-image-save-button-dynamic-dirty">
-<path d="M64.856912,0 C100.203136,0 128.856912,28.653776 128.856912,64 C128.856912,99.346224 100.203136,128 64.856912,128 C29.510688,128 0.856911958,99.346224 0.856911958,64 C0.856911958,28.653776 29.510688,0 64.856912,0 Z M64.856912,16 C38.347244,16 16.856912,37.490332 16.856912,64 C16.856912,90.509668 38.347244,112 64.856912,112 C91.3665799,112 112.856912,90.509668 112.856912,64 C112.856912,37.490332 91.3665799,16 64.856912,16 Z"></path>
-<circle cx="65" cy="64" r="32"></circle>
-</g>
-</svg>

core/language/en-GB/Buttons.multids

@@ -59,8 +59,6 @@ Home/Caption: home
 Home/Hint: Open the default tiddlers
 Language/Caption: language
 Language/Hint: Choose the user interface language
-LayoutSwitcher/Hint: Open layout switcher
-LayoutSwitcher/Caption: layout
 Manager/Caption: tiddler manager
 Manager/Hint: Open tiddler manager
 More/Caption: more

core/language/en-GB/ControlPanel.multids

@@ -7,7 +7,7 @@ Appearance/Hint: Ways to customise the appearance of your TiddlyWiki.
 Basics/AnimDuration/Prompt: Animation duration
 Basics/AutoFocus/Prompt: Default focus field for new tiddlers
 Basics/Caption: Basics
-Basics/DefaultTiddlers/BottomHint: Use [[double square brackets]] for titles with spaces. Or you can choose to {{retain story ordering||$:/snippets/retain-story-ordering-button}}
+Basics/DefaultTiddlers/BottomHint: Use &#91;&#91;double square brackets&#93;&#93; for titles with spaces. Or you can choose to <$button set="$:/DefaultTiddlers" setTo="[list[$:/StoryList]]">retain story ordering</$button>
 Basics/DefaultTiddlers/Prompt: Default tiddlers
 Basics/DefaultTiddlers/TopHint: Choose which tiddlers are displayed at startup
 Basics/Language/Prompt: Hello! Current language:
@@ -90,8 +90,8 @@ Plugins/Languages/Caption: Languages
 Plugins/Languages/Hint: Language pack plugins
 Plugins/NoInfoFound/Hint: No ''"<$text text=<<currentTab>>/>"'' found
 Plugins/NotInstalled/Hint: This plugin is not currently installed
-Plugins/OpenPluginLibrary: Open plugin library
+Plugins/OpenPluginLibrary: open plugin library
-Plugins/ClosePluginLibrary: Close plugin library
+Plugins/ClosePluginLibrary: close plugin library
 Plugins/PluginWillRequireReload: (requires reload)
 Plugins/Plugins/Caption: Plugins
 Plugins/Plugins/Hint: Plugins

core/language/en-GB/Fields.multids

@@ -1,13 +1,11 @@
 title: $:/language/Docs/Fields/
 
 _canonical_uri: The full URI of an external image tiddler
-author: Name of the author of a plugin
 bag: The name of the bag from which a tiddler came
 caption: The text to be displayed on a tab or button
 code-body: The view template will display the tiddler as code if set to ''yes''
 color: The CSS color value associated with a tiddler
 component: The name of the component responsible for an [[alert tiddler|AlertMechanism]]
-core-version: For a plugin, indicates what version of TiddlyWiki with which it is compatible
 current-tiddler: Used to cache the top tiddler in a [[history list|HistoryMechanism]]
 created: The date a tiddler was created
 creator: The name of the person who created a tiddler
@@ -24,9 +22,7 @@ list-before: If set, the title of a tiddler before which this tiddler should be
 list-after: If set, the title of the tiddler after which this tiddler should be added to the ordered list of tiddler titles, or at the end of the list if this field is present but empty
 modified: The date and time at which a tiddler was last modified
 modifier: The tiddler title associated with the person who last modified a tiddler
-module-type: For javascript tiddlers, specifies what kind of module it is
 name: The human readable name associated with a plugin tiddler
-parent-plugin: For a plugin, specifies which plugin of which it is a sub-plugin
 plugin-priority: A numerical value indicating the priority of a plugin tiddler
 plugin-type: The type of plugin in a plugin tiddler
 revision: The revision of the tiddler held at the server

core/language/en-GB/Help/commands.tid

@@ -1,18 +0,0 @@
-title: $:/language/Help/commands
-description: Run commands returned from a filter
-
-Sequentially run the command tokens returned from a filter
-
-```
---commands <filter>
-```
-
-Examples
-
-```
---commands "[enlist{$:/build-commands-as-text}]"
-```
-
-```
---commands "[{$:/build-commands-as-json}jsonindexes[]] :map[{$:/build-commands-as-json}jsonget<currentTiddler>]"
-```

core/language/en-GB/Misc.multids

@@ -40,7 +40,6 @@ Error/RetrievingSkinny: Error retrieving skinny tiddler list
 Error/SavingToTWEdit: Error saving to TWEdit
 Error/WhileSaving: Error while saving
 Error/XMLHttpRequest: XMLHttpRequest error code
-Error/ZoominTextNode: Story View Error: It appears you tried to interact with a tiddler that displays in a custom container. This is most likely caused by using `$:/tags/StoryTiddlerTemplateFilter` with a template that contains text or whitespace at the start. Please use the pragma `\whitespace trim` and ensure the whole contents of the tiddler is wrapped in a single HTML element. The text that caused this issue:
 InternalJavaScriptError/Title: Internal JavaScript Error
 InternalJavaScriptError/Hint: Well, this is embarrassing. It is recommended that you restart TiddlyWiki by refreshing your browser
 LayoutSwitcher/Description: Open the layout switcher

core/language/en-GB/Modals/SaveInstructions.tid

@@ -0,0 +1,21 @@
+title: $:/language/Modals/SaveInstructions
+subtitle: Save your work
+footer: <$button message="tm-close-tiddler">Close</$button>
+help: https://tiddlywiki.com/static/SavingChanges.html
+
+Your changes to this wiki need to be saved as a ~TiddlyWiki HTML file.
+
+!!! Desktop browsers
+
+# Select ''Save As'' from the ''File'' menu
+# Choose a filename and location
+#* Some browsers also require you to explicitly specify the file saving format as ''Webpage, HTML only'' or similar
+# Close this tab
+
+!!! Smartphone browsers
+
+# Create a bookmark to this page
+#* If you've got iCloud or Google Sync set up then the bookmark will automatically sync to your desktop where you can open it and save it as above
+# Close this tab
+
+//If you open the bookmark again in Mobile Safari you will see this message again. If you want to go ahead and use the file, just click the ''close'' button below//

core/modules/commands/commands.js

@@ -1,42 +0,0 @@
-/*\
-title: $:/core/modules/commands/commands.js
-type: application/javascript
-module-type: command
-
-Runs the commands returned from a filter
-
-\*/
-
-(function() {
-
-/*jslint node: true, browser: true */
-/*global $tw: false */
-"use strict";
-
-exports.info = {
-	name: "commands",
-	synchronous: true
-};
-
-var Command = function(params, commander) {
-	this.params = params;
-	this.commander = commander;
-};
-
-Command.prototype.execute = function() {
-	// Parse the filter
-	var filter = this.params[0];
-	if(!filter) {
-		return "No filter specified";
-	}
-	var commands = this.commander.wiki.filterTiddlers(filter)
-	if(commands.length === 0) {
-		return "No tiddlers found for filter '" + filter + "'";
-	}
-	this.commander.addCommandTokens(commands);
-	return null;
-};
-
-exports.Command = Command;
-
-})();

core/modules/commands/rendertiddlers.js

@@ -57,7 +57,7 @@ Command.prototype.execute = function() {
 				exportPath = path.resolve(outputPath,macroPath + extension);
 			}
 		}
-		var finalPath = exportPath || path.resolve(pathname,$tw.utils.encodeURIComponentExtended(title) + extension);
+		var finalPath = exportPath || path.resolve(pathname,encodeURIComponent(title) + extension);
 		$tw.utils.createFileDirectories(finalPath);
 		fs.writeFileSync(finalPath,text,"utf8");
 	});

core/modules/commands/savelibrarytiddlers.js

@@ -65,7 +65,7 @@ Command.prototype.execute = function() {
 	$tw.utils.each(filteredPluginList,function(title) {
 		var tiddler = containerData.tiddlers[title];
 		// Save each JSON file and collect the skinny data
-		var pathname = path.resolve(self.commander.outputPath,basepath + $tw.utils.encodeURIComponentExtended(title) + ".json");
+		var pathname = path.resolve(self.commander.outputPath,basepath + encodeURIComponent(title) + ".json");
 		$tw.utils.createFileDirectories(pathname);
 		fs.writeFileSync(pathname,JSON.stringify(tiddler),"utf8");
 		// Collect the skinny list data

core/modules/commands/savetiddlers.js

@@ -45,7 +45,7 @@ Command.prototype.execute = function() {
 		var tiddler = self.commander.wiki.getTiddler(title),
 			type = tiddler.fields.type || "text/vnd.tiddlywiki",
 			contentTypeInfo = $tw.config.contentTypeInfo[type] || {encoding: "utf8"},
-			filename = path.resolve(pathname,$tw.utils.encodeURIComponentExtended(title));
+			filename = path.resolve(pathname,encodeURIComponent(title));
 		fs.writeFileSync(filename,tiddler.fields.text,contentTypeInfo.encoding);
 	});
 	return null;

core/modules/config.js

@@ -30,7 +30,7 @@ exports.textPrimitives.wikiLink = exports.textPrimitives.upperLetter + "+" +
 	exports.textPrimitives.upperLetter +
 	exports.textPrimitives.anyLetter + "*";
 
-exports.htmlEntities = {quot:34, dollar:36, amp:38, apos:39, lt:60, gt:62, nbsp:160, iexcl:161, cent:162, pound:163, curren:164, yen:165, brvbar:166, sect:167, uml:168, copy:169, ordf:170, laquo:171, not:172, shy:173, reg:174, macr:175, deg:176, plusmn:177, sup2:178, sup3:179, acute:180, micro:181, para:182, middot:183, cedil:184, sup1:185, ordm:186, raquo:187, frac14:188, frac12:189, frac34:190, iquest:191, Agrave:192, Aacute:193, Acirc:194, Atilde:195, Auml:196, Aring:197, AElig:198, Ccedil:199, Egrave:200, Eacute:201, Ecirc:202, Euml:203, Igrave:204, Iacute:205, Icirc:206, Iuml:207, ETH:208, Ntilde:209, Ograve:210, Oacute:211, Ocirc:212, Otilde:213, Ouml:214, times:215, Oslash:216, Ugrave:217, Uacute:218, Ucirc:219, Uuml:220, Yacute:221, THORN:222, szlig:223, agrave:224, aacute:225, acirc:226, atilde:227, auml:228, aring:229, aelig:230, ccedil:231, egrave:232, eacute:233, ecirc:234, euml:235, igrave:236, iacute:237, icirc:238, iuml:239, eth:240, ntilde:241, ograve:242, oacute:243, ocirc:244, otilde:245, ouml:246, divide:247, oslash:248, ugrave:249, uacute:250, ucirc:251, uuml:252, yacute:253, thorn:254, yuml:255, OElig:338, oelig:339, Scaron:352, scaron:353, Yuml:376, fnof:402, circ:710, tilde:732, Alpha:913, Beta:914, Gamma:915, Delta:916, Epsilon:917, Zeta:918, Eta:919, Theta:920, Iota:921, Kappa:922, Lambda:923, Mu:924, Nu:925, Xi:926, Omicron:927, Pi:928, Rho:929, Sigma:931, Tau:932, Upsilon:933, Phi:934, Chi:935, Psi:936, Omega:937, alpha:945, beta:946, gamma:947, delta:948, epsilon:949, zeta:950, eta:951, theta:952, iota:953, kappa:954, lambda:955, mu:956, nu:957, xi:958, omicron:959, pi:960, rho:961, sigmaf:962, sigma:963, tau:964, upsilon:965, phi:966, chi:967, psi:968, omega:969, thetasym:977, upsih:978, piv:982, ensp:8194, emsp:8195, thinsp:8201, zwnj:8204, zwj:8205, lrm:8206, rlm:8207, ndash:8211, mdash:8212, lsquo:8216, rsquo:8217, sbquo:8218, ldquo:8220, rdquo:8221, bdquo:8222, dagger:8224, Dagger:8225, bull:8226, hellip:8230, permil:8240, prime:8242, Prime:8243, lsaquo:8249, rsaquo:8250, oline:8254, frasl:8260, euro:8364, image:8465, weierp:8472, real:8476, trade:8482, alefsym:8501, larr:8592, uarr:8593, rarr:8594, darr:8595, harr:8596, crarr:8629, lArr:8656, uArr:8657, rArr:8658, dArr:8659, hArr:8660, forall:8704, part:8706, exist:8707, empty:8709, nabla:8711, isin:8712, notin:8713, ni:8715, prod:8719, sum:8721, minus:8722, lowast:8727, radic:8730, prop:8733, infin:8734, ang:8736, and:8743, or:8744, cap:8745, cup:8746, int:8747, there4:8756, sim:8764, cong:8773, asymp:8776, ne:8800, equiv:8801, le:8804, ge:8805, sub:8834, sup:8835, nsub:8836, sube:8838, supe:8839, oplus:8853, otimes:8855, perp:8869, sdot:8901, lceil:8968, rceil:8969, lfloor:8970, rfloor:8971, lang:9001, rang:9002, loz:9674, spades:9824, clubs:9827, hearts:9829, diams:9830 };
+exports.htmlEntities = {quot:34, amp:38, apos:39, lt:60, gt:62, nbsp:160, iexcl:161, cent:162, pound:163, curren:164, yen:165, brvbar:166, sect:167, uml:168, copy:169, ordf:170, laquo:171, not:172, shy:173, reg:174, macr:175, deg:176, plusmn:177, sup2:178, sup3:179, acute:180, micro:181, para:182, middot:183, cedil:184, sup1:185, ordm:186, raquo:187, frac14:188, frac12:189, frac34:190, iquest:191, Agrave:192, Aacute:193, Acirc:194, Atilde:195, Auml:196, Aring:197, AElig:198, Ccedil:199, Egrave:200, Eacute:201, Ecirc:202, Euml:203, Igrave:204, Iacute:205, Icirc:206, Iuml:207, ETH:208, Ntilde:209, Ograve:210, Oacute:211, Ocirc:212, Otilde:213, Ouml:214, times:215, Oslash:216, Ugrave:217, Uacute:218, Ucirc:219, Uuml:220, Yacute:221, THORN:222, szlig:223, agrave:224, aacute:225, acirc:226, atilde:227, auml:228, aring:229, aelig:230, ccedil:231, egrave:232, eacute:233, ecirc:234, euml:235, igrave:236, iacute:237, icirc:238, iuml:239, eth:240, ntilde:241, ograve:242, oacute:243, ocirc:244, otilde:245, ouml:246, divide:247, oslash:248, ugrave:249, uacute:250, ucirc:251, uuml:252, yacute:253, thorn:254, yuml:255, OElig:338, oelig:339, Scaron:352, scaron:353, Yuml:376, fnof:402, circ:710, tilde:732, Alpha:913, Beta:914, Gamma:915, Delta:916, Epsilon:917, Zeta:918, Eta:919, Theta:920, Iota:921, Kappa:922, Lambda:923, Mu:924, Nu:925, Xi:926, Omicron:927, Pi:928, Rho:929, Sigma:931, Tau:932, Upsilon:933, Phi:934, Chi:935, Psi:936, Omega:937, alpha:945, beta:946, gamma:947, delta:948, epsilon:949, zeta:950, eta:951, theta:952, iota:953, kappa:954, lambda:955, mu:956, nu:957, xi:958, omicron:959, pi:960, rho:961, sigmaf:962, sigma:963, tau:964, upsilon:965, phi:966, chi:967, psi:968, omega:969, thetasym:977, upsih:978, piv:982, ensp:8194, emsp:8195, thinsp:8201, zwnj:8204, zwj:8205, lrm:8206, rlm:8207, ndash:8211, mdash:8212, lsquo:8216, rsquo:8217, sbquo:8218, ldquo:8220, rdquo:8221, bdquo:8222, dagger:8224, Dagger:8225, bull:8226, hellip:8230, permil:8240, prime:8242, Prime:8243, lsaquo:8249, rsaquo:8250, oline:8254, frasl:8260, euro:8364, image:8465, weierp:8472, real:8476, trade:8482, alefsym:8501, larr:8592, uarr:8593, rarr:8594, darr:8595, harr:8596, crarr:8629, lArr:8656, uArr:8657, rArr:8658, dArr:8659, hArr:8660, forall:8704, part:8706, exist:8707, empty:8709, nabla:8711, isin:8712, notin:8713, ni:8715, prod:8719, sum:8721, minus:8722, lowast:8727, radic:8730, prop:8733, infin:8734, ang:8736, and:8743, or:8744, cap:8745, cup:8746, int:8747, there4:8756, sim:8764, cong:8773, asymp:8776, ne:8800, equiv:8801, le:8804, ge:8805, sub:8834, sup:8835, nsub:8836, sube:8838, supe:8839, oplus:8853, otimes:8855, perp:8869, sdot:8901, lceil:8968, rceil:8969, lfloor:8970, rfloor:8971, lang:9001, rang:9002, loz:9674, spades:9824, clubs:9827, hearts:9829, diams:9830 };
 
 exports.htmlVoidElements = "area,base,br,col,command,embed,hr,img,input,keygen,link,meta,param,source,track,wbr".split(",");
 

core/modules/editor/engines/framed.js

@@ -162,13 +162,13 @@ FramedEngine.prototype.fixHeight = function() {
 		if(this.widget.editAutoHeight) {
 			if(this.domNode && !this.domNode.isTiddlyWikiFakeDom) {
 				var newHeight = $tw.utils.resizeTextAreaToFit(this.domNode,this.widget.editMinHeight);
-				this.iframeNode.style.height = newHeight + "px";
+				this.iframeNode.style.height = (newHeight + 14) + "px"; // +14 for the border on the textarea
 			}
 		} else {
 			var fixedHeight = parseInt(this.widget.wiki.getTiddlerText(HEIGHT_VALUE_TITLE,"400px"),10);
 			fixedHeight = Math.max(fixedHeight,20);
 			this.domNode.style.height = fixedHeight + "px";
-			this.iframeNode.style.height = fixedHeight + "px";
+			this.iframeNode.style.height = (fixedHeight + 14) + "px";
 		}
 	}
 };
@@ -177,11 +177,9 @@ FramedEngine.prototype.fixHeight = function() {
 Focus the engine node
 */
 FramedEngine.prototype.focus  = function() {
-	if(this.domNode.focus) {
+	if(this.domNode.focus && this.domNode.select) {
 		this.domNode.focus();
-	}
+		this.domNode.select();
-	if(this.domNode.select) {
-		$tw.utils.setSelectionByPosition(this.domNode,this.widget.editFocusSelectFromStart,this.widget.editFocusSelectFromEnd);
 	}
 };
 

core/modules/editor/engines/simple.js

@@ -119,12 +119,10 @@ SimpleEngine.prototype.fixHeight = function() {
 /*
 Focus the engine node
 */
-SimpleEngine.prototype.focus = function() {
+SimpleEngine.prototype.focus  = function() {
-	if(this.domNode.focus) {
+	if(this.domNode.focus && this.domNode.select) {
 		this.domNode.focus();
-	}
+		this.domNode.select();
-	if(this.domNode.select) {
-		$tw.utils.setSelectionByPosition(this.domNode,this.widget.editFocusSelectFromStart,this.widget.editFocusSelectFromEnd);
 	}
 };
 

core/modules/editor/factory.js

@@ -180,8 +180,6 @@ function editTextWidgetFactory(toolbarEngine,nonToolbarEngine) {
 		this.editMinHeight = this.getAttribute("minHeight",DEFAULT_MIN_TEXT_AREA_HEIGHT);
 		this.editFocusPopup = this.getAttribute("focusPopup");
 		this.editFocus = this.getAttribute("focus");
-		this.editFocusSelectFromStart = $tw.utils.parseNumber(this.getAttribute("focusSelectFromStart","0"));
-		this.editFocusSelectFromEnd = $tw.utils.parseNumber(this.getAttribute("focusSelectFromEnd","0"));
 		this.editTabIndex = this.getAttribute("tabindex");
 		this.editCancelPopups = this.getAttribute("cancelPopups","") === "yes";
 		this.editInputActions = this.getAttribute("inputActions");
@@ -220,7 +218,7 @@ function editTextWidgetFactory(toolbarEngine,nonToolbarEngine) {
 	EditTextWidget.prototype.refresh = function(changedTiddlers) {
 		var changedAttributes = this.computeAttributes();
 		// Completely rerender if any of our attributes have changed
-		if(changedAttributes.tiddler || changedAttributes.field || changedAttributes.index || changedAttributes["default"] || changedAttributes["class"] || changedAttributes.placeholder || changedAttributes.size || changedAttributes.autoHeight || changedAttributes.minHeight || changedAttributes.focusPopup ||  changedAttributes.rows || changedAttributes.tabindex || changedAttributes.cancelPopups || changedAttributes.inputActions || changedAttributes.refreshTitle || changedAttributes.autocomplete || changedTiddlers[HEIGHT_MODE_TITLE] || changedTiddlers[ENABLE_TOOLBAR_TITLE] || changedTiddlers["$:/palette"] || changedAttributes.disabled || changedAttributes.fileDrop) {
+		if(changedAttributes.tiddler || changedAttributes.field || changedAttributes.index || changedAttributes["default"] || changedAttributes["class"] || changedAttributes.placeholder || changedAttributes.size || changedAttributes.autoHeight || changedAttributes.minHeight || changedAttributes.focusPopup ||  changedAttributes.rows || changedAttributes.tabindex || changedAttributes.cancelPopups || changedAttributes.inputActions || changedAttributes.refreshTitle || changedAttributes.autocomplete || changedTiddlers[HEIGHT_MODE_TITLE] || changedTiddlers[ENABLE_TOOLBAR_TITLE] || changedAttributes.disabled || changedAttributes.fileDrop) {
 			this.refreshSelf();
 			return true;
 		} else if (changedTiddlers[this.editRefreshTitle]) {
@@ -300,7 +298,7 @@ function editTextWidgetFactory(toolbarEngine,nonToolbarEngine) {
 	Propogate keydown events to our container for the keyboard widgets benefit
 	*/
 	EditTextWidget.prototype.propogateKeydownEvent = function(event) {
-		var newEvent = this.cloneEvent(event,["keyCode","code","which","key","metaKey","ctrlKey","altKey","shiftKey"]);
+		var newEvent = this.cloneEvent(event,["keyCode","which","metaKey","ctrlKey","altKey","shiftKey"]);
 		return !this.parentDomNode.dispatchEvent(newEvent);
 	};
 

core/modules/filterrunprefixes/cascade.js

@@ -25,10 +25,20 @@ exports.cascade = function(operationSubFunction,options) {
 					if(!filterFnList[index]) {
 						filterFnList[index] = options.wiki.compileFilter(filter);
 					}
-					var output = filterFnList[index](options.wiki.makeTiddlerIterator([title]),widget.makeFakeWidgetWithVariables({
+					var output = filterFnList[index](options.wiki.makeTiddlerIterator([title]),{
-						"currentTiddler": "" + title,
+						getVariable: function(name,opts) {
-						"..currentTiddler": widget.getVariable("currentTiddler","")
+							opts = opts || {};
-					}));
+							opts.variables = {
+								"currentTiddler": "" + title,
+								"..currentTiddler": widget.getVariable("currentTiddler")
+							};
+							if(name in opts.variables) {
+								return opts.variables[name];
+							} else {
+								return widget.getVariable(name,opts);
+							}
+						}
+					});
 					if(output.length !== 0) {
 						result = output[0];
 						return false;

core/modules/filterrunprefixes/filter.js

@@ -19,13 +19,23 @@ exports.filter = function(operationSubFunction,options) {
 			var resultsToRemove = [],
 				index = 0;
 			results.each(function(title) {
-				var filtered = operationSubFunction(options.wiki.makeTiddlerIterator([title]),widget.makeFakeWidgetWithVariables({
+				var filtered = operationSubFunction(options.wiki.makeTiddlerIterator([title]),{
-					"currentTiddler": "" + title,
+					getVariable: function(name,opts) {
-					"..currentTiddler": widget.getVariable("currentTiddler",""),
+						opts = opts || {};
-					"index": "" + index,
+						opts.variables = {
-					"revIndex": "" +  (results.length - 1 - index),
+							"currentTiddler": "" + title,
-					"length": "" + results.length
+							"..currentTiddler": widget.getVariable("currentTiddler"),
-				}));
+							"index": "" + index,
+							"revIndex": "" +  (results.length - 1 - index),
+							"length": "" + results.length
+						};
+						if(name in opts.variables) {
+							return opts.variables[name];
+						} else {
+							return widget.getVariable(name,opts);
+						}
+					}
+				});
 				if(filtered.length === 0) {
 					resultsToRemove.push(title);
 				}

core/modules/filterrunprefixes/map.js

@@ -21,13 +21,23 @@ exports.map = function(operationSubFunction,options) {
 				flatten = (suffixes[0] && suffixes[0][0] === "flat") ? true : false;
 			results.clear();
 			$tw.utils.each(inputTitles,function(title) {
-				var filtered = operationSubFunction(options.wiki.makeTiddlerIterator([title]),widget.makeFakeWidgetWithVariables({
+				var filtered = operationSubFunction(options.wiki.makeTiddlerIterator([title]),{
-					"currentTiddler": "" + title,
+					getVariable: function(name,opts) {
-					"..currentTiddler": widget.getVariable("currentTiddler",""),
+						opts = opts || {};
-					"index": "" + index,
+						opts.variables = {
-					"revIndex": "" +  (inputTitles.length - 1 - index),
+							"currentTiddler": "" + title,
-					"length": "" + inputTitles.length
+							"..currentTiddler": widget.getVariable("currentTiddler"),
-				}));
+							"index": "" + index,
+							"revIndex": "" +  (inputTitles.length - 1 - index),
+							"length": "" + inputTitles.length
+						};
+						if(name in opts.variables) {
+							return opts.variables[name];
+						} else {
+							return widget.getVariable(name,opts);
+						}
+					}
+				});
 				if(filtered.length && flatten) {
 					$tw.utils.each(filtered,function(value) {
 						results.push(value);

core/modules/filterrunprefixes/reduce.js

@@ -18,14 +18,24 @@ exports.reduce = function(operationSubFunction,options) {
 			var accumulator = "",
 				index = 0;
 			results.each(function(title) {
-				var list = operationSubFunction(options.wiki.makeTiddlerIterator([title]),widget.makeFakeWidgetWithVariables({
+				var list = operationSubFunction(options.wiki.makeTiddlerIterator([title]),{
-					"currentTiddler": "" + title,
+					getVariable: function(name,opts) {
-					"..currentTiddler": widget.getVariable("currentTiddler"),
+						opts = opts || {};
-					"index": "" + index,
+						opts.variables = {
-					"revIndex": "" +  (results.length - 1 - index),
+							"currentTiddler": "" + title,
-					"length": "" + results.length,
+							"..currentTiddler": widget.getVariable("currentTiddler"),
-					"accumulator": "" + accumulator
+							"index": "" + index,
-				}));
+							"revIndex": "" +  (results.length - 1 - index),
+							"length": "" + results.length,
+							"accumulator": "" + accumulator
+						};
+						if(name in opts.variables) {
+							return opts.variables[name];
+						} else {
+							return widget.getVariable(name,opts);
+						}
+					}
+				});
 				if(list.length > 0) {
 					accumulator = "" + list[0];
 				}

core/modules/filterrunprefixes/sort.js

@@ -25,10 +25,20 @@ exports.sort = function(operationSubFunction,options) {
 				indexes = new Array(inputTitles.length),
 				compareFn;
 			results.each(function(title) {
-				var key = operationSubFunction(options.wiki.makeTiddlerIterator([title]),widget.makeFakeWidgetWithVariables({
+				var key = operationSubFunction(options.wiki.makeTiddlerIterator([title]),{
-					"currentTiddler": "" + title,
+					getVariable: function(name,opts) {
-					"..currentTiddler": widget.getVariable("currentTiddler")
+						opts = opts || {};
-				}));
+						opts.variables = {
+							"currentTiddler": "" + title,
+							"..currentTiddler": widget.getVariable("currentTiddler")
+						};
+						if(name in opts.variables) {
+							return opts.variables[name];
+						} else {
+							return widget.getVariable(name,opts);
+						}
+					}
+				});
 				sortKeys.push(key[0] || "");
 			});
 			results.clear();

core/modules/filters.js

@@ -255,21 +255,19 @@ exports.compileFilter = function(filterString) {
 				var operands = [],
 					operatorFunction;
 				if(!operator.operator) {
-					// Use the "title" operator if no operator is specified
 					operatorFunction = filterOperators.title;
 				} else if(!filterOperators[operator.operator]) {
-					// Unknown operators treated as "[unknown]" - at run time we can distinguish between a custom operator and falling back to the default "field" operator
+					operatorFunction = filterOperators.field;
-					operatorFunction = filterOperators["[unknown]"];
 				} else {
-					// Use the operator function
 					operatorFunction = filterOperators[operator.operator];
 				}
+
 				$tw.utils.each(operator.operands,function(operand) {
 					if(operand.indirect) {
 						operand.value = self.getTextReference(operand.text,"",currTiddlerTitle);
 					} else if(operand.variable) {
 						var varTree = $tw.utils.parseFilterVariable(operand.text);
-						operand.value = widget.evaluateVariable(varTree.name,{params: varTree.params, source: source})[0] || "";
+						operand.value = widget.getVariable(varTree.name,{params:varTree.params,defaultValue: ""});
 					} else {
 						operand.value = operand.text;
 					}

core/modules/filters/encodings.js

@@ -16,22 +16,6 @@ Filter operator for applying decodeURIComponent() to each item.
 Export our filter functions
 */
 
-exports.decodebase64 = function(source,operator,options) {
-	var results = [];
-	source(function(tiddler,title) {
-		results.push($tw.utils.base64Decode(title));
-	});
-	return results;
-};
-
-exports.encodebase64 = function(source,operator,options) {
-	var results = [];
-	source(function(tiddler,title) {
-		results.push($tw.utils.base64Encode(title));
-	});
-	return results;
-};
-
 exports.decodeuricomponent = function(source,operator,options) {
 	var results = [];
 	source(function(tiddler,title) {
@@ -43,7 +27,7 @@ exports.decodeuricomponent = function(source,operator,options) {
 exports.encodeuricomponent = function(source,operator,options) {
 	var results = [];
 	source(function(tiddler,title) {
-		results.push($tw.utils.encodeURIComponentExtended(title));
+		results.push(encodeURIComponent(title));
 	});
 	return results;
 };

core/modules/filters/filter.js

@@ -20,10 +20,18 @@ exports.filter = function(source,operator,options) {
 		results = [],
 		target = operator.prefix !== "!";
 	source(function(tiddler,title) {
-		var list = filterFn.call(options.wiki,options.wiki.makeTiddlerIterator([title]),options.widget.makeFakeWidgetWithVariables({
+		var list = filterFn.call(options.wiki,options.wiki.makeTiddlerIterator([title]),{
-			"currentTiddler": "" + title,
+				getVariable: function(name) {
-			"..currentTiddler": options.widget.getVariable("currentTiddler","")
+					switch(name) {
-		}));
+						case "currentTiddler":
+							return "" + title;
+						case "..currentTiddler":
+							return options.widget.getVariable("currentTiddler");
+						default:
+							return options.widget.getVariable(name);
+					}
+				}
+			});
 		if((list.length > 0) === target) {
 			results.push(title);
 		}

core/modules/filters/function.js

@@ -1,32 +0,0 @@
-/*\
-title: $:/core/modules/filters/function.js
-type: application/javascript
-module-type: filteroperator
-
-Filter operator returning those input titles that are returned from a function
-
-\*/
-(function(){
-
-/*jslint node: true, browser: true */
-/*global $tw: false */
-"use strict";
-
-/*
-Export our filter function
-*/
-exports.function = function(source,operator,options) {
-	var functionName = operator.operands[0],
-		variableInfo = options.widget && options.widget.getVariableInfo && options.widget.getVariableInfo(functionName);
-	if(variableInfo && variableInfo.srcVariable && variableInfo.srcVariable.isFunctionDefinition) {
-		return options.widget.evaluateVariable(functionName,{params: operator.operands.slice(1), source: source});
-	}
-	// Return the input list if the function wasn't found
-	var results = [];
-	source(function(tiddler,title) {
-		results.push(title);
-	});
-	return results;
-};
-
-})();

core/modules/filters/is/variable.js

@@ -19,13 +19,13 @@ exports.variable = function(source,prefix,options) {
 	var results = [];
 	if(prefix === "!") {
 		source(function(tiddler,title) {
-			if(options.widget.getVariable(title) === undefined) {
+			if(!(title in options.widget.variables)) {
 				results.push(title);
 			}
 		});
 	} else {
 		source(function(tiddler,title) {
-			if(options.widget.getVariable(title) !== undefined) {
+			if(title in options.widget.variables) {
 				results.push(title);
 			}
 		});

core/modules/filters/json-ops.js

@@ -17,23 +17,9 @@ exports["jsonget"] = function(source,operator,options) {
 	source(function(tiddler,title) {
 		var data = $tw.utils.parseJSONSafe(title,title);
 		if(data) {
-			var items = getDataItemValueAsStrings(data,operator.operands);
+			var item = getDataItemValueAsString(data,operator.operands);
-			if(items !== undefined) {
-				results.push.apply(results,items);
-			}
-		}
-	});
-	return results;
-};
-
-exports["jsonextract"] = function(source,operator,options) {
-	var results = [];
-	source(function(tiddler,title) {
-		var data = $tw.utils.parseJSONSafe(title,title);
-		if(data) {
-			var item = getDataItem(data,operator.operands);
 			if(item !== undefined) {
-				results.push(JSON.stringify(item));
+				results.push(item);
 			}
 		}
 	});
@@ -45,9 +31,9 @@ exports["jsonindexes"] = function(source,operator,options) {
 	source(function(tiddler,title) {
 		var data = $tw.utils.parseJSONSafe(title,title);
 		if(data) {
-			var items = getDataItemKeysAsStrings(data,operator.operands);
+			var item = getDataItemKeysAsStrings(data,operator.operands);
-			if(items !== undefined) {
+			if(item !== undefined) {
-				results.push.apply(results,items);
+				results.push.apply(results,item);
 			}
 		}
 	});
@@ -71,11 +57,11 @@ exports["jsontype"] = function(source,operator,options) {
 /*
 Given a JSON data structure and an array of index strings, return an array of the string representation of the values at the end of the index chain, or "undefined" if any of the index strings are invalid
 */
-function getDataItemValueAsStrings(data,indexes) {
+function getDataItemValueAsString(data,indexes) {
 	// Get the item
 	var item = getDataItem(data,indexes);
-	// Return the item as a string list
+	// Return the item as a string
-	return convertDataItemValueToStrings(item);
+	return convertDataItemValueToString(item);
 }
 
 /*
@@ -91,34 +77,15 @@ function getDataItemKeysAsStrings(data,indexes) {
 /*
 Return an array of the string representation of the values of a data item, or "undefined" if the item is undefined
 */
-function convertDataItemValueToStrings(item) {
+function convertDataItemValueToString(item) {
 	// Return the item as a string
 	if(item === undefined) {
-		return undefined;
+		return item;
-	} else if(item === null) {
-		return ["null"]
-	} else if(typeof item === "object") {
-		var results = [],i,t;
-		if($tw.utils.isArray(item)) {
-			// Return all the items in arrays recursively
-			for(i=0; i<item.length; i++) {
-				t = convertDataItemValueToStrings(item[i])
-				if(t !== undefined) {
-					results.push.apply(results,t);
-				}
-			}
-		} else {
-			// Return all the values in objects recursively
-			$tw.utils.each(Object.keys(item).sort(),function(key) {
-				t = convertDataItemValueToStrings(item[key]);
-				if(t !== undefined) {
-					results.push.apply(results,t);
-				}
-			});
-		}
-		return results;
 	}
-	return [item.toString()];
+	if(typeof item === "object") {
+		return JSON.stringify(item);
+	}
+	return item.toString();
 }
 
 /*
@@ -176,11 +143,7 @@ function getDataItem(data,indexes) {
 	var item = data;
 	for(var i=0; i<indexes.length; i++) {
 		if(item !== undefined) {
-			if(item !== null && ["number","string","boolean"].indexOf(typeof item) === -1) {
+			item = item[indexes[i]];
-				item = item[indexes[i]];
-			} else {
-				item = undefined;
-			}
 		}
 	}
 	return item;

core/modules/filters/reduce.js

@@ -26,14 +26,26 @@ exports.reduce = function(source,operator,options) {
 		accumulator = operator.operands[1] || "";
 	for(var index=0; index<results.length; index++) {
 		var title = results[index],
-			list = filterFn.call(options.wiki,options.wiki.makeTiddlerIterator([title]),options.widget.makeFakeWidgetWithVariables({
+			list = filterFn.call(options.wiki,options.wiki.makeTiddlerIterator([title]),{
-				"currentTiddler": "" + title,
+				getVariable: function(name) {
-				"..currentTiddler": options.widget.getVariable("currentTiddler"),
+					switch(name) {
-				"accumulator": "" + accumulator,
+						case "currentTiddler":
-				"index": "" + index,
+							return "" + title;
-				"revIndex": "" + (results.length - 1 - index),
+						case "..currentTiddler":
-				"length": "" + results.length
+							return options.widget.getVariable("currentTiddler");
-			}));
+						case "accumulator":
+							return "" + accumulator;
+						case "index":
+							return "" + index;
+						case "revIndex":
+							return "" + (results.length - 1 - index);
+						case "length":
+							return "" + results.length;
+						default:
+							return options.widget.getVariable(name);
+					}
+				}
+			});
 		if(list.length > 0) {
 			accumulator = "" +  list[0];
 		}

core/modules/filters/sortsub.js

@@ -25,10 +25,18 @@ exports.sortsub = function(source,operator,options) {
 		inputTitles.push(title);
 		var r = filterFn.call(options.wiki,function(iterator) {
 			iterator(options.wiki.getTiddler(title),title);
-		},options.widget.makeFakeWidgetWithVariables({
+		},{
-			"currentTiddler": "" + title,
+			getVariable: function(name) {
-			"..currentTiddler": options.widget.getVariable("currentTiddler")
+				switch(name) {
-		}));
+					case "currentTiddler":
+						return "" + title;
+					case "..currentTiddler":
+						return options.widget.getVariable("currentTiddler");
+					default:
+						return options.widget.getVariable(name);
+				}
+			}
+		});
 		sortKeys.push(r[0] || "");
 	});
 	// Rather than sorting the titles array, we'll sort the indexes so that we can consult both arrays

core/modules/filters/strings.js

@@ -74,113 +74,6 @@ exports.join = makeStringReducingOperator(
 	},null
 );
 
-var dmp = require("$:/core/modules/utils/diff-match-patch/diff_match_patch.js");
-
-exports.levenshtein = makeStringBinaryOperator(
-	function(a,b) {
-		var dmpObject = new dmp.diff_match_patch(),
-			diffs = dmpObject.diff_main(a,b);
-		return [dmpObject.diff_levenshtein(diffs) + ""];
-	}
-);
-
-// these two functions are adapted from https://github.com/google/diff-match-patch/wiki/Line-or-Word-Diffs
-function diffLineWordMode(text1,text2,mode) {
-	var dmpObject = new dmp.diff_match_patch();
-	var a = diffPartsToChars(text1,text2,mode);
-	var lineText1 = a.chars1;
-	var lineText2 = a.chars2;
-	var lineArray = a.lineArray;
-	var diffs = dmpObject.diff_main(lineText1,lineText2,false);
-	dmpObject.diff_charsToLines_(diffs,lineArray);
-	return diffs;
-}
-
-function diffPartsToChars(text1,text2,mode) {
-	var lineArray = [];
-	var lineHash = {};
-	lineArray[0] = '';
-
-    function diff_linesToPartsMunge_(text,mode) {
-        var chars = '';
-        var lineStart = 0;
-        var lineEnd = -1;
-        var lineArrayLength = lineArray.length,
-            regexpResult;
-        var searchRegexp = /\W+/g;
-        while(lineEnd < text.length - 1) {
-	        if(mode === "words") {
-                regexpResult = searchRegexp.exec(text);
-                lineEnd = searchRegexp.lastIndex;
-                if(regexpResult === null) {
-                lineEnd = text.length;
-                }
-                lineEnd = --lineEnd;
-            } else {
-                lineEnd = text.indexOf('\n', lineStart);
-                if(lineEnd == -1) {
-                    lineEnd = text.length - 1;
-                }
-            }
-            var line = text.substring(lineStart, lineEnd + 1);
-
-            if(lineHash.hasOwnProperty ? lineHash.hasOwnProperty(line) : (lineHash[line] !== undefined)) {
-				chars += String.fromCharCode(lineHash[line]);
-            } else {
-                if (lineArrayLength == maxLines) {
-                  line = text.substring(lineStart);
-                  lineEnd = text.length;
-                }
-                chars += String.fromCharCode(lineArrayLength);
-                lineHash[line] = lineArrayLength;
-                lineArray[lineArrayLength++] = line;
-            }
-            lineStart = lineEnd + 1;
-        }
-        return chars;
-    }
-    var maxLines = 40000;
-    var chars1 = diff_linesToPartsMunge_(text1,mode);
-    maxLines = 65535;
-    var chars2 = diff_linesToPartsMunge_(text2,mode);
-    return {chars1: chars1, chars2: chars2, lineArray: lineArray};
-};
-
-exports.makepatches = function(source,operator,options) {
-	var dmpObject = new dmp.diff_match_patch(),
-		suffix = operator.suffix || "",
-		result = [];
-		
-		source(function(tiddler,title) {
-			var diffs, patches;
-			if(suffix === "lines" || suffix === "words") {
-				diffs = diffLineWordMode(title,operator.operand,suffix);
-				patches = dmpObject.patch_make(title,diffs);
-			} else {
-				patches = dmpObject.patch_make(title,operator.operand);
-			}
-			Array.prototype.push.apply(result,[dmpObject.patch_toText(patches)]);
-		});
-
-	return result;
-};
-
-exports.applypatches = makeStringBinaryOperator(
-	function(a,b) {
-		var dmpObject = new dmp.diff_match_patch(),
-			patches;
-		try {
-			patches = dmpObject.patch_fromText(b);
-		} catch(e) {
-		}
-		if(patches) {
-			return [dmpObject.patch_apply(patches,a)[0]];
-		} else {
-			return [a];
-		}
-	}
-);
-
 function makeStringBinaryOperator(fnCalc) {
 	return function(source,operator,options) {
 		var result = [];
@@ -291,4 +184,4 @@ exports.charcode = function(source,operator,options) {
 	return [chars.join("")];
 };
 
-})();
+})();

core/modules/filters/unknown.js

@@ -1,45 +0,0 @@
-/*\
-title: $:/core/modules/filters/unknown.js
-type: application/javascript
-module-type: filteroperator
-
-Filter operator for handling unknown filter operators.
-
-Not intended to be used directly by end users, hence the square brackets around the name.
-
-\*/
-(function(){
-
-/*jslint node: true, browser: true */
-/*global $tw: false */
-"use strict";
-
-var fieldFilterOperatorFn = require("$:/core/modules/filters/field.js").field;
-
-/*
-Export our filter function
-*/
-exports["[unknown]"] = function(source,operator,options) {
-	// Check for a user defined filter operator
-	if(operator.operator.charAt(0) === ".") {
-		var variableInfo = options.widget && options.widget.getVariableInfo && options.widget.getVariableInfo(operator.operator);
-		if(variableInfo && variableInfo.srcVariable && variableInfo.srcVariable.isFunctionDefinition) {
-			var list = options.widget.evaluateVariable(operator.operator,{params: operator.operands, source: source});
-			if(operator.prefix === "!") {
-				var results = [];
-				source(function(tiddler,title) {
-					if(list.indexOf(title) === -1) {
-						results.push(title);
-					}
-				});
-				return results;
-			} else {
-				return list;
-			}
-		}
-	}
-	// Otherwise, use the "field" operator
-	return fieldFilterOperatorFn(source,operator,options);
-};
-
-})();

core/modules/filters/variables.js

@@ -16,15 +16,9 @@ Filter operator for returning the names of the active variables
 Export our filter function
 */
 exports.variables = function(source,operator,options) {
-	var names = [],
+	var names = [];
-		widget = options.widget;
+	for(var variable in options.widget.variables) {
-	while(widget && !widget.hasOwnProperty("variables")) {
+		names.push(variable);
-		widget = widget.parentWidget;
-	}
-	if(widget && widget.variables) {
-		for(var variable in widget.variables) {
-			names.push(variable);
-		}
 	}
 	return names.sort();
 };

core/modules/indexers/backlinks-index.js

@@ -26,11 +26,23 @@ BacklinksIndexer.prototype.rebuild = function() {
 }
 
 BacklinksIndexer.prototype._getLinks = function(tiddler) {
-	var parser =  this.wiki.parseText(tiddler.fields.type, tiddler.fields.text, {});
+	var parser =  this.wiki.parseText(tiddler.fields.type,tiddler.fields.text,{});
-	if(parser) {
+	parser.tree = [{
-		return this.wiki.extractLinks(parser.tree);
+		type: "importvariables",
-	}
+		attributes: {
-	return [];
+			filter: {
+				name: "filter",
+				type: "string",
+				value: "[[$:/core/ui/PageMacros]] [all[shadows+tiddlers]tag[$:/tags/Macro]!has[draft.of]]"
+			}
+		},
+		isBlock: false,
+		children: parser.tree
+	}];
+	var widget = this.wiki.makeWidget(parser,{document: $tw.fakeDocument, parseAsInline: false, variables: {currentTiddler: tiddler.fields.title}});
+	var container = $tw.fakeDocument.createElement("div");
+	widget.render(container,null);
+	return this.wiki.extractLinksFromWidgetTree(widget);
 }
 
 BacklinksIndexer.prototype.update = function(updateDescriptor) {

core/modules/indexers/field-indexer.js

@@ -32,18 +32,18 @@ FieldIndexer.prototype.setMaxIndexedValueLength = function(length) {
 
 FieldIndexer.prototype.addIndexMethods = function() {
 	var self = this;
-	// get all tiddlers, including those overwrite shadow tiddlers
 	this.wiki.each.byField = function(name,value) {
-		var lookup = self.lookup(name,value);
+		var titles = self.wiki.allTitles(),
+			lookup = self.lookup(name,value);
 		return lookup && lookup.filter(function(title) {
-			return self.wiki.tiddlerExists(title)
+			return titles.indexOf(title) !== -1;
 		});
 	};
-	// get shadow tiddlers, including shadow tiddlers that is overwritten
 	this.wiki.eachShadow.byField = function(name,value) {
-		var lookup = self.lookup(name,value);
+		var titles = self.wiki.allShadowTitles(),
+			lookup = self.lookup(name,value);
 		return lookup && lookup.filter(function(title) {
-			return self.wiki.isShadowTiddler(title)
+			return titles.indexOf(title) !== -1;
 		});
 	};
 	this.wiki.eachTiddlerPlusShadows.byField = function(name,value) {

core/modules/parsers/audioparser.js

@@ -28,8 +28,6 @@ var AudioParser = function(type,text,options) {
 		element.attributes.src = {type: "string", value: "data:" + type + ";base64," + text};
 	}
 	this.tree = [element];
-	this.source = text;
-	this.type = type;
 };
 
 exports["audio/ogg"] = AudioParser;

core/modules/parsers/binaryparser.js

@@ -23,7 +23,7 @@ var BinaryParser = function(type,text,options) {
 		children: [{
 			type: "transclude",
 			attributes: {
-				"$tiddler": {type: "string", value: BINARY_WARNING_MESSAGE}
+				tiddler: {type: "string", value: BINARY_WARNING_MESSAGE}
 			}
 		}]
 	};
@@ -38,7 +38,7 @@ var BinaryParser = function(type,text,options) {
 		children: [{
 			type: "transclude",
 			attributes: {
-				"$tiddler": {type: "string", value: EXPORT_BUTTON_IMAGE}
+				tiddler: {type: "string", value: EXPORT_BUTTON_IMAGE}
 			}
 		}]
 	};
@@ -64,8 +64,6 @@ var BinaryParser = function(type,text,options) {
 		children: [warn, link]
 	}
 	this.tree = [element];
-	this.source = text;
-	this.type = type;
 };
 
 exports["application/octet-stream"] = BinaryParser;

core/modules/parsers/csvparser.js

@@ -13,11 +13,6 @@ The CSV text parser processes CSV files into a table wrapped in a scrollable wid
 "use strict";
 
 var CsvParser = function(type,text,options) {
-	// Special handler for tab-delimited files
-	if (type === 'text/tab-delimited-values' && !options.separator) {
-		options.separator = "\t";
-	}
-	
 	// Table framework
 	this.tree = [{
 		"type": "scrollable", "children": [{
@@ -29,35 +24,30 @@ var CsvParser = function(type,text,options) {
 		}]
 	}];
 	// Split the text into lines
-	var lines = $tw.utils.parseCsvString(text, options),
+	var lines = text.split(/\r?\n/mg),
 		tag = "th";
-	var maxColumns = 0;
-	$tw.utils.each(lines, function(columns) {
-		maxColumns = Math.max(columns.length, maxColumns);
-	});
-	
 	for(var line=0; line<lines.length; line++) {
-		var columns = lines[line];
+		var lineText = lines[line];
-		var row = {
+		if(lineText) {
-			"type": "element", "tag": "tr", "children": []
+			var row = {
-		};
+					"type": "element", "tag": "tr", "children": []
-		for(var column=0; column<maxColumns; column++) {
+				};
-			row.children.push({
+			var columns = lineText.split(",");
-				"type": "element", "tag": tag, "children": [{
+			for(var column=0; column<columns.length; column++) {
-					"type": "text",
+				row.children.push({
-					"text": columns[column] || ''
+						"type": "element", "tag": tag, "children": [{
-				}]
+							"type": "text",
-			});
+							"text": columns[column]
+						}]
+					});
+			}
+			tag = "td";
+			this.tree[0].children[0].children[0].children.push(row);
 		}
-		tag = "td";
-		this.tree[0].children[0].children[0].children.push(row);
 	}
-	this.source = text;
-	this.type = type;
 };
 
 exports["text/csv"] = CsvParser;
-exports["text/tab-delimited-values"] = CsvParser;
 
 })();
 

core/modules/parsers/htmlparser.js

@@ -29,8 +29,6 @@ var HtmlParser = function(type,text,options) {
 	if($tw.wiki.getTiddlerText("$:/config/HtmlParser/DisableSandbox","no") !== "yes") {
 		this.tree[0].attributes.sandbox = {type: "string", value: $tw.wiki.getTiddlerText("$:/config/HtmlParser/SandboxTokens","")};
 	}
-	this.source = text;
-	this.type = type;
 };
 
 exports["text/html"] = HtmlParser;

core/modules/parsers/imageparser.js

@@ -28,8 +28,6 @@ var ImageParser = function(type,text,options) {
 		}
 	}
 	this.tree = [element];
-	this.source = text;
-	this.type = type;
 };
 
 exports["image/svg+xml"] = ImageParser;

core/modules/parsers/parseutils.js

@@ -123,36 +123,6 @@ exports.parseStringLiteral = function(source,pos) {
 	}
 };
 
-/*
-Returns an array of {name:} with an optional "default" property. Options include:
-requireParenthesis: require the parameter definition to be wrapped in parenthesis
-*/
-exports.parseParameterDefinition = function(paramString,options) {
-	options = options || {};
-	if(options.requireParenthesis) {
-		var parenMatch = /^\s*\((.*)\)\s*$/g.exec(paramString);
-		if(!parenMatch) {
-			return [];
-		}
-		paramString = parenMatch[1];
-	}
-	var params = [],
-		reParam = /\s*([^:),\s]+)(?:\s*:\s*(?:"""([\s\S]*?)"""|"([^"]*)"|'([^']*)'|([^,"'\s]+)))?/mg,
-		paramMatch = reParam.exec(paramString);
-	while(paramMatch) {
-		// Save the parameter details
-		var paramInfo = {name: paramMatch[1]},
-			defaultValue = paramMatch[2] || paramMatch[3] || paramMatch[4] || paramMatch[5];
-		if(defaultValue !== undefined) {
-			paramInfo["default"] = defaultValue;
-		}
-		params.push(paramInfo);
-		// Look for the next parameter
-		paramMatch = reParam.exec(paramString);
-	}
-	return params;
-};
-
 exports.parseMacroParameters = function(node,source,pos) {
 	// Process parameters
 	var parameter = $tw.utils.parseMacroParameter(source,pos);
@@ -205,36 +175,7 @@ exports.parseMacroParameter = function(source,pos) {
 };
 
 /*
-Look for a macro invocation. Returns null if not found, or {type: "transclude", attributes:, start:, end:}
+Look for a macro invocation. Returns null if not found, or {type: "macrocall", name:, parameters:, start:, end:}
-*/
-exports.parseMacroInvocationAsTransclusion = function(source,pos) {
-	var node = $tw.utils.parseMacroInvocation(source,pos);
-	if(node) {
-		var positionalName = 0,
-			transclusion = {
-				type: "transclude",
-				start: node.start,
-				end: node.end
-			};
-		$tw.utils.addAttributeToParseTreeNode(transclusion,"$variable",node.name);
-		$tw.utils.each(node.params,function(param) {
-			var name = param.name;
-			if(name) {
-				if(name.charAt(0) === "$") {
-					name = "$" + name;
-				}
-				$tw.utils.addAttributeToParseTreeNode(transclusion,{name: name,type: "string", value: param.value, start: param.start, end: param.end});
-			} else {
-				$tw.utils.addAttributeToParseTreeNode(transclusion,{name: (positionalName++) + "",type: "string", value: param.value, start: param.start, end: param.end});
-			}
-		});
-		return transclusion;
-	}
-	return node;
-};
-
-/*
-Look for a macro invocation. Returns null if not found, or {type: "macrocall", name:, params:, start:, end:}
 */
 exports.parseMacroInvocation = function(source,pos) {
 	var node = {

core/modules/parsers/pdfparser.js

@@ -15,7 +15,7 @@ The PDF parser embeds a PDF viewer
 var ImageParser = function(type,text,options) {
 	var element = {
 			type: "element",
-			tag: "iframe",
+			tag: "embed",
 			attributes: {}
 		},
 		src;
@@ -25,8 +25,6 @@ var ImageParser = function(type,text,options) {
 		element.attributes.src = {type: "string", value: "data:application/pdf;base64," + text};
 	}
 	this.tree = [element];
-	this.source = text;
-	this.type = type;
 };
 
 exports["application/pdf"] = ImageParser;

core/modules/parsers/textparser.js

@@ -20,8 +20,6 @@ var TextParser = function(type,text,options) {
 			language: {type: "string", value: type}
 		}
 	}];
-	this.source = text;
-	this.type = type;
 };
 
 exports["text/plain"] = TextParser;

core/modules/parsers/videoparser.js

@@ -28,8 +28,6 @@ var VideoParser = function(type,text,options) {
 		element.attributes.src = {type: "string", value: "data:" + type + ";base64," + text};
 	}
 	this.tree = [element];
-	this.source = text;
-	this.type = type;
 };
 
 exports["video/ogg"] = VideoParser;

core/modules/parsers/wikiparser/rules/fnprocdef.js

@@ -1,97 +0,0 @@
-/*\
-title: $:/core/modules/parsers/wikiparser/rules/fnprocdef.js
-type: application/javascript
-module-type: wikirule
-
-Wiki pragma rule for function, procedure and widget definitions
-
-```
-\function name(param:defaultvalue,param2:defaultvalue)
-definition text
-\end
-
-\procedure name(param:defaultvalue,param2:defaultvalue)
-definition text
-\end
-
-\widget $mywidget(param:defaultvalue,param2:defaultvalue)
-definition text
-\end
-```
-
-\*/
-(function(){
-
-/*jslint node: true, browser: true */
-/*global $tw: false */
-"use strict";
-
-exports.name = "fnprocdef";
-exports.types = {pragma: true};
-
-/*
-Instantiate parse rule
-*/
-exports.init = function(parser) {
-	this.parser = parser;
-	// Regexp to match
-	this.matchRegExp = /^\\(function|procedure|widget)\s+([^(\s]+)\((\s*([^)]*))?\)(\s*\r?\n)?/mg;
-};
-
-/*
-Parse the most recent match
-*/
-exports.parse = function() {
-	// Move past the macro name and parameters
-	this.parser.pos = this.matchRegExp.lastIndex;
-	// Parse the parameters
-	var params = [];
-	if(this.match[3]) {
-		params = $tw.utils.parseParameterDefinition(this.match[4]);
-	}
-	// Is this a multiline definition?
-	var reEnd;
-	if(this.match[5]) {
-		// If so, the end of the body is marked with \end
-		reEnd = new RegExp("(\\r?\\n\\\\end[^\\S\\n\\r]*(?:" + $tw.utils.escapeRegExp(this.match[2]) + ")?(?:$|\\r?\\n))","mg");
-	} else {
-		// Otherwise, the end of the definition is marked by the end of the line
-		reEnd = /($|\r?\n)/mg;
-		// Move past any whitespace
-		this.parser.pos = $tw.utils.skipWhiteSpace(this.parser.source,this.parser.pos);
-	}
-	// Find the end of the definition
-	reEnd.lastIndex = this.parser.pos;
-	var text,
-		endMatch = reEnd.exec(this.parser.source);
-	if(endMatch) {
-		text = this.parser.source.substring(this.parser.pos,endMatch.index);
-		this.parser.pos = endMatch.index + endMatch[0].length;
-	} else {
-		// We didn't find the end of the definition, so we'll make it blank
-		text = "";
-	}
-	// Save the macro definition
-	var parseTreeNodes = [{
-		type: "set",
-		attributes: {},
-		children: [],
-		params: params
-	}];
-	$tw.utils.addAttributeToParseTreeNode(parseTreeNodes[0],"name",this.match[2]);
-	$tw.utils.addAttributeToParseTreeNode(parseTreeNodes[0],"value",text);
-	if(this.match[1] === "function") {
-		parseTreeNodes[0].isFunctionDefinition = true;
-	} else if(this.match[1] === "procedure") {
-		parseTreeNodes[0].isProcedureDefinition = true;
-	} else if(this.match[1] === "widget") {
-		parseTreeNodes[0].isWidgetDefinition = true;
-	}
-	if(this.parser.configTrimWhiteSpace) {
-		parseTreeNodes[0].configTrimWhiteSpace = true;
-	}
-	return parseTreeNodes;
-};
-
-})();
-	

core/modules/parsers/wikiparser/rules/html.js

@@ -93,6 +93,9 @@ exports.parseTag = function(source,pos,options) {
 		return null;
 	}
 	node.tag = token.match[1];
+	if(node.tag.slice(1).indexOf("$") !== -1) {
+		return null;
+	}
 	if(node.tag.charAt(0) === "$") {
 		node.type = node.tag.substr(1);
 	}

core/modules/parsers/wikiparser/rules/import.js

@@ -25,7 +25,7 @@ Instantiate parse rule
 exports.init = function(parser) {
 	this.parser = parser;
 	// Regexp to match
-	this.matchRegExp = /\\import[^\S\n]/mg;
+	this.matchRegExp = /^\\import[^\S\n]/mg;
 };
 
 /*

core/modules/parsers/wikiparser/rules/macrocallblock.js

@@ -27,7 +27,7 @@ exports.findNextMatch = function(startPos) {
 	var nextStart = startPos;
 	// Try parsing at all possible macrocall openers until we match
 	while((nextStart = this.parser.source.indexOf("<<",nextStart)) >= 0) {
-		var nextCall = $tw.utils.parseMacroInvocationAsTransclusion(this.parser.source,nextStart);
+		var nextCall = $tw.utils.parseMacroInvocation(this.parser.source,nextStart);
 		if(nextCall) {
 			var c = this.parser.source.charAt(nextCall.end);
 			// Ensure EOL after parsed macro

core/modules/parsers/wikiparser/rules/macrocallinline.js

@@ -27,7 +27,7 @@ exports.findNextMatch = function(startPos) {
 	var nextStart = startPos;
 	// Try parsing at all possible macrocall openers until we match
 	while((nextStart = this.parser.source.indexOf("<<",nextStart)) >= 0) {
-		this.nextCall = $tw.utils.parseMacroInvocationAsTransclusion(this.parser.source,nextStart);
+		this.nextCall = $tw.utils.parseMacroInvocation(this.parser.source,nextStart);
 		if(this.nextCall) {
 			return nextStart;
 		}

core/modules/parsers/wikiparser/rules/macrodef.js

@@ -27,7 +27,7 @@ Instantiate parse rule
 exports.init = function(parser) {
 	this.parser = parser;
 	// Regexp to match
-	this.matchRegExp = /\\define\s+([^(\s]+)\(\s*([^)]*)\)(\s*\r?\n)?/mg;
+	this.matchRegExp = /^\\define\s+([^(\s]+)\(\s*([^)]*)\)(\s*\r?\n)?/mg;
 };
 
 /*
@@ -58,7 +58,7 @@ exports.parse = function() {
 	var reEnd;
 	if(this.match[3]) {
 		// If so, the end of the body is marked with \end
-		reEnd = new RegExp("(\\r?\\n[^\\S\\n\\r]*\\\\end[^\\S\\n\\r]*(?:" + $tw.utils.escapeRegExp(this.match[1]) + ")?(?:$|\\r?\\n))","mg");
+		reEnd = /(\r?\n\\end[^\S\n\r]*(?:$|\r?\n))/mg;
 	} else {
 		// Otherwise, the end of the definition is marked by the end of the line
 		reEnd = /($|\r?\n)/mg;
@@ -77,16 +77,16 @@ exports.parse = function() {
 		text = "";
 	}
 	// Save the macro definition
-	var parseTreeNodes = [{
+	return [{
 		type: "set",
-		attributes: {},
+		attributes: {
+			name: {type: "string", value: this.match[1]},
+			value: {type: "string", value: text}
+		},
 		children: [],
 		params: params,
 		isMacroDefinition: true
 	}];
-	$tw.utils.addAttributeToParseTreeNode(parseTreeNodes[0],"name",this.match[1]);
-	$tw.utils.addAttributeToParseTreeNode(parseTreeNodes[0],"value",text);
-	return parseTreeNodes;
 };
 
 })();

core/modules/parsers/wikiparser/rules/parameters.js

@@ -1,60 +0,0 @@
-/*\
-title: $:/core/modules/parsers/wikiparser/rules/parameters.js
-type: application/javascript
-module-type: wikirule
-
-Wiki pragma rule for parameter definitions
-
-```
-\parameters(param:defaultvalue,param2:defaultvalue)
-definition text
-```
-
-\*/
-(function(){
-
-/*jslint node: true, browser: true */
-/*global $tw: false */
-"use strict";
-
-exports.name = "parameters";
-exports.types = {pragma: true};
-
-/*
-Instantiate parse rule
-*/
-exports.init = function(parser) {
-	this.parser = parser;
-	// Regexp to match
-	this.matchRegExp = /^\\parameters\s*\(([^)]*)\)\s*\r?\n/mg;
-};
-
-/*
-Parse the most recent match
-*/
-exports.parse = function() {
-	// Move past the macro name and parameters
-	this.parser.pos = this.matchRegExp.lastIndex;
-	// Parse the parameters
-	var params = $tw.utils.parseParameterDefinition(this.match[1]);
-	var attributes = Object.create(null),
-		orderedAttributes = [];
-	$tw.utils.each(params,function(param) {
-		var name = param.name;
-		// Parameter names starting with dollar must be escaped to double dollars for the parameters widget
-		if(name.charAt(0) === "$") {
-			name = "$" + name;
-		}
-		var attribute = {name: name, type: "string", value: param["default"] || ""};
-		attributes[name] = attribute;
-		orderedAttributes.push(attribute);
-	});
-	// Save the macro definition
-	return [{
-		type: "parameters",
-		attributes: attributes,
-		orderedAttributes: orderedAttributes
-	}];
-};
-
-})();

core/modules/parsers/wikiparser/rules/parsermode.js

@@ -1,68 +0,0 @@
-/*\
-title: $:/core/modules/parsers/wikiparser/rules/parsermode.js
-type: application/javascript
-module-type: wikirule
-
-Wiki pragma rule for parser mode specifications
-
-```
-\parsermode block
-\parsermode inline
-```
-
-\*/
-(function(){
-
-/*jslint node: true, browser: true */
-/*global $tw: false */
-"use strict";
-
-exports.name = "parsermode";
-exports.types = {pragma: true};
-
-/*
-Instantiate parse rule
-*/
-exports.init = function(parser) {
-	this.parser = parser;
-	// Regexp to match
-	this.matchRegExp = /\\parsermode[^\S\n]/mg;
-};
-
-/*
-Parse the most recent match
-*/
-exports.parse = function() {
-	// Move past the pragma invocation
-	this.parser.pos = this.matchRegExp.lastIndex;
-	// Parse whitespace delimited tokens terminated by a line break
-	var reMatch = /[^\S\n]*(\S+)|(\r?\n)/mg,
-		parserMode = undefined;
-	reMatch.lastIndex = this.parser.pos;
-	var match = reMatch.exec(this.parser.source);
-	while(match && match.index === this.parser.pos) {
-		this.parser.pos = reMatch.lastIndex;
-		// Exit if we've got the line break
-		if(match[2]) {
-			break;
-		}
-		// Process the token
-		if(match[1]) {
-			parserMode = match[1];
-		}
-		// Match the next token
-		match = reMatch.exec(this.parser.source);
-	}
-	// Process the tokens
-	if(parserMode !== undefined) {
-		if(parserMode === "block") {
-			this.parser.parseAsInline = false;
-		} else if(parserMode === "inline") {
-			this.parser.parseAsInline = true;
-		}
-	}
-	// No parse tree nodes to return
-	return [];
-};
-
-})();

core/modules/parsers/wikiparser/rules/rules.js

@@ -26,7 +26,7 @@ Instantiate parse rule
 exports.init = function(parser) {
 	this.parser = parser;
 	// Regexp to match
-	this.matchRegExp = /\\rules[^\S\n]/mg;
+	this.matchRegExp = /^\\rules[^\S\n]/mg;
 };
 
 /*

core/modules/parsers/wikiparser/rules/transcludeblock.js

@@ -23,7 +23,7 @@ exports.types = {block: true};
 exports.init = function(parser) {
 	this.parser = parser;
 	// Regexp to match
-	this.matchRegExp = /\{\{([^\{\}\|]*)(?:\|\|([^\|\{\}]+))?(?:\|([^\{\}]+))?\}\}(?:\r?\n|$)/mg;
+	this.matchRegExp = /\{\{([^\{\}\|]*)(?:\|\|([^\|\{\}]+))?\}\}(?:\r?\n|$)/mg;
 };
 
 exports.parse = function() {
@@ -31,22 +31,13 @@ exports.parse = function() {
 	this.parser.pos = this.matchRegExp.lastIndex;
 	// Get the match details
 	var template = $tw.utils.trim(this.match[2]),
-		textRef = $tw.utils.trim(this.match[1]),
+		textRef = $tw.utils.trim(this.match[1]);
-		params = this.match[3] ? this.match[3].split("|") : [];
 	// Prepare the transclude widget
 	var transcludeNode = {
 			type: "transclude",
 			attributes: {},
 			isBlock: true
 		};
-	$tw.utils.each(params,function(paramValue,index) {
-		var name = "" + index;
-		transcludeNode.attributes[name] = {
-			name: name,
-			type: "string",
-			value: paramValue
-		}
-	});
 	// Prepare the tiddler widget
 	var tr, targetTitle, targetField, targetIndex, tiddlerNode;
 	if(textRef) {
@@ -57,14 +48,14 @@ exports.parse = function() {
 		tiddlerNode = {
 			type: "tiddler",
 			attributes: {
-				tiddler: {name: "tiddler", type: "string", value: targetTitle}
+				tiddler: {type: "string", value: targetTitle}
 			},
 			isBlock: true,
 			children: [transcludeNode]
 		};
 	}
 	if(template) {
-		transcludeNode.attributes["$tiddler"] = {name: "$tiddler", type: "string", value: template};
+		transcludeNode.attributes.tiddler = {type: "string", value: template};
 		if(textRef) {
 			return [tiddlerNode];
 		} else {
@@ -72,12 +63,12 @@ exports.parse = function() {
 		}
 	} else {
 		if(textRef) {
-			transcludeNode.attributes["$tiddler"] = {name: "$tiddler", type: "string", value: targetTitle};
+			transcludeNode.attributes.tiddler = {type: "string", value: targetTitle};
 			if(targetField) {
-				transcludeNode.attributes["$field"] = {name: "$field", type: "string", value: targetField};
+				transcludeNode.attributes.field = {type: "string", value: targetField};
 			}
 			if(targetIndex) {
-				transcludeNode.attributes["$index"] = {name: "$index", type: "string", value: targetIndex};
+				transcludeNode.attributes.index = {type: "string", value: targetIndex};
 			}
 			return [tiddlerNode];
 		} else {

core/modules/parsers/wikiparser/rules/transcludeinline.js

@@ -23,7 +23,7 @@ exports.types = {inline: true};
 exports.init = function(parser) {
 	this.parser = parser;
 	// Regexp to match
-	this.matchRegExp = /\{\{([^\{\}\|]*)(?:\|\|([^\|\{\}]+))?(?:\|([^\{\}]+))?\}\}/mg;
+	this.matchRegExp = /\{\{([^\{\}\|]*)(?:\|\|([^\|\{\}]+))?\}\}/mg;
 };
 
 exports.parse = function() {
@@ -31,21 +31,12 @@ exports.parse = function() {
 	this.parser.pos = this.matchRegExp.lastIndex;
 	// Get the match details
 	var template = $tw.utils.trim(this.match[2]),
-		textRef = $tw.utils.trim(this.match[1]),
+		textRef = $tw.utils.trim(this.match[1]);
-		params = this.match[3] ? this.match[3].split("|") : [];
 	// Prepare the transclude widget
 	var transcludeNode = {
 			type: "transclude",
 			attributes: {}
 		};
-	$tw.utils.each(params,function(paramValue,index) {
-		var name = "" + index;
-		transcludeNode.attributes[name] = {
-			name: name,
-			type: "string",
-			value: paramValue
-		}
-	});
 	// Prepare the tiddler widget
 	var tr, targetTitle, targetField, targetIndex, tiddlerNode;
 	if(textRef) {
@@ -56,13 +47,13 @@ exports.parse = function() {
 		tiddlerNode = {
 			type: "tiddler",
 			attributes: {
-				tiddler: {name: "tiddler", type: "string", value: targetTitle}
+				tiddler: {type: "string", value: targetTitle}
 			},
 			children: [transcludeNode]
 		};
 	}
 	if(template) {
-		transcludeNode.attributes["$tiddler"] = {name: "$tiddler", type: "string", value: template};
+		transcludeNode.attributes.tiddler = {type: "string", value: template};
 		if(textRef) {
 			return [tiddlerNode];
 		} else {
@@ -70,12 +61,12 @@ exports.parse = function() {
 		}
 	} else {
 		if(textRef) {
-			transcludeNode.attributes["$tiddler"] = {name: "$tiddler", type: "string", value: targetTitle};
+			transcludeNode.attributes.tiddler = {type: "string", value: targetTitle};
 			if(targetField) {
-				transcludeNode.attributes["$field"] = {name: "$field", type: "string", value: targetField};
+				transcludeNode.attributes.field = {type: "string", value: targetField};
 			}
 			if(targetIndex) {
-				transcludeNode.attributes["$index"] = {name: "$index", type: "string", value: targetIndex};
+				transcludeNode.attributes.index = {type: "string", value: targetIndex};
 			}
 			return [tiddlerNode];
 		} else {

core/modules/parsers/wikiparser/rules/whitespace.js

@@ -26,7 +26,7 @@ Instantiate parse rule
 exports.init = function(parser) {
 	this.parser = parser;
 	// Regexp to match
-	this.matchRegExp = /\\whitespace[^\S\n]/mg;
+	this.matchRegExp = /^\\whitespace[^\S\n]/mg;
 };
 
 /*

core/modules/parsers/wikiparser/wikiparser.js

@@ -32,7 +32,6 @@ options: see below:
 	parseAsInline: true to parse text as inline instead of block
 	wiki: reference to wiki to use
 	_canonical_uri: optional URI of content if text is missing or empty
-	configTrimWhiteSpace: true to trim whitespace
 */
 var WikiParser = function(type,text,options) {
 	this.wiki = options.wiki;
@@ -47,9 +46,7 @@ var WikiParser = function(type,text,options) {
 	this.source = text || "";
 	this.sourceLength = this.source.length;
 	// Flag for ignoring whitespace
-	this.configTrimWhiteSpace = options.configTrimWhiteSpace !== undefined ? options.configTrimWhiteSpace : false;
+	this.configTrimWhiteSpace = false;
-	// Parser mode
-	this.parseAsInline = options.parseAsInline;
 	// Set current parse position
 	this.pos = 0;
 	// Start with empty output
@@ -86,7 +83,7 @@ var WikiParser = function(type,text,options) {
 	// Parse any pragmas
 	var topBranch = this.parsePragmas();
 	// Parse the text into inline runs or blocks
-	if(this.parseAsInline) {
+	if(options.parseAsInline) {
 		topBranch.push.apply(topBranch,this.parseInlineRun());
 	} else {
 		topBranch.push.apply(topBranch,this.parseBlocks());

core/modules/savers/beaker.js

@@ -0,0 +1,64 @@
+/*\
+title: $:/core/modules/savers/beaker.js
+type: application/javascript
+module-type: saver
+
+Saves files using the Beaker browser's (https://beakerbrowser.com) Dat protocol (https://datproject.org/)
+Compatible with beaker >= V0.7.2
+
+\*/
+(function(){
+
+/*jslint node: true, browser: true */
+/*global $tw: false */
+"use strict";
+
+/*
+Set up the saver
+*/
+var BeakerSaver = function(wiki) {
+	this.wiki = wiki;
+};
+
+BeakerSaver.prototype.save = function(text,method,callback) {
+	var dat = new DatArchive("" + window.location),
+		pathname = ("" + window.location.pathname).split("#")[0];
+	dat.stat(pathname).then(function(value) {
+		if(value.isDirectory()) {
+			pathname = pathname + "/index.html";
+		}
+		dat.writeFile(pathname,text,"utf8").then(function(value) {
+			callback(null);
+		},function(reason) {
+			callback("Beaker Saver Write Error: " + reason);
+		});
+	},function(reason) {
+		callback("Beaker Saver Stat Error: " + reason);
+	});
+	return true;
+};
+
+/*
+Information about this saver
+*/
+BeakerSaver.prototype.info = {
+	name: "beaker",
+	priority: 3000,
+	capabilities: ["save", "autosave"]
+};
+
+/*
+Static method that returns true if this saver is capable of working
+*/
+exports.canSave = function(wiki) {
+	return !!window.DatArchive && location.protocol==="dat:";
+};
+
+/*
+Create an instance of this saver
+*/
+exports.create = function(wiki) {
+	return new BeakerSaver(wiki);
+};
+
+})();

core/modules/savers/hyperdrive.js

@@ -0,0 +1,64 @@
+/*\
+title: $:/core/modules/savers/hyperdrive.js
+type: application/javascript
+module-type: saver
+
+Saves files using the Hyperdrive Protocol (https://hypercore-protocol.org/#hyperdrive) Beaker browser beta-1.0 and later (https://beakerbrowser.com)
+Compatible with beaker >= V1.0.0
+
+\*/
+(function(){
+
+/*jslint node: true, browser: true */
+/*global $tw: false */
+"use strict";
+
+/*
+Set up the saver
+*/
+var HyperdriveSaver = function(wiki) {
+	this.wiki = wiki;
+};
+
+HyperdriveSaver.prototype.save = function(text,method,callback) {
+	var dat = beaker.hyperdrive.drive("" + window.location),
+		pathname = ("" + window.location.pathname).split("#")[0];
+	dat.stat(pathname).then(function(value) {
+		if(value.isDirectory()) {
+			pathname = pathname + "/index.html";
+		}
+		dat.writeFile(pathname,text,"utf8").then(function(value) {
+			callback(null);
+		},function(reason) {
+			callback("Hyperdrive Saver Write Error: " + reason);
+		});
+	},function(reason) {
+		callback("Hyperdrive Saver Stat Error: " + reason);
+	});
+	return true;
+};
+
+/*
+Information about this saver
+*/
+HyperdriveSaver.prototype.info = {
+	name: "beaker-1.x",
+	priority: 3000,
+	capabilities: ["save", "autosave"]
+};
+
+/*
+Static method that returns true if this saver is capable of working
+*/
+exports.canSave = function(wiki) {
+	return !!window.beaker && !!beaker.hyperdrive && location.protocol==="hyper:";
+};
+
+/*
+Create an instance of this saver
+*/
+exports.create = function(wiki) {
+	return new HyperdriveSaver(wiki);
+};
+
+})();

core/modules/server/routes/get-status.js

@@ -21,7 +21,6 @@ exports.handler = function(request,response,state) {
 		username: state.authenticatedUsername || state.server.get("anon-username") || "",
 		anonymous: !state.authenticatedUsername,
 		read_only: !state.server.isAuthorized("writers",state.authenticatedUsername),
-		logout_is_available: false,
 		space: {
 			recipe: "default"
 		},

core/modules/server/routes/put-tiddler.js

@@ -30,16 +30,6 @@ exports.handler = function(request,response,state) {
 	if(fields.revision) {
 		delete fields.revision;
 	}
-	// If this is a skinny tiddler, it means the client never got the full
-	// version of the tiddler to edit. So we must preserve whatever text
-	// already exists on the server, or else we'll inadvertently delete it.
-	if(fields._is_skinny !== undefined) {
-		var tiddler = state.wiki.getTiddler(title);
-		if(tiddler) {
-			fields.text = tiddler.fields.text;
-		}
-		delete fields._is_skinny;
-	}
 	state.wiki.addTiddler(new $tw.Tiddler(fields,{title: title}));
 	var changeCount = state.wiki.getChangeCount(title).toString();
 	response.writeHead(204, "OK",{

core/modules/startup/rootwidget.js

@@ -87,6 +87,13 @@ exports.startup = function() {
 			}
 		});
 	}
+	// If we're being viewed on a data: URI then give instructions for how to save
+	if(document.location.protocol === "data:") {
+		$tw.rootWidget.dispatchEvent({
+			type: "tm-modal",
+			param: "$:/language/Modals/SaveInstructions"
+		});
+	}
 };
 
 })();

core/modules/startup/startup.js

@@ -121,11 +121,7 @@ exports.startup = function() {
 	});
 	// Set up the syncer object if we've got a syncadaptor
 	if($tw.syncadaptor) {
-		$tw.syncer = new $tw.Syncer({
+		$tw.syncer = new $tw.Syncer({wiki: $tw.wiki, syncadaptor: $tw.syncadaptor});
-			wiki: $tw.wiki,
-			syncadaptor: $tw.syncadaptor,
-			logging: $tw.wiki.getTiddlerText('$:/config/SyncLogging', "yes") === "yes"
-		});
 	}
 	// Setup the saver handler
 	$tw.saverHandler = new $tw.SaverHandler({

core/modules/storyviews/zoomin.js

@@ -17,10 +17,6 @@ var easing = "cubic-bezier(0.645, 0.045, 0.355, 1)"; // From http://easings.net/
 var ZoominListView = function(listWidget) {
 	var self = this;
 	this.listWidget = listWidget;
-	this.textNodeLogger = new $tw.utils.Logger("zoomin story river view", {
-		enable: true,
-		colour: 'red'
-	});
 	// Get the index of the tiddler that is at the top of the history
 	var history = this.listWidget.wiki.getTiddlerDataCached(this.listWidget.historyTitle,[]),
 		targetTiddler;
@@ -52,10 +48,7 @@ ZoominListView.prototype.navigateTo = function(historyInfo) {
 	var listItemWidget = this.listWidget.children[listElementIndex],
 		targetElement = listItemWidget.findFirstDomNode();
 	// Abandon if the list entry isn't a DOM element (it might be a text node)
-	if(!targetElement) {
+	if(!targetElement || targetElement.nodeType === Node.TEXT_NODE) {
-		return;
-	} else if (targetElement.nodeType === Node.TEXT_NODE) {
-		this.logTextNodeRoot(targetElement);
 		return;
 	}
 	// Make the new tiddler be position absolute and visible so that we can measure it
@@ -137,10 +130,7 @@ function findTitleDomNode(widget,targetClass) {
 ZoominListView.prototype.insert = function(widget) {
 	var targetElement = widget.findFirstDomNode();
 	// Abandon if the list entry isn't a DOM element (it might be a text node)
-	if(!targetElement) {
+	if(!targetElement || targetElement.nodeType === Node.TEXT_NODE) {
-		return;
-	} else if (targetElement.nodeType === Node.TEXT_NODE) {
-		this.logTextNodeRoot(targetElement);
 		return;
 	}
 	// Make the newly inserted node position absolute and hidden
@@ -183,21 +173,16 @@ ZoominListView.prototype.remove = function(widget) {
 	var toWidgetDomNode = toWidget && toWidget.findFirstDomNode();
 	// Set up the tiddler we're moving back in
 	if(toWidgetDomNode) {
-		if (toWidgetDomNode.nodeType === Node.TEXT_NODE) {
+		$tw.utils.addClass(toWidgetDomNode,"tc-storyview-zoomin-tiddler");
-			this.logTextNodeRoot(toWidgetDomNode);
+		$tw.utils.setStyle(toWidgetDomNode,[
-			toWidgetDomNode = null;
+			{display: "block"},
-		} else {
+			{transformOrigin: "50% 50%"},
-			$tw.utils.addClass(toWidgetDomNode,"tc-storyview-zoomin-tiddler");
+			{transform: "translateX(0px) translateY(0px) scale(10)"},
-			$tw.utils.setStyle(toWidgetDomNode,[
+			{transition: $tw.utils.roundTripPropertyName("transform") + " " + duration + "ms " + easing + ", opacity " + duration + "ms " + easing},
-				{display: "block"},
+			{opacity: "0"},
-				{transformOrigin: "50% 50%"},
+			{zIndex: "500"}
-				{transform: "translateX(0px) translateY(0px) scale(10)"},
+		]);
-				{transition: $tw.utils.roundTripPropertyName("transform") + " " + duration + "ms " + easing + ", opacity " + duration + "ms " + easing},
+		this.currentTiddlerDomNode = toWidgetDomNode;
-				{opacity: "0"},
-				{zIndex: "500"}
-			]);
-			this.currentTiddlerDomNode = toWidgetDomNode;
-		}
 	}
 	// Animate them both
 	// Force layout
@@ -221,10 +206,6 @@ ZoominListView.prototype.remove = function(widget) {
 	return true; // Indicate that we'll delete the DOM node
 };
 
-ZoominListView.prototype.logTextNodeRoot = function(node) {
-	this.textNodeLogger.log($tw.language.getString("Error/ZoominTextNode") + " " + node.textContent);
-};
-
 exports.zoomin = ZoominListView;
 
 })();

core/modules/syncer.js

@@ -402,7 +402,6 @@ Syncer.prototype.handleLazyLoadEvent = function(title) {
 			// Mark the tiddler as needing loading, and having already been lazily loaded
 			this.titlesToBeLoaded[title] = true;
 			this.titlesHaveBeenLazyLoaded[title] = true;
-			this.processTaskQueue();
 		}
 	}
 };

core/modules/utils/csv.js

@@ -12,113 +12,35 @@ A barebones CSV parser
 /*global $tw: false */
 "use strict";
 
-var QUOTE = '"';
-
-var getCellInfo = function(text, start, length, SEPARATOR) {
-	var isCellQuoted = text.charAt(start) === QUOTE;
-	var cellStart = isCellQuoted ? start + 1 : start;
-	
-	if (text.charAt(i) === SEPARATOR) {
-		return [cellStart, cellStart, false];
-	}
-	
-	for (var i = cellStart; i < length; i++) {
-		var cellCharacter = text.charAt(i);
-		var isEOL = cellCharacter === "\n" || cellCharacter === "\r";
-		
-		if (isEOL && !isCellQuoted) {
-			return [cellStart, i, false];
-			
-		} else if (cellCharacter === SEPARATOR && !isCellQuoted) {
-			return [cellStart, i, false];
-			
-		} else if (cellCharacter === QUOTE && isCellQuoted) {
-			var nextCharacter = i + 1 < length ? text.charAt(i + 1) : '';
-			if (nextCharacter !== QUOTE) {
-				return [cellStart, i, true];
-			} else {
-				i++;
-			}
-		}
-	}
-	
-	return [cellStart, i, isCellQuoted];
-}
-	
-exports.parseCsvString = function(text, options) {
-	if (!text) {
-		return [];
-	}
-	
-	options = options || {};
-	var SEPARATOR = options.separator || ",",
-		length = text.length,
-		rows = [],
-		nextRow = [];
-		
-	for (var i = 0; i < length; i++) {
-		var cellInfo = getCellInfo(text, i, length, SEPARATOR);
-		var cellText = text.substring(cellInfo[0], cellInfo[1]);
-		if (cellInfo[2]) {
-			cellText = cellText.replace(/""/g, '"');
-			cellInfo[1]++;
-		}
-		nextRow.push(cellText);
-		
-		i = cellInfo[1];
-		
-		var character = text.charAt(i);
-		var nextCharacter = i + 1 < length ? text.charAt(i + 1) : '';
-		
-		if (character === "\r" || character === "\n") {
-			// Edge case for empty rows
-			if (nextRow.length === 1 && nextRow[0] === '') {
-				nextRow.length = 0;
-			}
-			rows.push(nextRow);
-			nextRow = [];
-			
-			if (character === "\r") {
-				var nextCharacter = i + 1 < length ? text.charAt(i + 1) : '';
-				
-				if (nextCharacter === "\n") {
-					i++;
-				}
-			}
-		}
-	}
-	
-	// Special case if last cell in last row is an empty cell
-	if (text.charAt(length - 1) === SEPARATOR) {
-		nextRow.push("");
-	}
-	
-	rows.push(nextRow);
-	
-	return rows;
-}
-
 /*
 Parse a CSV string with a header row and return an array of hashmaps.
 */
 exports.parseCsvStringWithHeader = function(text,options) {
-	var csv = $tw.utils.parseCsvString(text, options);
+	options = options || {};
-	var headers = csv[0];
+	var separator = options.separator || ",",
-	
+		rows = text.split(/\r?\n/mg).map(function(row) {
-	csv = csv.slice(1);
+			return $tw.utils.trim(row);
-	for (var i = 0; i < csv.length; i++) {
+		}).filter(function(row) {
-		var row = csv[i];
+			return row !== "";
-		var rowObject = Object.create(null);
+		});
-
+	if(rows.length < 1) {
-		for(var columnIndex=0; columnIndex<headers.length; columnIndex++) {
+		return "Missing header row";
-			var columnName = headers[columnIndex];
-			if (columnName) {
-				rowObject[columnName] = $tw.utils.trim(row[columnIndex] || "");
-			}
-		}
-		csv[i] = rowObject;
 	}
-	return csv;
+	var headings = rows[0].split(separator),
+		results = [];
+	for(var row=1; row<rows.length; row++) {
+		var columns = rows[row].split(separator),
+			columnResult = Object.create(null);
+		if(columns.length !== headings.length) {
+			return "Malformed CSV row '" + rows[row] + "'";
+		}
+		for(var column=0; column<columns.length; column++) {
+			var columnName = headings[column];
+			columnResult[columnName] = $tw.utils.trim(columns[column] || "");
+		}
+		results.push(columnResult);
+	}
+	return results;
 }
 
 })();

core/modules/utils/dom/dom.js

@@ -12,8 +12,6 @@ Various static DOM-related utility functions.
 /*global $tw: false */
 "use strict";
 
-var Popup = require("$:/core/modules/utils/dom/popup.js");
-
 /*
 Determines whether element 'a' contains element 'b'
 Code thanks to John Resig, http://ejohn.org/blog/comparing-document-position/
@@ -28,24 +26,6 @@ exports.domMatchesSelector = function(node,selector) {
 	return node.matches ? node.matches(selector) : node.msMatchesSelector(selector);
 };
 
-/*
-Select text in a an input or textarea (setSelectionRange crashes on certain input types)
-*/
-exports.setSelectionRangeSafe = function(node,start,end,direction) {
-	try {
-		node.setSelectionRange(start,end,direction);
-	} catch(e) {
-		node.select();
-	}
-};
-
-/*
-Select the text in an input or textarea by position
-*/
-exports.setSelectionByPosition = function(node,selectFromStart,selectFromEnd) {
-	$tw.utils.setSelectionRangeSafe(node,selectFromStart,node.value.length - selectFromEnd);
-};
-
 exports.removeChildren = function(node) {
 	while(node.hasChildNodes()) {
 		node.removeChild(node.firstChild);
@@ -314,21 +294,8 @@ exports.collectDOMVariables = function(selectedNode,domNode,event) {
 		});
 		
 		if(selectedNode.offsetLeft) {
-			// Add variables with a (relative and absolute) popup coordinate string for the selected node
+			// Add a variable with a popup coordinate string for the selected node
-			var nodeRect = {
+			variables["tv-popup-coords"] = "(" + selectedNode.offsetLeft + "," + selectedNode.offsetTop +"," + selectedNode.offsetWidth + "," + selectedNode.offsetHeight + ")";
-				left: selectedNode.offsetLeft,
-				top: selectedNode.offsetTop,
-				width: selectedNode.offsetWidth,
-				height: selectedNode.offsetHeight
-			};
-			variables["tv-popup-coords"] = Popup.buildCoordinates(Popup.coordinatePrefix.csOffsetParent,nodeRect);
-
-			var absRect = $tw.utils.extend({}, nodeRect);
-			for (var currentNode = selectedNode.offsetParent; currentNode; currentNode = currentNode.offsetParent) {
-				absRect.left += currentNode.offsetLeft;
-				absRect.top += currentNode.offsetTop;
-			}
-			variables["tv-popup-abs-coords"] = Popup.buildCoordinates(Popup.coordinatePrefix.csAbsolute,absRect);
 
 			// Add variables for offset of selected node
 			variables["tv-selectednode-posx"] = selectedNode.offsetLeft.toString();

core/modules/utils/dom/modal.js

@@ -26,8 +26,6 @@ Display a modal dialogue
 	options: see below
 Options include:
 	downloadLink: Text of a big download link to include
-	event: widget event
-	variables: from event.paramObject
 */
 Modal.prototype.display = function(title,options) {
 	options = options || {};
@@ -211,10 +209,6 @@ Modal.prototype.display = function(title,options) {
 	headerWidgetNode.addEventListener("tm-close-tiddler",closeHandler,false);
 	bodyWidgetNode.addEventListener("tm-close-tiddler",closeHandler,false);
 	footerWidgetNode.addEventListener("tm-close-tiddler",closeHandler,false);
-	// Whether to close the modal dialog when the mask (area outside the modal) is clicked
-	if(tiddler.fields && (tiddler.fields["mask-closable"] === "yes" || tiddler.fields["mask-closable"] === "true")) {
-		modalBackdrop.addEventListener("click",closeHandler,false);
-	}
 	// Set the initial styles for the message
 	$tw.utils.setStyle(modalBackdrop,[
 		{opacity: "0"}

core/modules/utils/dom/popup.js

@@ -22,19 +22,6 @@ var Popup = function(options) {
 	this.popups = []; // Array of {title:,wiki:,domNode:} objects
 };
 
-/*
-Global regular expression for parsing the location of a popup.
-This is also used by the Reveal widget.
-*/
-exports.popupLocationRegExp = /^(@?)\((-?[0-9\.E]+),(-?[0-9\.E]+),(-?[0-9\.E]+),(-?[0-9\.E]+)\)$/
-
-/*
-Objekt containing the available prefixes for coordinates build with the `buildCoordinates` function:
- - csOffsetParent: Uses a coordinate system based on the offset parent (no prefix).
- - csAbsolute: Use an absolute coordinate system (prefix "@").
-*/
-exports.coordinatePrefix = { csOffsetParent: "", csAbsolute: "@" }
-
 /*
 Trigger a popup open or closed. Parameters are in a hashmap:
 	title: title of the tiddler where the popup details are stored
@@ -149,17 +136,8 @@ Popup.prototype.show = function(options) {
 			height: options.domNode.offsetHeight
 		};
 	}
-	if(options.absolute && options.domNode) {
+	var popupRect = "(" + rect.left + "," + rect.top + "," + 
-		// Walk the offsetParent chain and add the position of the offsetParents to make
+				rect.width + "," + rect.height + ")";
-		// the position absolute to the root node of the page.
-		var currentNode = options.domNode.offsetParent;
-		while(currentNode) {
-			rect.left += currentNode.offsetLeft;
-			rect.top += currentNode.offsetTop;
-			currentNode = currentNode.offsetParent;
-		}
-	}
-	var popupRect = exports.buildCoordinates(options.absolute?exports.coordinatePrefix.csAbsolute:exports.coordinatePrefix.csOffsetParent,rect);
 	if(options.noStateReference) {
 		options.wiki.setText(options.title,"text",undefined,popupRect);
 	} else {
@@ -194,54 +172,13 @@ Popup.prototype.cancel = function(level) {
 };
 
 /*
-Returns true if the specified title and text identifies an active popup.
+Returns true if the specified title and text identifies an active popup
-This function is safe to call, even if the popup class was not initialized.
 */
-exports.readPopupState = function(text) {
+Popup.prototype.readPopupState = function(text) {
-	return exports.popupLocationRegExp.test(text);
+	var popupLocationRegExp = /^\((-?[0-9\.E]+),(-?[0-9\.E]+),(-?[0-9\.E]+),(-?[0-9\.E]+)\)$/;
+	return popupLocationRegExp.test(text);
 };
 
-/*
-Parses a coordinate string in the format `(x,y,w,h)` or `@(x,y,z,h)` and returns
-an object containing the position, width and height. The absolute-Mark is boolean
-value that indicates the coordinate system of the coordinates. If they start with
-an `@`, `absolute` is set to true and the coordinates are relative to the root
-element. If the initial `@` is missing, they are relative to the offset parent
-element and `absoute` is false.
-This function is safe to call, even if the popup class was not initialized.
-*/
-exports.parseCoordinates = function(coordinates) {
-	var match = exports.popupLocationRegExp.exec(coordinates);
-	if(match) {
-		return {
-			absolute: (match[1] === "@"),
-			left: parseFloat(match[2]),
-			top: parseFloat(match[3]),
-			width: parseFloat(match[4]),
-			height: parseFloat(match[5])
-		};
-	} else {
-		return false;
-	}
-}
-
-/*
-Builds a coordinate string from a coordinate system identifier and an object
-containing the left, top, width and height values.
-Use constants defined in coordinatePrefix to specify a coordinate system.
-If one of the parameters is invalid for building a coordinate string `(0,0,0,0)`
-will be returned.
-This function is safe to call, even if the popup class was not initialized.
-*/
-exports.buildCoordinates = function(prefix,position) {
-	var coord = prefix + "(" + position.left + "," + position.top + "," + position.width + "," + position.height + ")";
-	if (exports.popupLocationRegExp.test(coord)) {
-		return coord;
-	} else {
-		return "(0,0,0,0)";
-	}
-}
-
 exports.Popup = Popup;
 
 })();

core/modules/utils/filesystem.js

@@ -228,7 +228,7 @@ exports.generateTiddlerFileInfo = function(tiddler,options) {
 			hasUnsafeFields = hasUnsafeFields || /[\x00-\x1F]/mg.test(value);
 			hasUnsafeFields = hasUnsafeFields || ($tw.utils.trim(value) !== value);
 		}
-		hasUnsafeFields = hasUnsafeFields || /:|#/mg.test(fieldName);
+		hasUnsafeFields = hasUnsafeFields || /:/mg.test(fieldName);
 	});
 	// Check for field values 
 	if(hasUnsafeFields) {
@@ -238,7 +238,7 @@ exports.generateTiddlerFileInfo = function(tiddler,options) {
 	} else {
 		// Save as a .tid or a text/binary file plus a .meta file
 		var tiddlerType = tiddler.fields.type || "text/vnd.tiddlywiki";
-		if(tiddlerType === "text/vnd.tiddlywiki" || tiddler.hasField("_canonical_uri")) {
+		if(tiddlerType === "text/vnd.tiddlywiki") {
 			// Save as a .tid file
 			fileInfo.type = "application/x-tiddler";
 			fileInfo.hasMetaFile = false;
@@ -393,7 +393,7 @@ exports.generateTiddlerFilepath = function(title,options) {
 	} while(fs.existsSync(fullPath));
 	// If the last write failed with an error, or if path does not start with:
 	//	the resolved options.directory, the resolved wikiPath directory, the wikiTiddlersPath directory, 
-	//	or the 'originalpath' directory, then $tw.utils.encodeURIComponentExtended() and resolve to tiddler directory.
+	//	or the 'originalpath' directory, then encodeURIComponent() and resolve to tiddler directory.
 	var writePath = $tw.hooks.invokeHook("th-make-tiddler-path",fullPath,fullPath),
 		encode = (options.fileInfo || {writeError: false}).writeError == true;
 	if(!encode) {
@@ -403,7 +403,7 @@ exports.generateTiddlerFilepath = function(title,options) {
 			writePath.indexOf(path.resolve($tw.boot.wikiTiddlersPath,originalpath)) == 0 );
 		}
 	if(encode) {
-		writePath = path.resolve(directory,$tw.utils.encodeURIComponentExtended(fullPath));
+		writePath = path.resolve(directory,encodeURIComponent(fullPath));
 	}
 	// Return the full path to the file
 	return writePath;

core/modules/utils/linked-list.js

@@ -15,11 +15,10 @@ function LinkedList() {
 
 LinkedList.prototype.clear = function() {
 	// LinkedList performs the duty of both the head and tail node
-	this.next = new LLMap();
+	this.next = Object.create(null);
-	this.prev = new LLMap();
+	this.prev = Object.create(null);
-	// Linked list head initially points to itself
+	this.first = undefined;
-	this.next.set(null, null);
+	this.last = undefined;
-	this.prev.set(null, null);
 	this.length = 0;
 };
 
@@ -42,29 +41,28 @@ Push behaves like array.push and accepts multiple string arguments. But it also
 accepts a single array argument too, to be consistent with its other methods.
 */
 LinkedList.prototype.push = function(/* values */) {
-	var i, values = arguments;
+	var values = arguments;
 	if($tw.utils.isArray(values[0])) {
 		values = values[0];
 	}
-	for(i = 0; i < values.length; i++) {
+	for(var i = 0; i < values.length; i++) {
 		_assertString(values[i]);
 	}
-	for(i = 0; i < values.length; i++) {
+	for(var i = 0; i < values.length; i++) {
 		_linkToEnd(this,values[i]);
 	}
 	return this.length;
 };
 
 LinkedList.prototype.pushTop = function(value) {
-	var t;
 	if($tw.utils.isArray(value)) {
-		for (t=0; t<value.length; t++) {
+		for (var t=0; t<value.length; t++) {
 			_assertString(value[t]);
 		}
-		for(t=0; t<value.length; t++) {
+		for(var t=0; t<value.length; t++) {
 			_removeOne(this,value[t]);
 		}
-		for(t=0; t<value.length; t++) {
+		for(var t=0; t<value.length; t++) {
 			_linkToEnd(this,value[t]);
 		}
 	} else {
@@ -76,11 +74,11 @@ LinkedList.prototype.pushTop = function(value) {
 
 LinkedList.prototype.each = function(callback) {
 	var visits = Object.create(null),
-		value = this.next.get(null);
+		value = this.first;
-	while(value !== null) {
+	while(value !== undefined) {
 		callback(value);
-		var next = this.next.get(value);
+		var next = this.next[value];
-		if(Array.isArray(next)) {
+		if(typeof next === "object") {
 			var i = visits[value] || 0;
 			visits[value] = i+1;
 			value = next[i];
@@ -107,79 +105,91 @@ LinkedList.prototype.makeTiddlerIterator = function(wiki) {
 };
 
 function _removeOne(list,value) {
-	var nextEntry = list.next.get(value);
+	var prevEntry = list.prev[value],
-	if(nextEntry === undefined) {
+		nextEntry = list.next[value],
-		return;
-	}
-	var prevEntry = list.prev.get(value),
 		prev = prevEntry,
-		next = nextEntry,
+		next = nextEntry;
-		ref;
+	if(typeof nextEntry === "object") {
-	if(Array.isArray(nextEntry)) {
 		next = nextEntry[0];
 		prev = prevEntry[0];
 	}
 	// Relink preceding element.
-	ref = list.next.get(prev);
+	if(list.first === value) {
-	if(Array.isArray(ref)) {
+		list.first = next
-		var i = ref.indexOf(value);
+	} else if(prev !== undefined) {
-		ref[i] = next;
+		if(typeof list.next[prev] === "object") {
+			if(next === undefined) {
+				// Must have been last, and 'i' would be last element.
+				list.next[prev].pop();
+			} else {
+				var i = list.next[prev].indexOf(value);
+				list.next[prev][i] = next;
+			}
+		} else {
+			list.next[prev] = next;
+		}
 	} else {
-		list.next.set(prev,next);
+		return;
 	}
-
 	// Now relink following element
-	ref = list.prev.get(next);
+	// Check "next !== undefined" rather than "list.last === value" because
-	if(Array.isArray(ref)) {
+	// we need to know if the FIRST value is the last in the list, not the last.
-		var i = ref.indexOf(value);
+	if(next !== undefined) {
-		ref[i] = prev;
+		if(typeof list.prev[next] === "object") {
+			if(prev === undefined) {
+				// Must have been first, and 'i' would be 0.
+				list.prev[next].shift();
+			} else {
+				var i = list.prev[next].indexOf(value);
+				list.prev[next][i] = prev;
+			}
+		} else {
+			list.prev[next] = prev;
+		}
 	} else {
-		list.prev.set(next,prev);
+		list.last = prev;
 	}
-
 	// Delink actual value. If it uses arrays, just remove first entries.
-	if(Array.isArray(nextEntry) && nextEntry.length > 1) {
+	if(typeof nextEntry === "object") {
 		nextEntry.shift();
 		prevEntry.shift();
 	} else {
-		list.next.set(value,undefined);
+		list.next[value] = undefined;
-		list.prev.set(value,undefined);
+		list.prev[value] = undefined;
 	}
 	list.length -= 1;
 };
 
 // Sticks the given node onto the end of the list.
 function _linkToEnd(list,value) {
-	var old = list.next.get(value);
+	if(list.first === undefined) {
-	var last = list.prev.get(null);
+		list.first = value;
-	// Does it already exists?
-	if(old !== undefined) {
-		if(!Array.isArray(old)) {
-			old = [old];
-			list.next.set(value,old);
-			list.prev.set(value,[list.prev.get(value)]);
-		}
-		old.push(null);
-		list.prev.get(value).push(last);
 	} else {
-		list.next.set(value,null);
+		// Does it already exists?
-		list.prev.set(value,last);
+		if(list.first === value || list.prev[value] !== undefined) {
-	}
+			if(typeof list.next[value] === "string") {
-	// Make the old last point to this new one.
+				list.next[value] = [list.next[value]];
-	if(value !== last) {
+				list.prev[value] = [list.prev[value]];
-		var array = list.next.get(last);
+			} else if(typeof list.next[value] === "undefined") {
-		if(Array.isArray(array)) {
+				// list.next[value] must be undefined.
-			array[array.length-1] = value;
+				// Special case. List already has 1 value. It's at the end.
+				list.next[value] = [];
+				list.prev[value] = [list.prev[value]];
+			}
+			list.prev[value].push(list.last);
+			// We do NOT append a new value onto "next" list. Iteration will
+			// figure out it must point to End-of-List on its own.
 		} else {
-			list.next.set(last,value);
+			list.prev[value] = list.last;
+		}
+		// Make the old last point to this new one.
+		if(typeof list.next[list.last] === "object") {
+			list.next[list.last].push(value);
+		} else {
+			list.next[list.last] = value;
 		}
-		list.prev.set(null,value);
-	} else {
-		// Edge case, the pushed value was already the last value.
-		// The second-to-last nextPtr for that value must point to itself now.
-		var array = list.next.get(last);
-		array[array.length-2] = value;
 	}
+	list.last = value;
 	list.length += 1;
 };
 
@@ -189,20 +199,6 @@ function _assertString(value) {
 	}
 };
 
-var LLMap = function() {
-	this.map = Object.create(null);
-};
-
-// Just a wrapper so our object map can also accept null.
-LLMap.prototype = {
-	set: function(key,val) {
-		(key === null) ? (this.null = val) : (this.map[key] = val);
-	},
-	get: function(key) {
-		return (key === null) ? this.null : this.map[key];
-	}
-};
-
 exports.LinkedList = LinkedList;
 
 })();

core/modules/utils/utils.js

@@ -354,9 +354,6 @@ exports.formatDateString = function(date,template) {
 	var result = "",
 		t = template,
 		matches = [
-			[/^TIMESTAMP/, function() {
-				return date.getTime();
-			}],
 			[/^0hh12/, function() {
 				return $tw.utils.pad($tw.utils.getHours12(date));
 			}],
@@ -685,19 +682,9 @@ exports.escapeRegExp = function(s) {
     return s.replace(/[\-\/\\\^\$\*\+\?\.\(\)\|\[\]\{\}]/g, '\\$&');
 };
 
-/*
-Extended version of encodeURIComponent that encodes additional characters including
-those that are illegal within filepaths on various platforms including Windows
-*/
-exports.encodeURIComponentExtended = function(s) {
-	return encodeURIComponent(s).replace(/[!'()*]/g,function(c) {
-		return "%" + c.charCodeAt(0).toString(16).toUpperCase();
-	});
-};
-
 // Checks whether a link target is external, i.e. not a tiddler title
 exports.isLinkExternal = function(to) {
-	var externalRegExp = /^(?:file|http|https|mailto|ftp|irc|news|obsidian|data|skype):[^\s<>{}\[\]`|"\\^]+(?:\/|\b)/i;
+	var externalRegExp = /^(?:file|http|https|mailto|ftp|irc|news|data|skype):[^\s<>{}\[\]`|"\\^]+(?:\/|\b)/i;
 	return externalRegExp.test(to);
 };
 

core/modules/widgets/action-popup.js

@@ -14,8 +14,6 @@ Action widget to trigger a popup.
 
 var Widget = require("$:/core/modules/widgets/widget.js").widget;
 
-var Popup = require("$:/core/modules/utils/dom/popup.js");
-
 var ActionPopupWidget = function(parseTreeNode,options) {
 	this.initialise(parseTreeNode,options);
 };
@@ -59,20 +57,20 @@ Invoke the action associated with this widget
 */
 ActionPopupWidget.prototype.invokeAction = function(triggeringWidget,event) {
 	// Trigger the popup
-	var coordinates = Popup.parseCoordinates(this.actionCoords || "");
+	var popupLocationRegExp = /^\((-?[0-9\.E]+),(-?[0-9\.E]+),(-?[0-9\.E]+),(-?[0-9\.E]+)\)$/,
-	if(coordinates) {
+		match = popupLocationRegExp.exec(this.actionCoords || "");
+	if(match) {
 		$tw.popup.triggerPopup({
 			domNode: null,
 			domNodeRect: {
-				left: coordinates.left,
+				left: parseFloat(match[1]),
-				top: coordinates.top,
+				top: parseFloat(match[2]),
-				width: coordinates.width,
+				width: parseFloat(match[3]),
-				height: coordinates.height
+				height: parseFloat(match[4])
 			},
 			title: this.actionState,
 			wiki: this.wiki,
-			floating: this.floating,
+			floating: this.floating
-			absolute: coordinates.absolute
 		});
 	} else {
 		$tw.popup.cancel(0);

core/modules/widgets/button.js

@@ -14,8 +14,6 @@ Button widget
 
 var Widget = require("$:/core/modules/widgets/widget.js").widget;
 
-var Popup = require("$:/core/modules/utils/dom/popup.js");
-
 var ButtonWidget = function(parseTreeNode,options) {
 	this.initialise(parseTreeNode,options);
 };
@@ -149,7 +147,7 @@ ButtonWidget.prototype.isSelected = function() {
 
 ButtonWidget.prototype.isPoppedUp = function() {
 	var tiddler = this.popupTitle ? this.wiki.getTiddler(this.popupTitle) : this.wiki.getTiddler(this.popup);
-	var result = tiddler && tiddler.fields.text ? Popup.readPopupState(tiddler.fields.text) : false;
+	var result = tiddler && tiddler.fields.text ? $tw.popup.readPopupState(tiddler.fields.text) : false;
 	return result;
 };
 
@@ -175,7 +173,6 @@ ButtonWidget.prototype.triggerPopup = function(event) {
 	if(this.popupTitle) {
 		$tw.popup.triggerPopup({
 			domNode: this.domNodes[0],
-			absolute: (this.popupAbsCoords === "yes"),
 			title: this.popupTitle,
 			wiki: this.wiki,
 			noStateReference: true
@@ -183,7 +180,6 @@ ButtonWidget.prototype.triggerPopup = function(event) {
 	} else {
 		$tw.popup.triggerPopup({
 			domNode: this.domNodes[0],
-			absolute: (this.popupAbsCoords === "yes"),
 			title: this.popup,
 			wiki: this.wiki
 		});
@@ -227,7 +223,6 @@ ButtonWidget.prototype.execute = function() {
 	this.setField = this.getAttribute("setField");
 	this.setIndex = this.getAttribute("setIndex");
 	this.popupTitle = this.getAttribute("popupTitle");
-	this.popupAbsCoords = this.getAttribute("popupAbsCoords", "no");
 	this.tabIndex = this.getAttribute("tabindex");
 	this.isDisabled = this.getAttribute("disabled","no");
 	// Make child widgets
@@ -257,7 +252,7 @@ Selectively refreshes the widget if needed. Returns true if the widget or any of
 */
 ButtonWidget.prototype.refresh = function(changedTiddlers) {
 	var changedAttributes = this.computeAttributes();
-	if(changedAttributes.actions || changedAttributes.to || changedAttributes.message || changedAttributes.param || changedAttributes.set || changedAttributes.setTo || changedAttributes.popup || changedAttributes.hover || changedAttributes.selectedClass || changedAttributes.style || changedAttributes.dragFilter || changedAttributes.dragTiddler || (this.set && changedTiddlers[this.set]) || (this.popup && changedTiddlers[this.popup]) || (this.popupTitle && changedTiddlers[this.popupTitle]) || changedAttributes.popupAbsCoords || changedAttributes.setTitle || changedAttributes.setField || changedAttributes.setIndex || changedAttributes.popupTitle || changedAttributes.disabled || changedAttributes["default"]) {
+	if(changedAttributes.actions || changedAttributes.to || changedAttributes.message || changedAttributes.param || changedAttributes.set || changedAttributes.setTo || changedAttributes.popup || changedAttributes.hover || changedAttributes.selectedClass || changedAttributes.style || changedAttributes.dragFilter || changedAttributes.dragTiddler || (this.set && changedTiddlers[this.set]) || (this.popup && changedTiddlers[this.popup]) || (this.popupTitle && changedTiddlers[this.popupTitle]) || changedAttributes.setTitle || changedAttributes.setField || changedAttributes.setIndex || changedAttributes.popupTitle || changedAttributes.disabled || changedAttributes["default"]) {
 		this.refreshSelf();
 		return true;
 	} else if(changedAttributes["class"]) {

core/modules/widgets/dropzone.js

@@ -232,34 +232,12 @@ DropZoneWidget.prototype.handleDropEvent  = function(event) {
 };
 
 DropZoneWidget.prototype.handlePasteEvent  = function(event) {
-	var self = this;
+	var self = this,
-	var	readFileCallback = function(tiddlerFieldsArray) {
+		readFileCallback = function(tiddlerFieldsArray) {
 			self.readFileCallback(tiddlerFieldsArray);
 		};
-	var getItem = function(type) {
-			type = type || "text/plain";
-			return function(str) {
-				// Use the deserializer specified if any
-				if(self.dropzoneDeserializer) {
-					tiddlerFields = self.wiki.deserializeTiddlers(null,str,{title: self.wiki.generateNewTitle("Untitled " + type)},{deserializer:self.dropzoneDeserializer});
-					if(tiddlerFields && tiddlerFields.length) {
-						readFileCallback(tiddlerFields);
-					}
-				} else {
-					tiddlerFields = {
-						title: self.wiki.generateNewTitle("Untitled " + type),
-						text: str,
-						type: type
-					};
-					if($tw.log.IMPORT) {
-						console.log("Importing string '" + str + "', type: '" + type + "'");
-					}
-					readFileCallback([tiddlerFields]);
-				}
-			}
-		};
 	// Let the browser handle it if we're in a textarea or input box
-	if(["TEXTAREA","INPUT"].indexOf(event.target.tagName) == -1 && !event.target.isContentEditable && !event.twEditor) {
+	if(["TEXTAREA","INPUT"].indexOf(event.target.tagName) == -1 && !event.target.isContentEditable) {
 		var self = this,
 			items = event.clipboardData.items;
 		// Enumerate the clipboard items
@@ -273,10 +251,27 @@ DropZoneWidget.prototype.handlePasteEvent  = function(event) {
 				});
 			} else if(item.kind === "string") {
 				// Create tiddlers from string items
-				var tiddlerFields;
+				var tiddlerFields,
-				// It's important to give getAsString a closure with the right type
+					type = item.type;
-				// So it can be added to the import queue
+				item.getAsString(function(str) {
-				item.getAsString(getItem(item.type));
+					// Use the deserializer specified if any
+					if(self.dropzoneDeserializer) {
+						tiddlerFields = self.wiki.deserializeTiddlers(null,str,{title: self.wiki.generateNewTitle("Untitled")},{deserializer:self.dropzoneDeserializer});
+						if(tiddlerFields && tiddlerFields.length) {
+							readFileCallback(tiddlerFields);
+						}
+					} else {
+						tiddlerFields = {
+							title: self.wiki.generateNewTitle("Untitled"),
+							text: str,
+							type: type
+						};
+						if($tw.log.IMPORT) {
+							console.log("Importing string '" + str + "', type: '" + type + "'");
+						}
+						readFileCallback([tiddlerFields]);
+					}
+				});
 			}
 		}
 		// Tell the browser that we've handled the paste

core/modules/widgets/element.js

@@ -34,10 +34,6 @@ ElementWidget.prototype.render = function(parent,nextSibling) {
 	if($tw.config.htmlUnsafeElements.indexOf(this.tag) !== -1) {
 		this.tag = "safe-" + this.tag;
 	}
-	// Restrict tag name to digits, letts and dashes
-	this.tag = this.tag.replace(/[^0-9a-zA-Z\-]/mg,"");
-	// Default to a span
-	this.tag = this.tag || "span";
 	// Adjust headings by the current base level
 	var headingLevel = ["h1","h2","h3","h4","h5","h6"].indexOf(this.tag);
 	if(headingLevel !== -1) {

core/modules/widgets/fill.js

@@ -1,30 +0,0 @@
-/*\
-title: $:/core/modules/widgets/fill.js
-type: application/javascript
-module-type: widget
-
-Sub-widget used by the transclude widget for specifying values for slots within transcluded content. It doesn't do anything by itself because the transclude widget only ever deals with the parse tree nodes, and doesn't instantiate the widget itself
-
-\*/
-(function(){
-
-/*jslint node: true, browser: true */
-/*global $tw: false */
-"use strict";
-
-var Widget = require("$:/core/modules/widgets/widget.js").widget;
-
-var FillWidget = function(parseTreeNode,options) {
-	// Initialise
-	this.initialise(parseTreeNode,options);
-};
-
-/*
-Inherit from the base widget class
-*/
-FillWidget.prototype = new Widget();
-
-exports.fill = FillWidget;
-
-})();
-	

core/modules/widgets/genesis.js

@@ -42,16 +42,10 @@ Compute the internal state of the widget
 GenesisWidget.prototype.execute = function() {
 	var self = this;
 	// Collect attributes
-	this.genesisType = this.getAttribute("$type");
+	this.genesisType = this.getAttribute("$type","element");
 	this.genesisRemappable = this.getAttribute("$remappable","yes") === "yes";
 	this.genesisNames = this.getAttribute("$names","");
 	this.genesisValues = this.getAttribute("$values","");
-	this.genesisIsBlock = this.getAttribute("$mode",this.parseTreeNode.isBlock && "block") === "block";
-	// Do not create a child widget if the $type attribute is missing or blank
-	if(!this.genesisType) {
-		this.makeChildWidgets(this.parseTreeNode.children);
-		return;
-	}
 	// Construct parse tree
 	var isElementWidget = this.genesisType.charAt(0) !== "$",
 		nodeType = isElementWidget ? "element" : this.genesisType.substr(1),
@@ -61,7 +55,6 @@ GenesisWidget.prototype.execute = function() {
 		tag: nodeTag,
 		attributes: {},
 		orderedAttributes: [],
-		isBlock: this.genesisIsBlock,
 		children: this.parseTreeNode.children || [],
 		isNotRemappable: !this.genesisRemappable
 	}];

core/modules/widgets/importvariables.js

@@ -52,44 +52,38 @@ ImportVariablesWidget.prototype.execute = function(tiddlerList) {
 		var parser = widgetPointer.wiki.parseTiddler(title,{parseAsInline:true});
 		if(parser) {
 			var parseTreeNode = parser.tree[0];
-			while(parseTreeNode && ["setvariable","set","parameters"].indexOf(parseTreeNode.type) !== -1) {
+			while(parseTreeNode && parseTreeNode.type === "set") {
 				var node = {
 					type: "set",
 					attributes: parseTreeNode.attributes,
 					params: parseTreeNode.params,
-					isMacroDefinition: parseTreeNode.isMacroDefinition,
+					isMacroDefinition: parseTreeNode.isMacroDefinition
-					isFunctionDefinition: parseTreeNode.isFunctionDefinition,
-					isProcedureDefinition: parseTreeNode.isProcedureDefinition,
-					isWidgetDefinition: parseTreeNode.isWidgetDefinition,
-					configTrimWhiteSpace: parseTreeNode.configTrimWhiteSpace
 				};
-				if(parseTreeNode.type === "set" || parseTreeNode.type === "setvariable") {
+				if (parseTreeNode.isMacroDefinition) {
-					if(parseTreeNode.isMacroDefinition || parseTreeNode.isProcedureDefinition || parseTreeNode.isWidgetDefinition || parseTreeNode.isFunctionDefinition) {
+					// Macro definitions can be folded into
-						// Macro definitions can be folded into
+					// current widget instead of adding
-						// current widget instead of adding
+					// another link to the chain.
-						// another link to the chain.
+					var widget = widgetPointer.makeChildWidget(node);
-						var widget = widgetPointer.makeChildWidget(node);
+					widget.computeAttributes();
-						widget.computeAttributes();
+					widget.execute();
-						widget.execute();
+					// We SHALLOW copy over all variables
-						// We SHALLOW copy over all variables
+					// in widget. We can't use
-						// in widget. We can't use
+					// $tw.utils.assign, because that copies
-						// $tw.utils.assign, because that copies
+					// up the prototype chain, which we
-						// up the prototype chain, which we
+					// don't want.
-						// don't want.
+					$tw.utils.each(Object.keys(widget.variables), function(key) {
-						$tw.utils.each(Object.keys(widget.variables), function(key) {
+						widgetPointer.variables[key] = widget.variables[key];
-							widgetPointer.variables[key] = widget.variables[key];
+					});
-						});
+				} else {
-					} else {
+					widgetPointer.children = [widgetPointer.makeChildWidget(node)];
-						widgetPointer.children = [widgetPointer.makeChildWidget(node)];
+					// No more regenerating children for
-						// No more regenerating children for
+					// this widget. If it needs to refresh,
-						// this widget. If it needs to refresh,
+					// it'll do so along with the the whole
-						// it'll do so along with the the whole
+					// importvariable tree.
-						// importvariable tree.
+					if (widgetPointer != this) {
-						if (widgetPointer != this) {
+						widgetPointer.makeChildWidgets = function(){};
-							widgetPointer.makeChildWidgets = function(){};
-						}
-						widgetPointer = widgetPointer.children[0];
 					}
+					widgetPointer = widgetPointer.children[0];
 				}
 				parseTreeNode = parseTreeNode.children && parseTreeNode.children[0];
 			}

core/modules/widgets/let.js

@@ -53,9 +53,7 @@ LetWidget.prototype.computeAttributes = function() {
 			name = attribute.name;
 		// Now that it's prepped, we're allowed to look this variable up
 		// when defining later variables
-		if(value !== undefined) {
+		self.currentValueFor[name] = value;
-			self.currentValueFor[name] = value;
-		}
 	});
 	// Run through again, setting variables and looking for differences
 	$tw.utils.each(this.currentValueFor,function(value,name) {

core/modules/widgets/link.js

@@ -97,8 +97,8 @@ LinkWidget.prototype.renderLink = function(parent,nextSibling) {
 		// Expand the tv-wikilink-template variable to construct the href
 		var wikiLinkTemplateMacro = this.getVariable("tv-wikilink-template"),
 			wikiLinkTemplate = wikiLinkTemplateMacro ? wikiLinkTemplateMacro.trim() : "#$uri_encoded$";
-		wikiLinkText = $tw.utils.replaceString(wikiLinkTemplate,"$uri_encoded$",$tw.utils.encodeURIComponentExtended(this.to));
+		wikiLinkText = $tw.utils.replaceString(wikiLinkTemplate,"$uri_encoded$",encodeURIComponent(this.to));
-		wikiLinkText = $tw.utils.replaceString(wikiLinkText,"$uri_doubleencoded$",$tw.utils.encodeURIComponentExtended($tw.utils.encodeURIComponentExtended(this.to)));
+		wikiLinkText = $tw.utils.replaceString(wikiLinkText,"$uri_doubleencoded$",encodeURIComponent(encodeURIComponent(this.to)));
 	}
 	// Override with the value of tv-get-export-link if defined
 	wikiLinkText = this.getVariable("tv-get-export-link",{params: [{name: "to",value: this.to}],defaultValue: wikiLinkText});

core/modules/widgets/macrocall.js

@@ -37,7 +37,7 @@ MacroCallWidget.prototype.render = function(parent,nextSibling) {
 Compute the internal state of the widget
 */
 MacroCallWidget.prototype.execute = function() {
-	this.macroName = this.parseTreeNode.name || this.getAttribute("$name"),
+	// Get the parse type if specified
 	this.parseType = this.getAttribute("$type","text/vnd.tiddlywiki");
 	this.renderOutput = this.getAttribute("$output","text/html");
 	// Merge together the parameters specified in the parse tree with the specified attributes
@@ -47,26 +47,49 @@ MacroCallWidget.prototype.execute = function() {
 			params.push({name: name, value: attribute});
 		}
 	});
-	// Make a transclude widget
+	// Get the macro value
-	var positionalName = 0,
+	var macroName = this.parseTreeNode.name || this.getAttribute("$name"),
-		parseTreeNodes = [{
+		variableInfo = this.getVariableInfo(macroName,{params: params}),
-			type: "transclude",
+		text = variableInfo.text,
-			isBlock: this.parseTreeNode.isBlock
+		parseTreeNodes;
-		}];
+	// Are we rendering to HTML?
-	$tw.utils.addAttributeToParseTreeNode(parseTreeNodes[0],"$variable",this.macroName);
+	if(this.renderOutput === "text/html") {
-	$tw.utils.addAttributeToParseTreeNode(parseTreeNodes[0],"$type",this.parseType);
+		// If so we'll return the parsed macro
-	$tw.utils.addAttributeToParseTreeNode(parseTreeNodes[0],"$output",this.renderOutput);
+		// Check if we've already cached parsing this macro
-	$tw.utils.each(params,function(param) {
+		var mode = this.parseTreeNode.isBlock ? "blockParser" : "inlineParser",
-		var name = param.name;
+			parser;
-		if(name) {
+		if(variableInfo.srcVariable && variableInfo.srcVariable[mode]) {
-			if(name.charAt(0) === "$") {
+			parser = variableInfo.srcVariable[mode];
-				name = "$" + name;
-			}
-			$tw.utils.addAttributeToParseTreeNode(parseTreeNodes[0],name,param.value);
 		} else {
-			$tw.utils.addAttributeToParseTreeNode(parseTreeNodes[0],(positionalName++) + "",param.value);
+			parser = this.wiki.parseText(this.parseType,text,
+								{parseAsInline: !this.parseTreeNode.isBlock});
+			if(variableInfo.isCacheable && variableInfo.srcVariable) {
+				variableInfo.srcVariable[mode] = parser;
+			}
 		}
-	});
+		var parseTreeNodes = parser ? parser.tree : [];
+		// Wrap the parse tree in a vars widget assigning the parameters to variables named "__paramname__"
+		var attributes = {};
+		$tw.utils.each(variableInfo.params,function(param) {
+			var name = "__" + param.name + "__";
+			attributes[name] = {
+				name: name,
+				type: "string",
+				value: param.value
+			};
+		});
+		parseTreeNodes = [{
+			type: "vars",
+			attributes: attributes,
+			children: parseTreeNodes
+		}];
+	} else if(this.renderOutput === "text/raw") {
+		parseTreeNodes = [{type: "text", text: text}];
+	} else {
+		// Otherwise, we'll render the text
+		var plainText = this.wiki.renderText("text/plain",this.parseType,text,{parentWidget: this});
+		parseTreeNodes = [{type: "text", text: plainText}];
+	}
 	// Construct the child widgets
 	this.makeChildWidgets(parseTreeNodes);
 };

core/modules/widgets/messagecatcher.js

@@ -82,7 +82,7 @@ MessageCatcherWidget.prototype.render = function(parent,nextSibling) {
 		}
 	});
 	// Render children
-	this.renderChildren(parent,nextSibling);
+	this.renderChildren(parent,null);
 };
 
 /*

core/modules/widgets/navigator.js

@@ -227,7 +227,10 @@ NavigatorWidget.prototype.handleDeleteTiddlerEvent = function(event) {
 		originalTitle = tiddler ? tiddler.fields["draft.of"] : "",
 		originalTiddler = originalTitle ? this.wiki.getTiddler(originalTitle) : undefined,
 		confirmationTitle,
-		win = event.event && event.event.view ? event.event.view : window;
+	    	win = event.event && event.event.view ? event.event.view : window;
+	if(!tiddler) {
+		return false;
+	}
 	// Check if the tiddler we're deleting is in draft mode
 	if(originalTitle) {
 		// If so, we'll prompt for confirmation referencing the original tiddler
@@ -237,7 +240,7 @@ NavigatorWidget.prototype.handleDeleteTiddlerEvent = function(event) {
 		confirmationTitle = title;
 	}
 	// Seek confirmation
-	if(((originalTitle && this.wiki.getTiddler(originalTitle)) || (tiddler && ((tiddler.fields.text || "") !== ""))) && !win.confirm($tw.language.getString(
+	if((this.wiki.getTiddler(originalTitle) || (tiddler.fields.text || "") !== "") && !win.confirm($tw.language.getString(
 				"ConfirmDeleteTiddler",
 				{variables:
 					{title: confirmationTitle}
@@ -254,10 +257,8 @@ NavigatorWidget.prototype.handleDeleteTiddlerEvent = function(event) {
 		this.removeTitleFromStory(storyList,originalTitle);
 	}
 	// Invoke the hook function and delete this tiddler
-	if(tiddler) {
+	$tw.hooks.invokeHook("th-deleting-tiddler",tiddler);
-		$tw.hooks.invokeHook("th-deleting-tiddler",tiddler);
+	this.wiki.deleteTiddler(title);
-		this.wiki.deleteTiddler(title);	
-	}
 	// Remove the closed tiddler from the story
 	this.removeTitleFromStory(storyList,title);
 	this.saveStoryList(storyList);
@@ -499,8 +500,7 @@ NavigatorWidget.prototype.handleImportTiddlersEvent = function(event) {
 	// Get the tiddlers
 	var tiddlers = $tw.utils.parseJSONSafe(event.param,[]);
 	// Get the current $:/Import tiddler
-	var paramObject = event.paramObject || {},
+	var importTitle = event.importTitle ? event.importTitle : IMPORT_TITLE,
-		importTitle = event.importTitle || paramObject.importTitle || IMPORT_TITLE,
 		importTiddler = this.wiki.getTiddler(importTitle),
 		importData = this.wiki.getTiddlerData(importTitle,{}),
 		newFields = new Object({
@@ -541,7 +541,7 @@ NavigatorWidget.prototype.handleImportTiddlersEvent = function(event) {
 	newFields.text = JSON.stringify(importData,null,$tw.config.preferences.jsonSpaces);
 	this.wiki.addTiddler(new $tw.Tiddler(importTiddler,newFields));
 	// Update the story and history details
-	var autoOpenOnImport = event.autoOpenOnImport || paramObject.autoOpenOnImport || this.getVariable("tv-auto-open-on-import");
+	var autoOpenOnImport = event.autoOpenOnImport ? event.autoOpenOnImport : this.getVariable("tv-auto-open-on-import");  
 	if(autoOpenOnImport !== "no") {
 		var storyList = this.getStoryList(),
 			history = [];

core/modules/widgets/parameters.js

@@ -1,96 +0,0 @@
-/*\
-title: $:/core/modules/widgets/parameters.js
-type: application/javascript
-module-type: widget
-
-Widget for definition of transclusion parameters
-
-\*/
-(function(){
-
-/*jslint node: true, browser: true */
-/*global $tw: false */
-"use strict";
-
-var Widget = require("$:/core/modules/widgets/widget.js").widget,
-	TranscludeWidget = require("$:/core/modules/widgets/transclude.js").transclude;
-
-var ParametersWidget = function(parseTreeNode,options) {
-	// Initialise
-	this.initialise(parseTreeNode,options);
-};
-
-/*
-Inherit from the base widget class
-*/
-ParametersWidget.prototype = new Widget();
-
-/*
-Render this widget into the DOM
-*/
-ParametersWidget.prototype.render = function(parent,nextSibling) {
-	// Call the constructor
-	Widget.call(this);
-	this.parentDomNode = parent;
-	this.computeAttributes();
-	this.execute();
-	this.renderChildren(parent,nextSibling);
-};
-
-/*
-Compute the internal state of the widget
-*/
-ParametersWidget.prototype.execute = function() {
-	var self = this;
-	this.parametersDepth = Math.max(parseInt(this.getAttribute("$depth","1"),10) || 1,1);
-	// Find the parent transclusions
-	var pointer = this.parentWidget,
-		depth = this.parametersDepth;
-	while(pointer) {
-		if(pointer instanceof TranscludeWidget) {
-			depth--;
-			if(depth <= 0) {
-				break;
-			}
-		}
-		pointer = pointer.parentWidget;
-	}
-	// Process each parameter
-	if(pointer instanceof TranscludeWidget) {
-		// Get the value for each defined parameter
-		$tw.utils.each($tw.utils.getOrderedAttributesFromParseTreeNode(self.parseTreeNode),function(attr,index) {
-			var name = attr.name;
-			// If the attribute name starts with $$ then reduce to a single dollar
-			if(name.substr(0,2) === "$$") {
-				name = name.substr(1);
-			}
-			var value = pointer.getTransclusionParameter(name,index,self.getAttribute(attr.name,""));
-			self.setVariable(name,value);
-		});
-		// Assign any metaparameters
-		$tw.utils.each(pointer.getTransclusionMetaParameters(),function(getValue,name) {
-			var variableName = self.getAttribute("$" + name);
-			if(variableName) {
-				self.setVariable(variableName,getValue(name));
-			}
-		});
-	}
-	// Construct the child widgets
-	this.makeChildWidgets();
-};
-
-/*
-Refresh the widget by ensuring our attributes are up to date
-*/
-ParametersWidget.prototype.refresh = function(changedTiddlers) {
-	var changedAttributes = this.computeAttributes();
-	if(Object.keys(changedAttributes).length) {
-		this.refreshSelf();
-		return true;
-	}
-	return this.refreshChildren(changedTiddlers);
-};
-
-exports.parameters = ParametersWidget;
-
-})();

core/modules/widgets/reveal.js

@@ -14,8 +14,6 @@ Reveal widget
 
 var Widget = require("$:/core/modules/widgets/widget.js").widget;
 
-var Popup = require("$:/core/modules/utils/dom/popup.js");
-
 var RevealWidget = function(parseTreeNode,options) {
 	this.initialise(parseTreeNode,options);
 };
@@ -96,13 +94,6 @@ RevealWidget.prototype.positionPopup = function(domNode) {
 		left = Math.max(0,left);
 		top = Math.max(0,top);
 	}
-	if (this.popup.absolute) {
-		// Traverse the offsetParent chain and correct the offset to make it relative to the parent node.
-		for (var offsetParentDomNode = domNode.offsetParent; offsetParentDomNode; offsetParentDomNode = offsetParentDomNode.offsetParent) {
-			left -= offsetParentDomNode.offsetLeft;
-			top -= offsetParentDomNode.offsetTop;
-		}
-	}
 	domNode.style.left = left + "px";
 	domNode.style.top = top + "px";
 };
@@ -192,11 +183,19 @@ RevealWidget.prototype.compareStateText = function(state) {
 };
 
 RevealWidget.prototype.readPopupState = function(state) {
-	this.popup = Popup.parseCoordinates(state);
+	var popupLocationRegExp = /^\((-?[0-9\.E]+),(-?[0-9\.E]+),(-?[0-9\.E]+),(-?[0-9\.E]+)\)$/,
+		match = popupLocationRegExp.exec(state);
 	// Check if the state matches the location regexp
-	if(this.popup) {
+	if(match) {
 		// If so, we're open
 		this.isOpen = true;
+		// Get the location
+		this.popup = {
+			left: parseFloat(match[1]),
+			top: parseFloat(match[2]),
+			width: parseFloat(match[3]),
+			height: parseFloat(match[4])
+		};
 	} else {
 		// If not, we're closed
 		this.isOpen = false;

core/modules/widgets/select.js

@@ -42,9 +42,6 @@ SelectWidget.prototype.render = function(parent,nextSibling) {
 	this.execute();
 	this.renderChildren(parent,nextSibling);
 	this.setSelectValue();
-	if(this.selectFocus == "yes") {
-		this.getSelectDomNode().focus();
-	}
 	$tw.utils.addEventListeners(this.getSelectDomNode(),[
 		{name: "change", handlerObject: this, handlerMethod: "handleChangeEvent"}
 	]);
@@ -146,7 +143,6 @@ SelectWidget.prototype.execute = function() {
 	this.selectMultiple = this.getAttribute("multiple", false);
 	this.selectSize = this.getAttribute("size");
 	this.selectTooltip = this.getAttribute("tooltip");
-	this.selectFocus = this.getAttribute("focus");
 	// Make the child widgets
 	var selectNode = {
 		type: "element",

core/modules/widgets/setvariable.js

@@ -48,17 +48,7 @@ SetWidget.prototype.execute = function() {
 	this.setValue = this.getAttribute("value");
 	this.setEmptyValue = this.getAttribute("emptyValue");
 	// Set context variable
-	if(this.parseTreeNode.isMacroDefinition) {
+	this.setVariable(this.setName,this.getValue(),this.parseTreeNode.params,!!this.parseTreeNode.isMacroDefinition);
-		this.setVariable(this.setName,this.getValue(),this.parseTreeNode.params,true);
-	} else if(this.parseTreeNode.isFunctionDefinition) {
-		this.setVariable(this.setName,this.getValue(),this.parseTreeNode.params,undefined,{isFunctionDefinition: true});
-	} else if(this.parseTreeNode.isProcedureDefinition) {
-		this.setVariable(this.setName,this.getValue(),this.parseTreeNode.params,undefined,{isProcedureDefinition: true, configTrimWhiteSpace: this.parseTreeNode.configTrimWhiteSpace});
-	} else if(this.parseTreeNode.isWidgetDefinition) {
-		this.setVariable(this.setName,this.getValue(),this.parseTreeNode.params,undefined,{isWidgetDefinition: true, configTrimWhiteSpace: this.parseTreeNode.configTrimWhiteSpace});
-	} else {
-		this.setVariable(this.setName,this.getValue());
-	}
 	// Construct the child widgets
 	this.makeChildWidgets();
 };

core/modules/widgets/slot.js

@@ -1,82 +0,0 @@
-/*\
-title: $:/core/modules/widgets/slot.js
-type: application/javascript
-module-type: widget
-
-Widget for definition of slots within transcluded content. The values provided by the translusion are passed to the slot.
-
-\*/
-(function(){
-
-/*jslint node: true, browser: true */
-/*global $tw: false */
-"use strict";
-
-var Widget = require("$:/core/modules/widgets/widget.js").widget,
-	TranscludeWidget = require("$:/core/modules/widgets/transclude.js").transclude;
-
-var SlotWidget = function(parseTreeNode,options) {
-	// Initialise
-	this.initialise(parseTreeNode,options);
-};
-
-/*
-Inherit from the base widget class
-*/
-SlotWidget.prototype = new Widget();
-
-/*
-Render this widget into the DOM
-*/
-SlotWidget.prototype.render = function(parent,nextSibling) {
-	// Call the constructor
-	Widget.call(this);
-	this.parentDomNode = parent;
-	this.computeAttributes();
-	this.execute();
-	this.renderChildren(parent,nextSibling);
-};
-
-/*
-Compute the internal state of the widget
-*/
-SlotWidget.prototype.execute = function() {
-	var self = this;
-	this.slotName = this.getAttribute("$name");
-	this.slotDepth = parseInt(this.getAttribute("$depth","1"),10) || 1;
-	// Find the parent transclusions
-	var pointer = this.parentWidget,
-		depth = this.slotDepth;
-	while(pointer) {
-		if(pointer instanceof TranscludeWidget) {
-			depth--;
-			if(depth <= 0) {
-				break;
-			}
-		}
-		pointer = pointer.parentWidget;
-	}
-	var parseTreeNodes = [{type: "text", attributes: {text: {type: "string", value: "Missing slot reference!"}}}];
-	if(pointer instanceof TranscludeWidget) {
-		// Get the parse tree nodes comprising the slot contents
-		parseTreeNodes = pointer.getTransclusionSlotFill(this.slotName,this.parseTreeNode.children);
-	}
-	// Construct the child widgets
-	this.makeChildWidgets(parseTreeNodes);
-};
-
-/*
-Refresh the widget by ensuring our attributes are up to date
-*/
-SlotWidget.prototype.refresh = function(changedTiddlers) {
-	var changedAttributes = this.computeAttributes();
-	if(changedAttributes["$name"] || changedAttributes["$depth"]) {
-		this.refreshSelf();
-		return true;
-	}
-	return this.refreshChildren(changedTiddlers);
-};
-
-exports.slot = SlotWidget;
-
-})();

core/modules/widgets/transclude.js

@@ -37,349 +37,46 @@ TranscludeWidget.prototype.render = function(parent,nextSibling) {
 Compute the internal state of the widget
 */
 TranscludeWidget.prototype.execute = function() {
-	// Get our attributes, string parameters, and slot values into properties of the widget object
+	// Get our parameters
-	this.collectAttributes();
+	this.transcludeTitle = this.getAttribute("tiddler",this.getVariable("currentTiddler"));
-	this.collectStringParameters();
+	this.transcludeSubTiddler = this.getAttribute("subtiddler");
-	this.collectSlotFillParameters();
+	this.transcludeField = this.getAttribute("field");
-	// Get the parse tree nodes that we are transcluding
+	this.transcludeIndex = this.getAttribute("index");
-	var target = this.getTransclusionTarget(),
+	this.transcludeMode = this.getAttribute("mode");
-		parseTreeNodes = target.parseTreeNodes;
+	this.recursionMarker = this.getAttribute("recursionMarker","yes");
-	this.sourceText = target.text;
+	// Parse the text reference
-	this.sourceType = target.type;
-	this.parseAsInline = target.parseAsInline;
-	// Process the transclusion according to the output type
-	switch(this.transcludeOutput || "text/html") {
-		case "text/html":
-			// No further processing required
-			break;
-		case "text/raw":
-			// Just return the raw text
-			parseTreeNodes = [{type: "text", text: this.sourceText}];
-			break;
-		default:
-			// text/plain
-			var plainText = this.wiki.renderText("text/plain",this.sourceType,this.sourceText,{parentWidget: this});
-			parseTreeNodes = [{type: "text", text: plainText}];
-			break;
-	}
-	// Set the legacy transclusion context variables only if we're not transcluding a variable
-	if(!this.transcludeVariable) {
-		var recursionMarker = this.makeRecursionMarker();
-		this.setVariable("transclusion",recursionMarker);
-	}
-	// Construct the child widgets
-	this.makeChildWidgets(parseTreeNodes);
-};
-
-/*
-Collect the attributes we need, in the process determining whether we're being used in legacy mode
-*/
-TranscludeWidget.prototype.collectAttributes = function() {
-	var self = this;
-	// Detect legacy mode
-	this.legacyMode = true;
-	$tw.utils.each(this.attributes,function(value,name) {
-		if(name.charAt(0) === "$") {
-			self.legacyMode = false;
-		}
-	});
-	// Get the attributes for the appropriate mode
-	if(this.legacyMode) {
-		this.transcludeTitle = this.getAttribute("tiddler",this.getVariable("currentTiddler"));
-		this.transcludeSubTiddler = this.getAttribute("subtiddler");
-		this.transcludeField = this.getAttribute("field");
-		this.transcludeIndex = this.getAttribute("index");
-		this.transcludeMode = this.getAttribute("mode");
-		this.recursionMarker = this.getAttribute("recursionMarker","yes");
-	} else {
-		this.transcludeVariable = this.getAttribute("$variable");
-		this.transcludeType = this.getAttribute("$type");
-		this.transcludeOutput = this.getAttribute("$output","text/html");
-		this.transcludeTitle = this.getAttribute("$tiddler",this.getVariable("currentTiddler"));
-		this.transcludeSubTiddler = this.getAttribute("$subtiddler");
-		this.transcludeField = this.getAttribute("$field");
-		this.transcludeIndex = this.getAttribute("$index");
-		this.transcludeMode = this.getAttribute("$mode");
-		this.recursionMarker = this.getAttribute("$recursionMarker","yes");
-	}
-};
-
-/*
-Collect string parameters
-*/
-TranscludeWidget.prototype.collectStringParameters = function() {
-	var self = this;
-	this.stringParametersByName = Object.create(null);
-	if(!this.legacyMode) {
-		$tw.utils.each(this.attributes,function(value,name) {
-			if(name.charAt(0) === "$") {
-				if(name.charAt(1) === "$") {
-					// Attributes starting $$ represent parameters starting with a single $
-					name = name.slice(1);
-				} else {
-					// Attributes starting with a single $ are reserved for the widget
-					return;
-				}
-			}
-			self.stringParametersByName[name] = value;
-		});
-	}
-};
-
-/*
-Collect slot value parameters
-*/
-TranscludeWidget.prototype.collectSlotFillParameters = function() {
-	var self = this;
-	this.slotFillParseTrees = Object.create(null);
-	if(this.legacyMode) {
-		this.slotFillParseTrees["ts-missing"] = this.parseTreeNode.children;
-	} else {
-		this.slotFillParseTrees["ts-raw"] = this.parseTreeNode.children;
-		var noFillWidgetsFound = true,
-			searchParseTreeNodes = function(nodes) {
-				$tw.utils.each(nodes,function(node) {
-					if(node.type === "fill") {
-						if(node.attributes["$name"] && node.attributes["$name"].type === "string") {
-							var slotValueName = node.attributes["$name"].value;
-							self.slotFillParseTrees[slotValueName] = node.children || [];
-						}
-						noFillWidgetsFound = false;
-					} else {
-						searchParseTreeNodes(node.children);
-					}
-				});
-			};
-		searchParseTreeNodes(this.parseTreeNode.children);
-		if(noFillWidgetsFound) {
-			this.slotFillParseTrees["ts-missing"] = this.parseTreeNode.children;
-		}
-	}
-};
-
-/*
-Get transcluded parse tree nodes as an object {parser:,text:,type:}
-*/
-TranscludeWidget.prototype.getTransclusionTarget = function() {
-	var self = this;
-	// Determine whether we're being used in inline or block mode
 	var parseAsInline = !this.parseTreeNode.isBlock;
 	if(this.transcludeMode === "inline") {
 		parseAsInline = true;
 	} else if(this.transcludeMode === "block") {
 		parseAsInline = false;
 	}
-	var parser;
+	var parser = this.wiki.parseTextReference(
-	// Get the parse tree
-	if(this.transcludeVariable) {
-		// Transcluding a variable
-		var variableInfo = this.getVariableInfo(this.transcludeVariable,{params: this.getOrderedTransclusionParameters()}),
-			srcVariable = variableInfo && variableInfo.srcVariable;
-		if(srcVariable) {
-			if(srcVariable.isFunctionDefinition) {
-				// Function to return parameters by name or position
-				var fnGetParam = function(name,index) {
-						// Parameter names starting with dollar must be escaped to double dollars
-						if(name.charAt(0) === "$") {
-							name = "$" + name;
-						}
-						// Look for the parameter by name
-						if(self.hasAttribute(name)) {
-							return self.getAttribute(name);
-						// Look for the parameter by index
-						} else if(self.hasAttribute(index + "")) {
-							return self.getAttribute(index + "");
-						} else {
-							return undefined;
-						}
-					},
-					result = this.evaluateVariable(this.transcludeVariable,{params: fnGetParam})[0] || "";
-				parser = {
-					tree: [{
-						type: "text",
-						text: result
-					}],
-					source: result,
-					type: "text/vnd.tiddlywiki"
-				};
-				if(parseAsInline) {
-					parser.tree[0] = {
-						type: "text",
-						text: result
-					};
-				} else {
-					parser.tree[0] = {
-						type: "element",
-						tag: "p",
-						children: [{
-							type: "text",
-							text: result
-						}]
-					}
-				}
-			} else {
-				var cacheKey = (parseAsInline ? "inlineParser" : "blockParser") + (this.transcludeType || "");
-				if(variableInfo.isCacheable && srcVariable[cacheKey]) {
-					parser = srcVariable[cacheKey];
-				} else {
-					parser = this.wiki.parseText(this.transcludeType,variableInfo.text || "",{parseAsInline: parseAsInline, configTrimWhiteSpace: srcVariable.configTrimWhiteSpace});
-					if(variableInfo.isCacheable) {
-						srcVariable[cacheKey] = parser;
-					}
-				}
-			}
-			if(parser) {
-				// Add parameters widget for procedures and custom widgets
-				if(srcVariable.isProcedureDefinition || srcVariable.isWidgetDefinition) {
-					parser = {
-						tree: [
-							{
-								type: "parameters",
-								children: parser.tree
-							}
-						],
-						source: parser.source,
-						type: parser.type
-					}
-					$tw.utils.each(srcVariable.params,function(param) {
-						var name = param.name;
-						// Parameter names starting with dollar must be escaped to double dollars
-						if(name.charAt(0) === "$") {
-							name = "$" + name;
-						}
-						$tw.utils.addAttributeToParseTreeNode(parser.tree[0],name,param["default"])
-					});
-				} else {
-					// For macros and ordinary variables, wrap the parse tree in a vars widget assigning the parameters to variables named "__paramname__"
-					parser = {
-						tree: [
-							{
-								type: "vars",
-								children: parser.tree
-							}
-						],
-						source: parser.source,
-						type: parser.type
-					}
-					$tw.utils.each(variableInfo.params,function(param) {
-						$tw.utils.addAttributeToParseTreeNode(parser.tree[0],"__" + param.name + "__",param.value)
-					});
-				}
-			}
-		}
-	} else {
-		// Transcluding a text reference
-		parser = this.wiki.parseTextReference(
 						this.transcludeTitle,
 						this.transcludeField,
 						this.transcludeIndex,
 						{
 							parseAsInline: parseAsInline,
-							subTiddler: this.transcludeSubTiddler,
+							subTiddler: this.transcludeSubTiddler
-							defaultType: this.transcludeType
+						}),
-						});
+		parseTreeNodes = parser ? parser.tree : this.parseTreeNode.children;
+	this.sourceText = parser ? parser.source : null;
+	this.parserType = parser? parser.type : null;
+	// Set context variables for recursion detection
+	var recursionMarker = this.makeRecursionMarker();
+	if(this.recursionMarker === "yes") {
+		this.setVariable("transclusion",recursionMarker);
 	}
-	// Set 'thisTiddler'
+	// Check for recursion
-	this.setVariable("thisTiddler",this.transcludeTitle);
-	// Return the parse tree
 	if(parser) {
-		return {
+		if(this.parentWidget && this.parentWidget.hasVariable("transclusion",recursionMarker)) {
-			parser: parser,
+			parseTreeNodes = [{type: "error", attributes: {
-			parseTreeNodes: parser.tree,
+				"$message": {type: "string", value: $tw.language.getString("Error/RecursiveTransclusion")}
-			parseAsInline: parseAsInline,
+			}}];
-			text: parser.source,
-			type: parser.type
-		};
-	} else {
-		// If there's no parse tree then return the missing slot value
-		return {
-			parser: null,
-			parseTreeNodes: (this.slotFillParseTrees["ts-missing"] || []),
-			parseAsInline: parseAsInline,
-			text: null,
-			type: null
-		};
-	}
-};
-
-/*
-Fetch all the string parameters as an ordered array of {name:, value:} where the name is optional
-*/
-TranscludeWidget.prototype.getOrderedTransclusionParameters = function() {
-	var result = [];
-	// Collect the parameters
-	for(var name in this.stringParametersByName) {
-		var value = this.stringParametersByName[name];
-		result.push({name: name, value: value});
-	}
-	// Sort numerical parameter names first
-	result.sort(function(a,b) {
-		var aIsNumeric = !isNaN(a.name),
-			bIsNumeric = !isNaN(b.name);
-		if(aIsNumeric && bIsNumeric) {
-			return a.name - b.name;
-		} else if(aIsNumeric) {
-			return -1;
-		} else if(bIsNumeric) {
-			return 1;
-		} else {
-			return a.name === b.name ? 0 : (a.name < b.name ? -1 : 1);
-		}
-	});
-	// Remove names from numerical parameters
-	$tw.utils.each(result,function(param,index) {
-		if(!isNaN(param.name)) {
-			delete param.name;
-		}
-	});
-	return result;
-};
-
-/*
-Fetch the value of a parameter
-*/
-TranscludeWidget.prototype.getTransclusionParameter = function(name,index,defaultValue) {
-	if(name in this.stringParametersByName) {
-		return this.stringParametersByName[name];
-	} else {
-		var name = "" + index;
-		if(name in this.stringParametersByName) {
-			return this.stringParametersByName[name];
 		}
 	}
-	return defaultValue;
+	// Construct the child widgets
-};
+	this.makeChildWidgets(parseTreeNodes);
-
-/*
-Get one of the special parameters to be provided by the parameters widget
-*/
-TranscludeWidget.prototype.getTransclusionMetaParameters = function() {
-	var self = this;
-	return {
-		"parseMode": function() {
-			return self.parseAsInline ? "inline" : "block";
-		},
-		"parseTreeNodes": function() {
-			return JSON.stringify(self.parseTreeNode.children || []);
-		},
-		"slotFillParseTreeNodes": function() {
-			return JSON.stringify(self.slotFillParseTrees);
-		},
-		"params": function() {
-			return JSON.stringify(self.stringParametersByName);
-		}
-	};
-};
-
-/*
-Fetch the value of a slot
-*/
-TranscludeWidget.prototype.getTransclusionSlotFill = function(name,defaultParseTreeNodes) {
-	if(name && this.slotFillParseTrees[name] && this.slotFillParseTrees[name].length > 0) {
-		return this.slotFillParseTrees[name];
-	} else {
-		return defaultParseTreeNodes || [];
-	}
 };
 
 /*
@@ -402,7 +99,6 @@ TranscludeWidget.prototype.makeRecursionMarker = function() {
 };
 
 TranscludeWidget.prototype.parserNeedsRefresh = function() {
-	// Doesn't need to consider transcluded variables because a parent variable can't change once a widget has been created
 	var parserInfo = this.wiki.getTextReferenceParserInfo(this.transcludeTitle,this.transcludeField,this.transcludeIndex,{subTiddler:this.transcludeSubTiddler});
 	return (this.sourceText === undefined || parserInfo.sourceText !== this.sourceText || parserInfo.parserType !== this.parserType)
 };
@@ -412,7 +108,7 @@ Selectively refreshes the widget if needed. Returns true if the widget or any of
 */
 TranscludeWidget.prototype.refresh = function(changedTiddlers) {
 	var changedAttributes = this.computeAttributes();
-	if(($tw.utils.count(changedAttributes) > 0) || (!this.transcludeVariable && changedTiddlers[this.transcludeTitle] && this.parserNeedsRefresh())) {
+	if(($tw.utils.count(changedAttributes) > 0) || (changedTiddlers[this.transcludeTitle] && this.parserNeedsRefresh())) {
 		this.refreshSelf();
 		return true;
 	} else {

core/modules/widgets/view.js

@@ -168,11 +168,11 @@ ViewWidget.prototype.getValueAsHtmlTextEncoded = function() {
 };
 
 ViewWidget.prototype.getValueAsUrlEncoded = function() {
-	return $tw.utils.encodeURIComponentExtended(this.getValueAsText());
+	return encodeURIComponent(this.getValueAsText());
 };
 
 ViewWidget.prototype.getValueAsDoubleUrlEncoded = function() {
-	return $tw.utils.encodeURIComponentExtended($tw.utils.encodeURIComponentExtended(this.getValueAsText()));
+	return encodeURIComponent(encodeURIComponent(this.getValueAsText()));
 };
 
 ViewWidget.prototype.getValueAsDate = function(format) {

core/modules/widgets/widget.js

@@ -41,7 +41,10 @@ Widget.prototype.initialise = function(parseTreeNode,options) {
 	this.parseTreeNode = parseTreeNode;
 	this.wiki = options.wiki;
 	this.parentWidget = options.parentWidget;
-	this.variables = Object.create(this.parentWidget ? this.parentWidget.variables : null);
+	this.variables = Object.create(null);
+	if(this.parentWidget) {
+		Object.setPrototypeOf(this.variables,this.parentWidget.variables);
+	}
 	this.document = options.document;
 	this.attributes = {};
 	this.children = [];
@@ -89,22 +92,9 @@ name: name of the variable
 value: value of the variable
 params: array of {name:, default:} for each parameter
 isMacroDefinition: true if the variable is set via a \define macro pragma (and hence should have variable substitution performed)
-options includes:
-	isProcedureDefinition: true if the variable is set via a \procedure pragma (and hence should not have variable substitution performed)
-	isFunctionDefinition: true if the variable is set via a \function pragma (and hence should not have variable substitution performed)
-	isWidgetDefinition: true if the variable is set via a \widget pragma (and hence should not have variable substitution performed)
 */
-Widget.prototype.setVariable = function(name,value,params,isMacroDefinition,options) {
+Widget.prototype.setVariable = function(name,value,params,isMacroDefinition) {
-	options = options || {};
+	this.variables[name] = {value: value, params: params, isMacroDefinition: !!isMacroDefinition};
-	this.variables[name] = {
-		value: value,
-		params: params,
-		isMacroDefinition: !!isMacroDefinition,
-		isFunctionDefinition: !!options.isFunctionDefinition,
-		isProcedureDefinition: !!options.isProcedureDefinition,
-		isWidgetDefinition: !!options.isWidgetDefinition,
-		configTrimWhiteSpace: !!options.configTrimWhiteSpace
-	};
 };
 
 /*
@@ -114,7 +104,6 @@ options: see below
 Options include
 params: array of {name:, value:} for each parameter
 defaultValue: default value if the variable is not defined
-allowSelfAssigned: if true, includes the current widget in the context chain instead of just the parent
 
 Returns an object with the following fields:
 
@@ -123,27 +112,21 @@ text: text of variable, with parameters properly substituted
 */
 Widget.prototype.getVariableInfo = function(name,options) {
 	options = options || {};
-	var self = this,
+	var actualParams = options.params || [],
-		actualParams = options.params || [],
+		parentWidget = this.parentWidget;
-		variable;
-	if(options.allowSelfAssigned) {
-		variable = this.variables[name];
-	} else {
-		variable = this.parentWidget && this.parentWidget.variables[name];
-	}
 	// Check for the variable defined in the parent widget (or an ancestor in the prototype chain)
-	if(variable) {
+	if(parentWidget && name in parentWidget.variables) {
-		var originalValue = variable.value,
+		var variable = parentWidget.variables[name],
+			originalValue = variable.value,
 			value = originalValue,
-			params = [];
+			params = this.resolveVariableParameters(variable.params,actualParams);
-		// Only substitute parameter and variable references if this variable was defined with the \define pragma
+		// Substitute any parameters specified in the definition
+		$tw.utils.each(params,function(param) {
+			value = $tw.utils.replaceString(value,new RegExp("\\$" + $tw.utils.escapeRegExp(param.name) + "\\$","mg"),param.value);
+		});
+		// Only substitute variable references if this variable was defined with the \define pragma
 		if(variable.isMacroDefinition) {
-			params = self.resolveVariableParameters(variable.params,actualParams);
+			value = this.substituteVariableReferences(value,options);
-			// Substitute any parameters specified in the definition
-			$tw.utils.each(params,function(param) {
-				value = $tw.utils.replaceString(value,new RegExp("\\$" + $tw.utils.escapeRegExp(param.name) + "\\$","mg"),param.value);
-			});
-			value = self.substituteVariableReferences(value,options);
 		}
 		return {
 			text: value,
@@ -153,13 +136,8 @@ Widget.prototype.getVariableInfo = function(name,options) {
 		};
 	}
 	// If the variable doesn't exist in the parent widget then look for a macro module
-	var text = this.evaluateMacroModule(name,actualParams);
-	if(text === undefined) {
-		text = options.defaultValue;
-	}
 	return {
-		text: text,
+		text: this.evaluateMacroModule(name,actualParams,options.defaultValue)
-		srcVariable: {}
 	};
 };
 
@@ -170,11 +148,6 @@ Widget.prototype.getVariable = function(name,options) {
 	return this.getVariableInfo(name,options).text;
 };
 
-/*
-Maps actual parameters onto formal parameters, returning an array of {name:,value:} objects
-formalParams - Array of {name:,default:} (default value is optional)
-actualParams - Array of string values or {name:,value:} (name is optional)
-*/
 Widget.prototype.resolveVariableParameters = function(formalParams,actualParams) {
 	formalParams = formalParams || [];
 	actualParams = actualParams || [];
@@ -187,7 +160,7 @@ Widget.prototype.resolveVariableParameters = function(formalParams,actualParams)
 		paramInfo = formalParams[p];
 		paramValue = undefined;
 		for(var m=0; m<actualParams.length; m++) {
-			if(typeof actualParams[m] !== "string" && actualParams[m].name === paramInfo.name) {
+			if(actualParams[m].name === paramInfo.name) {
 				paramValue = actualParams[m].value;
 			}
 		}
@@ -196,8 +169,7 @@ Widget.prototype.resolveVariableParameters = function(formalParams,actualParams)
 			nextAnonParameter++;
 		}
 		if(paramValue === undefined && nextAnonParameter < actualParams.length) {
-			var param = actualParams[nextAnonParameter++];
+			paramValue = actualParams[nextAnonParameter++].value;
-			paramValue = typeof param === "string" ? param : param.value;
 		}
 		// If we've still not got a value, use the default, if any
 		paramValue = paramValue || paramInfo["default"] || "";
@@ -291,103 +263,12 @@ Widget.prototype.getStateQualifier = function(name) {
 };
 
 /*
-Make a fake widget with specified variables, suitable for variable lookup in filters
+Compute the current values of the attributes of the widget. Returns a hashmap of the names of the attributes that have changed
 */
-Widget.prototype.makeFakeWidgetWithVariables = function(variables) {
+Widget.prototype.computeAttributes = function() {
-	var self = this;
-	return {
-		getVariable: function(name,opts) {
-			if($tw.utils.hop(variables,name)) {
-				return variables[name];
-			} else {
-				opts = opts || {};
-				opts.variables = variables;
-				return self.getVariable(name,opts);
-			};
-		},
-		getVariableInfo: function(name,opts) {
-			if($tw.utils.hop(variables,name)) {
-				return {
-					text: variables[name]
-				};
-			} else {
-				opts = opts || {};
-				opts.variables = variables;
-				return self.getVariableInfo(name,opts);
-			};
-		},
-		makeFakeWidgetWithVariables: self.makeFakeWidgetWithVariables,
-		evaluateVariable: self.evaluateVariable,
-		resolveVariableParameters: self.resolveVariableParameters,
-		wiki: self.wiki
-	};
-};
-
-/*
-Evaluate a variable and associated actual parameters and result the resulting array.
-The way that the variable is evaluated depends upon its type:
-* Functions are evaluated as parameterised filter strings
-* Macros are returned as plain text with substitution of parameters
-* Procedures and widgets are returned as plain text
-
-Options are:
-params - the actual parameters – may be one of:
-	* an array of values that may be an anonymous string value, or a {name:, value:} pair
-	* a hashmap of {name: value} pairs
-	* a function invoked with parameters (name,index) that returns a parameter value by name or position
-source - iterator for source tiddlers
-*/
-Widget.prototype.evaluateVariable = function(name,options) {
-	options = options || {};
-	var params = options.params || [];
-	// Get the details of the variable (includes processing text substitution for macros
-	var variableInfo = this.getVariableInfo(name,{params: params,defaultValue: ""});
-	// Process function parameters
-	var variables = Object.create(null);
-	if(variableInfo.srcVariable && variableInfo.srcVariable.isFunctionDefinition) {
-		// Apply default parameter values
-		$tw.utils.each(variableInfo.srcVariable.params,function(param,index) {
-			if(param["default"]) {
-				variables[param.name] = param["default"];
-			}
-		});
-		if($tw.utils.isArray(params)) {
-			// Parameters are an array of values or {name:, value:} pairs
-			$tw.utils.each(this.resolveVariableParameters(variableInfo.srcVariable.params,params),function(param) {
-				variables[param.name] = param.value;
-			});
-		} else if(typeof params === "function") {
-			// Parameters are passed via a function
-			$tw.utils.each(variableInfo.srcVariable.params,function(param,index) {
-				variables[param.name] = params(param.name,index) || param["default"] || "";
-			});
-		} else {
-			// Parameters are a hashmap
-			$tw.utils.each(params,function(value,name) {
-				variables[name] = value;
-			});
-		}
-		return this.wiki.filterTiddlers(variableInfo.text,this.makeFakeWidgetWithVariables(variables),options.source);
-	} else {
-		return [variableInfo.text];
-	}
-};
-
-/*
-Compute the current values of the attributes of the widget. Returns a hashmap of the names of the attributes that have changed.
-Options include:
-filterFn: only include attributes where filterFn(name) returns true
-*/
-Widget.prototype.computeAttributes = function(options) {
-	options = options || {};
 	var changedAttributes = {},
 		self = this;
 	$tw.utils.each(this.parseTreeNode.attributes,function(attribute,name) {
-		if(options.filterFn) {
-			if(!options.filterFn(name)) {
-				return;
-			}
-		}
 		var value = self.computeAttribute(attribute);
 		if(self.attributes[name] !== value) {
 			self.attributes[name] = value;
@@ -398,21 +279,13 @@ Widget.prototype.computeAttributes = function(options) {
 };
 
 Widget.prototype.computeAttribute = function(attribute) {
-	var self = this,
+	var value;
-		value;
 	if(attribute.type === "filtered") {
 		value = this.wiki.filterTiddlers(attribute.filter,this)[0] || "";
 	} else if(attribute.type === "indirect") {
 		value = this.wiki.getTextReference(attribute.textReference,"",this.getVariable("currentTiddler"));
 	} else if(attribute.type === "macro") {
-		var variableInfo = this.getVariableInfo(attribute.value.name,{params: attribute.value.params});
+		value = this.getVariable(attribute.value.name,{params: attribute.value.params});
-		if(variableInfo.srcVariable && variableInfo.srcVariable.isFunctionDefinition) {
-			// It is a function definition. Go through each of the defined parameters, and make a variable with the value of the corresponding provided parameter
-			var paramArray = this.resolveVariableParameters(variableInfo.srcVariable.params,attribute.value.params);
-			value = this.evaluateVariable(attribute.value.name,{params: paramArray})[0] || "";
-		} else {
-			value = variableInfo.text;
-		}
 	} else { // String attribute
 		value = attribute.value;
 	}
@@ -540,34 +413,7 @@ options include:
 	variables: optional hashmap of variables to wrap around the widget
 */
 Widget.prototype.makeChildWidget = function(parseTreeNode,options) {
-	var self = this;
 	options = options || {};
-	// Check whether this node type is defined by a custom widget definition
-	var variableDefinitionName = "$" + parseTreeNode.type;
-	if(this.variables[variableDefinitionName]) {
-		var isOverrideable = function() {
-				// Widget is overrideable if it has a double dollar user defined name, or if it is an existing JS widget and we're not in safe mode
-				return parseTreeNode.type.charAt(0) === "$" || (!!self.widgetClasses[parseTreeNode.type] && !$tw.safeMode);
-			};
-		if(!parseTreeNode.isNotRemappable && isOverrideable()) { 
-			var variableInfo = this.getVariableInfo(variableDefinitionName,{allowSelfAssigned: true});
-			if(variableInfo && variableInfo.srcVariable && variableInfo.srcVariable.value && variableInfo.srcVariable.isWidgetDefinition) {
-				var newParseTreeNode = {
-					type: "transclude",
-					children: parseTreeNode.children,
-					isBlock: parseTreeNode.isBlock
-				};
-				$tw.utils.addAttributeToParseTreeNode(newParseTreeNode,"$variable",variableDefinitionName);
-				$tw.utils.each(parseTreeNode.attributes,function(attr,name) {
-					// If the attribute starts with a dollar then add an extra dollar so that it doesn't clash with the $xxx attributes of transclude
-					name = name.charAt(0) === "$" ? "$" + name : name;
-					$tw.utils.addAttributeToParseTreeNode(newParseTreeNode,$tw.utils.extend({},attr,{name: name}));
-				});
-				parseTreeNode = newParseTreeNode;
-			}
-		}
-	}
-	// Get the widget class for this node type
 	var WidgetClass = this.widgetClasses[parseTreeNode.type];
 	if(!WidgetClass) {
 		WidgetClass = this.widgetClasses.text;

core/modules/wiki.js

@@ -22,7 +22,8 @@ Adds the following properties to the wiki object:
 /*global $tw: false */
 "use strict";
 
-var widget = require("$:/core/modules/widgets/widget.js");
+var widget = require("$:/core/modules/widgets/widget.js"),
+	LinkWidget = require("$:/core/modules/widgets/link.js").link;
 
 var USER_NAME_TITLE = "$:/status/UserName",
 	TIMESTAMP_DISABLE_TITLE = "$:/config/TimestampDisable";
@@ -513,6 +514,29 @@ exports.extractLinks = function(parseTreeRoot) {
 	return links;
 };
 
+/*
+Return an array of tiddelr titles that are linked within the given widget tree
+ */
+exports.extractLinksFromWidgetTree = function(widget) {
+	// Count up the links
+	var links = [],
+		checkWidget = function(widget) {
+			if(widget instanceof LinkWidget) {
+				var value = widget.to;
+				if(links.indexOf(value) === -1) {
+					links.push(value);
+				}
+			}
+			if(widget.children) {
+				$tw.utils.each(widget.children,function(widget) {
+					checkWidget(widget);
+				});
+			}
+		};
+	checkWidget(widget);
+	return links;
+};
+
 /*
 Return an array of tiddler titles that are directly linked from the specified tiddler
 */
@@ -521,11 +545,10 @@ exports.getTiddlerLinks = function(title) {
 	// We'll cache the links so they only get computed if the tiddler changes
 	return this.getCacheForTiddler(title,"links",function() {
 		// Parse the tiddler
-		var parser = self.parseTiddler(title);
+		var container = $tw.fakeDocument.createElement("div");
-		if(parser) {
+		var widget = self.makeTranscludeWidget(title,{document: $tw.fakeDocument, parseAsInline: false,variables: {currentTiddler: title},importPageMacros: true});
-			return self.extractLinks(parser.tree);
+		widget.render(container,null);
-		}
+		return self.extractLinksFromWidgetTree(widget);
-		return [];
 	});
 };
 
@@ -988,8 +1011,7 @@ exports.parseText = function(type,text,options) {
 	return new Parser(type,text,{
 		parseAsInline: options.parseAsInline,
 		wiki: this,
-		_canonical_uri: options._canonical_uri,
+		_canonical_uri: options._canonical_uri
-		configTrimWhiteSpace: options.configTrimWhiteSpace
 	});
 };
 
@@ -1029,11 +1051,10 @@ exports.parseTextReference = function(title,field,index,options) {
 };
 
 exports.getTextReferenceParserInfo = function(title,field,index,options) {
-	var defaultType = options.defaultType || "text/vnd.tiddlywiki",
+	var tiddler,
-		tiddler,
 		parserInfo = {
 			sourceText : null,
-			parserType : defaultType
+			parserType : "text/vnd.tiddlywiki"
 		};
 	if(options.subTiddler) {
 		tiddler = this.getSubTiddler(title,options.subTiddler);
@@ -1079,20 +1100,19 @@ exports.makeWidget = function(parser,options) {
 			children: []
 		},
 		currWidgetNode = widgetNode;
-	// Create let variable widget for variables
+	// Create set variable widgets for each variable
-	if($tw.utils.count(options.variables) > 0) {
+	$tw.utils.each(options.variables,function(value,name) {
-		var letVariableWidget = {
+		var setVariableWidget = {
-			type: "let",
+			type: "set",
 			attributes: {
+				name: {type: "string", value: name},
+				value: {type: "string", value: value}
 			},
 			children: []
 		};
-		$tw.utils.each(options.variables,function(value,name) {
+		currWidgetNode.children = [setVariableWidget];
-			$tw.utils.addAttributeToParseTreeNode(letVariableWidget,name,"" + value);
+		currWidgetNode = setVariableWidget;
-		});
+	});
-		currWidgetNode.children = [letVariableWidget];
-		currWidgetNode = letVariableWidget;
-	}
 	// Add in the supplied parse tree nodes
 	currWidgetNode.children = parser ? parser.tree : [];
 	// Create the widget

core/templates/exporters/StaticRiver.tid

@@ -14,7 +14,6 @@ extension: .html
 <meta http-equiv="Content-Type" content="text/html;charset=utf-8" />
 <meta name="generator" content="TiddlyWiki" />
 <meta name="tiddlywiki-version" content="{{$:/core/templates/version}}" />
-<meta name="viewport" content="width=device-width, initial-scale=1.0" />
 <meta name="format-detection" content="telephone=no">
 <link id="faviconLink" rel="shortcut icon" href="favicon.ico">
 <title>{{$:/core/wiki/title}}</title>