From ec3f16f50fa7eeba91a50c5c8117ef8726c169f0 Mon Sep 17 00:00:00 2001 From: Jeremy Ruston Date: Tue, 19 Jun 2012 10:40:05 +0100 Subject: [PATCH] Enabled sorting by title of tiddlers that don't exist --- core/modules/wiki.js | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/core/modules/wiki.js b/core/modules/wiki.js index 968f8a37a..b44219c38 100644 --- a/core/modules/wiki.js +++ b/core/modules/wiki.js @@ -220,16 +220,18 @@ Sort an array of tiddler titles by a specified field exports.sortTiddlers = function(titles,sortField,isDescending,isCaseSensitive) { var self = this; titles.sort(function(a,b) { - var aa = self.getTiddler(a).fields[sortField] || 0, - bb = self.getTiddler(b).fields[sortField] || 0; - if(!isCaseSensitive) { - aa = aa.toLowerCase(); - bb = bb.toLowerCase(); + if(sortField !== "title") { + a = self.getTiddler(a).fields[sortField] || 0; + b = self.getTiddler(b).fields[sortField] || 0; } - if(aa < bb) { + if(!isCaseSensitive) { + a = a.toLowerCase(); + b = b.toLowerCase(); + } + if(a < b) { return isDescending ? +1 : -1; } else { - if(aa > bb) { + if(a > b) { return isDescending ? -1 : +1; } else { return 0; @@ -283,7 +285,6 @@ exports.getTiddlersWithTag = function(tag) { titles.push(title); } } - this.sortTiddlers(titles,"title"); return titles; };