From e80c99791e7142d786830e65ace9c71e13b5921e Mon Sep 17 00:00:00 2001
From: Mario Pietsch <pmariojo@gmail.com>
Date: Sun, 28 Jul 2024 17:36:17 +0200
Subject: [PATCH] Add tag-tiddler to tag-pill drag & drop import, add hidden
 setting for TagPillDragFilter (#8182)

* add tag-tiddler to tag-pill drag & drop import, add hidden setting for TagPillDragFilter

* update docs to make Be Aware clearer

* exclude the tag tiddler and update hidden docs accordingly
---
 core/ui/TagTemplate.tid                       |  2 +-
 core/wiki/config/TagPillDragFilter.tid        |  2 ++
 .../Hidden Setting_ Tag Pill Drag Filter.tid  | 22 +++++++++++++++++++
 3 files changed, 25 insertions(+), 1 deletion(-)
 create mode 100644 core/wiki/config/TagPillDragFilter.tid
 create mode 100644 editions/tw5.com/tiddlers/hiddensettings/Hidden Setting_ Tag Pill Drag Filter.tid

diff --git a/core/ui/TagTemplate.tid b/core/ui/TagTemplate.tid
index 49e836671..6b17fe971 100644
--- a/core/ui/TagTemplate.tid
+++ b/core/ui/TagTemplate.tid
@@ -9,7 +9,7 @@ title: $:/core/ui/TagTemplate
 		colour={{{ [<currentTiddler>] :cascade[all[shadows+tiddlers]tag[$:/tags/TiddlerColourFilter]!is[draft]get[text]] }}}
 		palette={{$:/palette}}
 		element-tag="$button"
-		element-attributes="""popup=<<qualify "$:/state/popup/tag">> dragFilter="[all[current]tagging[]]" tag='span'"""
+		element-attributes="""popup=<<qualify "$:/state/popup/tag">> dragFilter="[subfilter{$:/core/config/TagPillDragFilter}]" tag='span'"""
 	/>
 	<$reveal state=<<qualify "$:/state/popup/tag">> type="popup" position="below" animate="yes" class="tc-drop-down">
 		<$set name="tv-show-missing-links" value="yes">
diff --git a/core/wiki/config/TagPillDragFilter.tid b/core/wiki/config/TagPillDragFilter.tid
new file mode 100644
index 000000000..188c50b9e
--- /dev/null
+++ b/core/wiki/config/TagPillDragFilter.tid
@@ -0,0 +1,2 @@
+title: $:/core/config/TagPillDragFilter
+text: [all[current]tagging[]] +[!is[draft]]
diff --git a/editions/tw5.com/tiddlers/hiddensettings/Hidden Setting_ Tag Pill Drag Filter.tid b/editions/tw5.com/tiddlers/hiddensettings/Hidden Setting_ Tag Pill Drag Filter.tid
new file mode 100644
index 000000000..c8e2c9c77
--- /dev/null
+++ b/editions/tw5.com/tiddlers/hiddensettings/Hidden Setting_ Tag Pill Drag Filter.tid	
@@ -0,0 +1,22 @@
+created: 20240508093242925
+modified: 20240728134955433
+tags: [[Hidden Settings]]
+title: Hidden Setting: Tag Pill Drag Filter
+type: text/vnd.tiddlywiki
+
+The ''~$:/core/config/TagPillDragFilter'' defines the filter string, that is used to drag & drop a tap-pill eg: <<tag HelloThere>> from 1 wiki to an other wiki. 
+
+* By default the set contains all tiddlers that are ''tagged:'' HelloThere ''without'' the HelloThere tag-tiddler itself
+** Core Default: <code><$transclude $tiddler="$:/core" $subtiddler="$:/core/config/TagPillDragFilter" output="text/plain" /></code>
+* If you do want to include the tag-tiddler use the following filter:
+** Tagged tiddlers only: `[all[current]tagging[]] [all[current]is[tiddler]] +[!is[draft]]`
+
+Your $:/core/config/TagPillDragFilter
+<%if [[$:/core/config/TagPillDragFilter]is[tiddler]] %>
+''has been overwritten'' and  contains:
+<%else%>
+defaults to:
+<%endif%>
+<code>{{$:/core/config/TagPillDragFilter}}</code>
+
+<<.note title:"Be Aware" _:"The core default filter does //not// include shadow-tiddlers. It will //include overwritten// shadow tiddlers. See: [[is Operator]] for details about the `is[tiddler]` and other possibilities.">>