mirrors/TiddlyWiki5
1
0
Fork 0
mirror of https://github.com/Jermolene/TiddlyWiki5 synced 2025-02-22 22:10:03 +00:00
Code Issues Releases Wiki Activity

Removed ability for widgets to not generate any elements

Browse Source 
It interfered with the refresh mechanism
This commit is contained in:
Jeremy Ruston 2013-01-17 11:28:24 +00:00
parent 6044995df2
commit df59dee188
2 changed files with 39 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

76
core/modules/rendertree/renderers/element.js
View File

@ -114,54 +114,48 @@ ElementRenderer.prototype.getAttribute = function(name,defaultValue) {
};
ElementRenderer.prototype.render = function(type) {
// Check if our widget is providing an element
if(this.widget.tag) {
var isHtml = type === "text/html",
output = [],attr,a,v;
if(isHtml) {
output.push("<",this.widget.tag);
if(this.widget.attributes) {
attr = [];
for(a in this.widget.attributes) {
attr.push(a);
}
attr.sort();
for(a=0; a<attr.length; a++) {
v = this.widget.attributes[attr[a]];
if(v !== undefined) {
if($tw.utils.isArray(v)) {
v = v.join(" ");
} else if(typeof v === "object") {
var s = [];
for(var p in v) {
s.push(p + ":" + v[p] + ";");
}
v = s.join("");
var isHtml = type === "text/html",
output = [],attr,a,v;
if(isHtml) {
output.push("<",this.widget.tag);
if(this.widget.attributes) {
attr = [];
for(a in this.widget.attributes) {
attr.push(a);
}
attr.sort();
for(a=0; a<attr.length; a++) {
v = this.widget.attributes[attr[a]];
if(v !== undefined) {
if($tw.utils.isArray(v)) {
v = v.join(" ");
} else if(typeof v === "object") {
var s = [];
for(var p in v) {
s.push(p + ":" + v[p] + ";");
}
output.push(" ",attr[a],"='",$tw.utils.htmlEncode(v),"'");
v = s.join("");
}
output.push(" ",attr[a],"='",$tw.utils.htmlEncode(v),"'");
}
}
if(!this.widget.children || this.widget.children.length === 0) {
output.push("/");
}
output.push(">");
}
if(this.widget.children && this.widget.children.length > 0) {
$tw.utils.each(this.widget.children,function(node) {
if(node.render) {
output.push(node.render(type));
}
});
if(isHtml) {
output.push("</",this.widget.tag,">");
}
if(!this.widget.children || this.widget.children.length === 0) {
output.push("/");
}
return output.join("");
} else {
// Just render our first child if we're not generating an element
return this.widget.children[0].render(type);
output.push(">");
}
if(this.widget.children && this.widget.children.length > 0) {
$tw.utils.each(this.widget.children,function(node) {
if(node.render) {
output.push(node.render(type));
}
});
if(isHtml) {
output.push("</",this.widget.tag,">");
}
}
return output.join("");
};
ElementRenderer.prototype.renderInDom = function() {

5
core/modules/widgets/view/viewers/link.js
View File

@ -22,7 +22,10 @@ var LinkViewer = function(viewWidget,tiddler,field,value) {
LinkViewer.prototype.render = function() {
var text = this.value === undefined ? "" : this.value;
// Indicate that we're not generating an element
this.viewWidget.tag = undefined;
this.viewWidget.tag = this.viewWidget.renderer.parseTreeNode.isBlock ? "div" : "span";
this.viewWidget.attributes = {
"class": "tw-view-link"
};
this.viewWidget.children = this.viewWidget.renderer.renderTree.createRenderers(this.viewWidget.renderer.renderContext,[{
type: "element",
tag: "$link",