mirrors/TiddlyWiki5
1
0
Fork 0
mirror of https://github.com/Jermolene/TiddlyWiki5 synced 2025-05-08 02:14:09 +00:00
Code Issues Releases Wiki Activity

putSaver: return null on save success, TODOs

Browse Source
This commit is contained in:
Eric Drechsel 2016-02-15 15:20:30 -08:00
parent f8552ac48d
commit dd43759ecc
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
core/modules/savers/put.js
View File

@ -24,14 +24,18 @@ var PutSaver = function(wiki) {
PutSaver.prototype.save = function(text,method,callback) { PutSaver.prototype.save = function(text,method,callback) {
var req = new XMLHttpRequest(); var req = new XMLHttpRequest();
// TODO: store/check ETags if supported by server, to protect against overwrites
// Prompt: Do you want to save over this? Y/N
// Merging would be ideal, and may be possible using future generic merge flow
req.addEventListener("load", function() { req.addEventListener("load", function() {
if (this.status === 200 || this.status === 201) { if (this.status === 200 || this.status === 201) {
// success // success
callback(null);
} }
else { else {
// fail // fail
}
callback(this.responseText); callback(this.responseText);
}
}); });
req.open("PUT", encodeURI(window.location.href)); req.open("PUT", encodeURI(window.location.href));
req.setRequestHeader("Content-Type", "text/html;charset=UTF-8"); req.setRequestHeader("Content-Type", "text/html;charset=UTF-8");
@ -52,6 +56,10 @@ PutSaver.prototype.info = {
Static method that returns true if this saver is capable of working Static method that returns true if this saver is capable of working
*/ */
exports.canSave = function(wiki) { exports.canSave = function(wiki) {
// TODO This should probe for the DAV header
// http://www.webdav.org/specs/rfc2518.html#rfc.section.9.1
// but doing so would require canSave to resolve async. See
// https://github.com/Jermolene/TiddlyWiki5/issues/2276
return /^https?:/.test(location.protocol); return /^https?:/.test(location.protocol);
}; };