From d30eacc6520971c95bdabf24f4c4122534d9414a Mon Sep 17 00:00:00 2001 From: Jeremy Ruston Date: Fri, 11 Oct 2019 17:46:30 +0100 Subject: [PATCH] Select widget: fix bug with deselecting entries programmatically Previously, it was not possible to deselect entries by editing the tiddler $:/generated-list-demo-state used in the final example of the SelectWidget docs --- core/modules/widgets/select.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/core/modules/widgets/select.js b/core/modules/widgets/select.js index d860d42cf..6efeb588f 100644 --- a/core/modules/widgets/select.js +++ b/core/modules/widgets/select.js @@ -96,11 +96,8 @@ SelectWidget.prototype.setSelectValue = function() { var select = this.getSelectDomNode(); var values = Array.isArray(value) ? value : $tw.utils.parseStringArray(value); for(var i=0; i < select.children.length; i++){ - if(values.indexOf(select.children[i].value) != -1) { - select.children[i].selected = true; - } + select.children[i].selected = values.indexOf(select.children[i].value) !== -1 } - } else { var domNode = this.getSelectDomNode(); if(domNode.value !== value) {