From ce5d20b8fc72056a4c18b09a1135a5634e63888c Mon Sep 17 00:00:00 2001 From: Saq Imtiaz Date: Mon, 7 Dec 2020 16:53:49 +0100 Subject: [PATCH] Logging widgets :Fixed issue on Firefox where logging does not work (#5223) * Fixed issue on Firefox where logging does not work properly due to column names * Remove second argument to utils.logTable --- core/modules/utils/utils.js | 4 ++-- core/modules/widgets/action-log.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/core/modules/utils/utils.js b/core/modules/utils/utils.js index 14d251f01..4c9c3e96d 100644 --- a/core/modules/utils/utils.js +++ b/core/modules/utils/utils.js @@ -56,9 +56,9 @@ exports.warning = function(text) { /* Log a table of name: value pairs */ -exports.logTable = function(data,columnNames) { +exports.logTable = function(data) { if(console.table) { - console.table(data,columnNames); + console.table(data); } else { $tw.utils.each(data,function(value,name) { console.log(name + ": " + value); diff --git a/core/modules/widgets/action-log.js b/core/modules/widgets/action-log.js index 216eb1167..eacef94bc 100644 --- a/core/modules/widgets/action-log.js +++ b/core/modules/widgets/action-log.js @@ -78,11 +78,11 @@ LogWidget.prototype.log = function() { console.group(this.message); if(dataCount > 0) { - $tw.utils.logTable(data,["name","value"]); + $tw.utils.logTable(data); } if(this.logAll || !dataCount) { console.groupCollapsed("All variables"); - $tw.utils.logTable(allVars,["name","value"]); + $tw.utils.logTable(allVars); console.groupEnd(); } console.groupEnd();