mirrors/TiddlyWiki5
1
0
Fork 0
mirror of https://github.com/Jermolene/TiddlyWiki5 synced 2025-04-06 10:46:57 +00:00
Code Issues Releases Wiki Activity

feat: prevent adding the same event listener multiple times

Browse Source
This commit is contained in:
lin onetwo 2025-03-18 00:50:03 +08:00
parent 607bd47334
commit c4c7c62816
2 changed files with 29 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
core/modules/widgets/widget.js
View File

@ -634,7 +634,9 @@ Listener could return a boolean indicating whether to further propagation or not
*/
Widget.prototype.addEventListener = function(type,handler) {
this.eventListeners[type] = this.eventListeners[type] || [];
this.eventListeners[type].push(handler);
if(this.eventListeners[type].indexOf(handler) === -1) {
this.eventListeners[type].push(handler);
}
};
/*

26
editions/test/tiddlers/tests/test-widget-event.js
View File

@ -193,6 +193,32 @@ describe("Widget Event Listeners", function() {
expect(calls).not.toContain("listener1");
});
it("should prevent adding the same event listener multiple times", function() {
var calls = 0;
var wiki = new $tw.Wiki();
var widget = createWidgetNode({type:"widget", text:"text"}, wiki);
function listener(e) {
calls++;
return true;
}
// Add the same listener multiple times
widget.addEventListener("testEvent", listener);
widget.addEventListener("testEvent", listener);
widget.addEventListener("testEvent", listener);
// Dispatch the event
var event = {type:"testEvent"};
widget.dispatchEvent(event);
// The listener should only be called once
expect(calls).toBe(1);
// Check the internal structure of eventListeners array
expect(widget.eventListeners["testEvent"].length).toBe(1);
});
});
})();