mirrors/TiddlyWiki5
1
0
Fork 0
mirror of https://github.com/Jermolene/TiddlyWiki5 synced 2025-09-04 20:08:02 +00:00
Code Issues Releases Wiki Activity

Fix problem with edit-text widget and indexed properties

Browse Source 
Thanks to @grayeul for the pointer:

https://github.com/Jermolene/TiddlyWiki5/commit/78bc89cbdbcc26e373001f2d
473436489d8d4365#commitcomment-4554613
This commit is contained in:
Jermolene
2013-11-09 10:55:18 +00:00
parent 2a7f577366
commit b745e304a2
1 changed files with 23 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
core/modules/widgets/edit-text.js
View File

@@ -73,12 +73,21 @@ Get the tiddler being edited and current value
*/ */
EditTextWidget.prototype.getEditInfo = function() { EditTextWidget.prototype.getEditInfo = function() {
// Get the edit value // Get the edit value
var tiddler = this.wiki.getTiddler(this.editTitle), var self = this,
value; value,
update;
if(this.editIndex) { if(this.editIndex) {
value = this.wiki.extractTiddlerDataItem(this.editTitle,this.editIndex,this.editDefault); value = this.wiki.extractTiddlerDataItem(this.editTitle,this.editIndex,this.editDefault);
update = function(value) {
var data = this.wiki.getTiddlerData(this.editTitle,{});
if(data[this.editIndex] !== text) {
data[this.editIndex] = text;
this.wiki.setTiddlerData(this.editTitle,data);
}
};
} else { } else {
// Get the current tiddler and the field name // Get the current tiddler and the field name
var tiddler = this.wiki.getTiddler(this.editTitle);
if(tiddler) { if(tiddler) {
// If we've got a tiddler, the value to display is the field string value // If we've got a tiddler, the value to display is the field string value
value = tiddler.getFieldString(this.editField); value = tiddler.getFieldString(this.editField);
@@ -99,8 +108,16 @@ EditTextWidget.prototype.getEditInfo = function() {
value = this.editDefault; value = this.editDefault;
} }
} }
update = function(value) {
var tiddler = self.wiki.getTiddler(self.editTitle),
updateFields = {
title: self.editTitle
};
updateFields[self.editField] = value;
self.wiki.addTiddler(new $tw.Tiddler(self.wiki.getCreationFields(),tiddler,updateFields,self.wiki.getModificationFields()));
};
} }
return {tiddler: tiddler, value: value}; return {value: value, update: update};
}; };
/* /*
@@ -224,23 +241,9 @@ EditTextWidget.prototype.handleFocusEvent = function(event) {
}; };
EditTextWidget.prototype.saveChanges = function(text) { EditTextWidget.prototype.saveChanges = function(text) {
if(this.editField) { var editInfo = this.getEditInfo();
var tiddler = this.wiki.getTiddler(this.editTitle); if(text !== editInfo.value) {
if(!tiddler) { editInfo.update(text);
tiddler = new $tw.Tiddler({title: this.editTitle});
}
var oldValue = tiddler.getFieldString(this.editField);
if(text !== oldValue) {
var update = {};
update[this.editField] = text;
this.wiki.addTiddler(new $tw.Tiddler(tiddler,update));
}
} else {
var data = this.wiki.getTiddlerData(this.editTitle,{});
if(data[this.editIndex] !== text) {
data[this.editIndex] = text;
this.wiki.setTiddlerData(this.editTitle,data);
}
} }
}; };