mirrors/TiddlyWiki5
1
0
Fork 0
mirror of https://github.com/Jermolene/TiddlyWiki5 synced 2024-06-23 13:53:15 +00:00
Code Issues Releases Wiki Activity

Add this.document to ES2016 documentation (#2314)

Browse Source 
In the sample example for using ES2016 it used the
`$tw.utils.domMaker()`. I just found out that if this code is executed
by Node.js instead of in the browser that it doesn't work because
`window.document` doesn't exist. The expectation is that widgets pass in
the fake `this.document`.

I updated the example to reflect this.
This commit is contained in:
Devin Weaver 2016-07-11 08:46:22 -04:00 committed by Jeremy Ruston
parent aa58f4fc7d
commit aaf884b70a
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
editions/tw5.com/tiddlers/howtos/Using ES2016 for Writing Plugins.tid
View File

@ -1,4 +1,4 @@
modified: 20160112175004000
modified: 20160305222940000
created: 20160111034749658
tags: documenting Concepts
title: Using ES2016 for Writing Plugins
@ -154,7 +154,10 @@ class ClockWidget extends Widget {
this.logger.log('Rendering clock DOM nodes');
this.computeAttributes()
this.parentDomNode = parent;
this.domNode = $tw.utils.domMaker('div', {class: 'tc-clock-widget'});
this.domNode = $tw.utils.domMaker('div', {
document: this.document,
class: 'tc-clock-widget'
});
parent.insertBefore(this.domNode, nextSibling);
this.tick();
}