Handle directory creation if doesn't exist for test store (#8562)

* fix breaking bug in image tiddler attachment

* fix comments

* fix code format

* refactor processIncomingTiddler flow

* remove whitespaces after if statements

* refactor attachment_blob persistence flow

* refactor process tiddler to support different attachments

* add tests for attachment

* add more attachement test cases

* working on adding instanbul for test coverage report

* code coverage report generation

* remove unnecessary packages

* fix comments

* handle directory creation if doesn't exist for test store

* resolve issue with CI tests failure

editions/test/playwright.spec.js

@@ -12,9 +12,9 @@ test('get started link', async ({ page }) => {
 
     // Load the generated test TW html
     await page.goto(`file:///${crossPlatformIndexPath}`);
-
+    const title = await page.title();    
     // Sanity check
-    await expect(page.locator('.tc-site-title'), "Expected correct page title to verify the test page was loaded").toHaveText('TiddlyWiki5');
+    await expect(title, "Expected correct page title to verify the test page was loaded").toContain('TiddlyWiki5');
 
     // Wait for jasmine results bar to appear
     await expect(page.locator('.jasmine-overall-result'), "Expected jasmine test results bar to be present").toBeVisible({timeout});

package-lock.json

@@ -9,8 +9,10 @@
       "version": "5.3.6-prerelease",
       "license": "BSD",
       "dependencies": {
+        "@playwright/test": "^1.46.1",
         "better-sqlite3": "^9.4.3",
-        "node-sqlite3-wasm": "^0.8.10"
+        "node-sqlite3-wasm": "^0.8.10",
+        "playwright": "^1.46.1"
       },
       "bin": {
         "tiddlywiki": "tiddlywiki.js"
@@ -174,6 +176,20 @@
       "integrity": "sha512-ZnQMnLV4e7hDlUvw8H+U8ASL02SS2Gn6+9Ac3wGGLIe7+je2AeAOxPY+izIPJDfFDb7eDjev0Us8MO1iFRN8hA==",
       "dev": true
     },
+    "node_modules/@playwright/test": {
+      "version": "1.46.1",
+      "resolved": "https://registry.npmjs.org/@playwright/test/-/test-1.46.1.tgz",
+      "integrity": "sha512-Fq6SwLujA/DOIvNC2EL/SojJnkKf/rAwJ//APpJJHRyMi1PdKrY3Az+4XNQ51N4RTbItbIByQ0jgd1tayq1aeA==",
+      "dependencies": {
+        "playwright": "1.46.1"
+      },
+      "bin": {
+        "playwright": "cli.js"
+      },
+      "engines": {
+        "node": ">=18"
+      }
+    },
     "node_modules/acorn": {
       "version": "7.4.1",
       "resolved": "https://registry.npmjs.org/acorn/-/acorn-7.4.1.tgz",
@@ -793,6 +809,19 @@
       "integrity": "sha512-OO0pH2lK6a0hZnAdau5ItzHPI6pUlvI7jMVnxUQRtw4owF2wk8lOSabtGDCTP4Ggrg2MbGnWO9X8K1t4+fGMDw==",
       "dev": true
     },
+    "node_modules/fsevents": {
+      "version": "2.3.2",
+      "resolved": "https://registry.npmjs.org/fsevents/-/fsevents-2.3.2.tgz",
+      "integrity": "sha512-xiqMQR4xAeHTuB9uWm+fFRcIOgKBMiOBP+eXiyT7jsgVCq1bkVygt00oASowB7EdtpOHaaPgKt812P9ab+DDKA==",
+      "hasInstallScript": true,
+      "optional": true,
+      "os": [
+        "darwin"
+      ],
+      "engines": {
+        "node": "^8.16.0 || ^10.6.0 || >=11.0.0"
+      }
+    },
     "node_modules/functional-red-black-tree": {
       "version": "1.0.1",
       "resolved": "https://registry.npmjs.org/functional-red-black-tree/-/functional-red-black-tree-1.0.1.tgz",
@@ -1175,6 +1204,34 @@
         "node": ">=8"
       }
     },
+    "node_modules/playwright": {
+      "version": "1.46.1",
+      "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.46.1.tgz",
+      "integrity": "sha512-oPcr1yqoXLCkgKtD5eNUPLiN40rYEM39odNpIb6VE6S7/15gJmA1NzVv6zJYusV0e7tzvkU/utBFNa/Kpxmwng==",
+      "dependencies": {
+        "playwright-core": "1.46.1"
+      },
+      "bin": {
+        "playwright": "cli.js"
+      },
+      "engines": {
+        "node": ">=18"
+      },
+      "optionalDependencies": {
+        "fsevents": "2.3.2"
+      }
+    },
+    "node_modules/playwright-core": {
+      "version": "1.46.1",
+      "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.46.1.tgz",
+      "integrity": "sha512-h9LqIQaAv+CYvWzsZ+h3RsrqCStkBHlgo6/TJlFst3cOTlLghBQlJwPOZKQJTKNaD3QIB7aAVQ+gfWbN3NXB7A==",
+      "bin": {
+        "playwright-core": "cli.js"
+      },
+      "engines": {
+        "node": ">=18"
+      }
+    },
     "node_modules/prebuild-install": {
       "version": "7.1.1",
       "resolved": "https://registry.npmjs.org/prebuild-install/-/prebuild-install-7.1.1.tgz",

package.json

@@ -39,7 +39,9 @@
     "lint": "eslint ."
   },
   "dependencies": {
+    "@playwright/test": "^1.46.1",
     "better-sqlite3": "^9.4.3",
-    "node-sqlite3-wasm": "^0.8.10"
+    "node-sqlite3-wasm": "^0.8.10",
+    "playwright": "^1.46.1"
   }
 }

plugins/tiddlywiki/multiwikiserver/modules/tests/test-attachment.js

@@ -6,6 +6,7 @@ tags: [[$:/tags/test-spec]]
 Tests attachments.
 
 \*/
+if(typeof window === 'undefined' && typeof process !== 'undefined' && process.versions && process.versions.node) {
   var fs = require('fs');
   var path = require('path');
   var assert = require('assert');
@@ -47,6 +48,10 @@ if($tw.node) {
       var originalTimeout;
 
       beforeAll(function() {
+        const dirPath = path.dirname(`${storePath}/files`);
+        if(!fs.existsSync(dirPath)) {
+          fs.mkdirSync(dirPath, { recursive: true });
+        }
         originalTimeout = jasmine.DEFAULT_TIMEOUT_INTERVAL;
         jasmine.DEFAULT_TIMEOUT_INTERVAL = 50000;
       });
@@ -173,3 +178,4 @@ if($tw.node) {
     });
   }
   })();
+}