From a8272903325dd411dc99e90c04ed139f046a1367 Mon Sep 17 00:00:00 2001
From: "jeremy@jermolene.com" <jeremy@jermolene.com>
Date: Tue, 10 May 2022 10:22:35 +0100
Subject: [PATCH] Fix stringifying/parsing string arrays containing newlines

A very old bug.

Fixes the ActionListOpsWidget problem @btheado
---
 boot/boot.js                               | 4 ++--
 editions/test/tiddlers/tests/test-utils.js | 2 ++
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/boot/boot.js b/boot/boot.js
index 4bdedf4ef..d7f00e8c9 100644
--- a/boot/boot.js
+++ b/boot/boot.js
@@ -375,7 +375,7 @@ $tw.utils.stringifyList = function(value) {
 		var result = new Array(value.length);
 		for(var t=0, l=value.length; t<l; t++) {
 			var entry = value[t] || "";
-			if(entry.indexOf(" ") !== -1 || entry === "") {
+			if(entry === "" || /[^\S\xA0]/.test(entry)) {
 				result[t] = "[[" + entry + "]]";
 			} else {
 				result[t] = entry;
@@ -390,7 +390,7 @@ $tw.utils.stringifyList = function(value) {
 // Parse a string array from a bracketted list. For example "OneTiddler [[Another Tiddler]] LastOne"
 $tw.utils.parseStringArray = function(value, allowDuplicate) {
 	if(typeof value === "string") {
-		var memberRegExp = /(?:^|[^\S\xA0])(?:\[\[(.*?)\]\])(?=[^\S\xA0]|$)|([\S\xA0]+)/mg,
+		var memberRegExp = /(?:^|[^\S\xA0])(?:\[\[([\s\S]*?)\]\])(?=[^\S\xA0]|$)|([\S\xA0]+)/mg,
 			results = [], names = {},
 			match;
 		do {
diff --git a/editions/test/tiddlers/tests/test-utils.js b/editions/test/tiddlers/tests/test-utils.js
index 2714a43be..6a3eeb2a9 100644
--- a/editions/test/tiddlers/tests/test-utils.js
+++ b/editions/test/tiddlers/tests/test-utils.js
@@ -22,6 +22,7 @@ describe("Utility tests", function() {
 		expect(psa("Tiddler8 two")).toEqual(["Tiddler8","two"]);
 		expect(psa("Tiddler8 two [[]]")).toEqual(["Tiddler8","two",""]);
 		expect(psa(" Tiddler8 two ")).toEqual(["Tiddler8","two"]);
+		expect(psa(" [[Tidd\tler8]] [[spl\nit]]")).toEqual(["Tidd\tler8","spl\nit"]);
 		expect(psa(" Tidd\u00a0ler8 two ")).toEqual(["Tidd\u00a0ler8","two"]);
 		expect(psa(" [[Tidd\u00a0ler8]] two ")).toEqual(["Tidd\u00a0ler8","two"]);
 	});
@@ -56,6 +57,7 @@ describe("Utility tests", function() {
 		expect(str(["Tiddler8"])).toEqual("Tiddler8");
 		expect(str(["Tiddler8  "])).toEqual("[[Tiddler8  ]]");
 		expect(str(["A+B", "A-B", "A=B"])).toEqual("A+B A-B A=B");
+		expect(str(["A\nB", "A\tB"])).toEqual("[[A\nB]] [[A\tB]]");
 		expect(str(["A B"])).toEqual("[[A B]]");
 		// Starting special characters aren't treated specially,
 		// even though this makes a list incompatible with a filter parser.