From a53c6b5e5c20c804cfc54d3fedd6157ad667f119 Mon Sep 17 00:00:00 2001 From: pmario Date: Thu, 25 Apr 2024 18:07:59 +0200 Subject: [PATCH] remove empty class="" from button widget to simplify DOM --- core/modules/widgets/button.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/core/modules/widgets/button.js b/core/modules/widgets/button.js index cecd314ab..62f4ba79a 100644 --- a/core/modules/widgets/button.js +++ b/core/modules/widgets/button.js @@ -75,7 +75,7 @@ ButtonWidget.prototype.render = function(parent,nextSibling) { domNode = this.document.createElement(tag); this.domNode = domNode; // Assign classes - var classes = this["class"].split(" ") || [], + var classes = (this["class"]) ? this["class"].split(" ") : [], isPoppedUp = (this.popup || this.popupTitle) && this.isPoppedUp(); if(this.selectedClass) { if((this.set || this.setTitle) && this.setTo && this.isSelected()) { @@ -89,7 +89,9 @@ ButtonWidget.prototype.render = function(parent,nextSibling) { if(isPoppedUp) { $tw.utils.pushTop(classes,"tc-popup-handle"); } - domNode.className = classes.join(" "); + if(classes.length > 0) { + domNode.className = classes.join(" "); + } // Assign data- attributes this.assignAttributes(domNode,{ sourcePrefix: "data-",