mirrors/TiddlyWiki5
1
0
Fork 0
mirror of https://github.com/Jermolene/TiddlyWiki5 synced 2026-10-05 15:41:42 +00:00
Code Issues Releases Wiki Activity

Recurse exception handling to better handle '{{}}' in place of recently installed fix (#9548)

Browse Source 
* Introduced preliminary idea for infinite recurse exception

* Better handling of infinite recursion

But it could be better still...

* the TransclusionError is a proper error

Moved the magic number to be on the error's class. Not sure if that's
a great idea.

* Fixed minor minor issue that came up in conflict

The minor fix to the jasmine regexp that escaped a '+' somehow
broke some random test.

* Removing patch fix for recursion errors

* Fixed issue where buttton and other widgets don't clean up

* Added release notes for #9548

* Update test-widget.js

If I don't fix those indentations, the entire TW codebase will explode or soemthing.

* Update test-widget.js

These lint problems are wasting my time.

* Fixed all core widgets to not leak when renderChildren fails

* Updated release notes to reflect what I'm actually fixing

* Update test-widget.js

Added warning not to use for-of loop for defining tests. The iterating variable needs to have its own method scope, or it risks being the same value for all tests.
This commit is contained in:
Cameron Fischer
2026-02-04 11:21:16 +00:00
committed by GitHub
parent 486d3bd326
commit 9d5be2e9f8
22 changed files with 71 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files
editions/test/tiddlers/tests/test-widget.js
+26
View File
@@ -177,6 +177,32 @@ describe("Widget module", function() {
expect(wrapper.innerHTML).toBe("<span class=\"tc-error\">Recursive transclusion error in transclude widget</span> <span class=\"tc-error\">Recursive transclusion error in transclude widget</span>");
});
// Do NOT use a for-of or for-in here. Each jasmine test must be
// defined in its own function context, or the `tag` variable will
// end up being the same value for all iterations of the test.
$tw.utils.each(["div","$button","$checkbox","$diff-text","$draggable","$droppable","dropzone","$eventcatcher","$keyboard","$link","$list filter=x variable=x","$radio","$reveal type=nomatch","$scrollable","$select","$view field=x"],function(tag) {
it(`${tag} cleans itself up if children rendering fails`, function() {
var wiki = new $tw.Wiki();
wiki.addTiddler({title: "TiddlerOne", text: `<$tiddler tiddler='TiddlerOne'><${tag}><$transclude />`});
var parseTreeNode = {type: "widget", children: [
{type: "transclude", attributes: {
"tiddler": {type: "string", value: "TiddlerOne"}
}}
]};
// Construct the widget node
var widgetNode = createWidgetNode(parseTreeNode,wiki);
// Render the widget node to the DOM
var wrapper = renderWidgetNode(widgetNode);
// We don't actually care exactly what the HTML contains,
// only that it's reasonably sized. If it's super large,
// that means the widget containing the bad transclusion
// didn't figure out how to clean itself up, and it cloned a bunch.
var html = wrapper.innerHTML;
expect(html).toContain("Recursive transclusion error in transclude widget");
expect(html.length).toBeLessThan(256, "CONTENTS: " + html);
});
});
it("should handle many-tiddler recursion with branching nodes", function() {
var wiki = new $tw.Wiki();
// Add a tiddler
editions/tw5.com/tiddlers/releasenotes/5.4.0/#9548.tid
+10
View File
@@ -0,0 +1,10 @@
title: $:/changenotes/5.4.0/#9548
description: Better infinite transclude recursion handling
release: 5.4.0
tags: $:/tags/ChangeNote
change-type: bugfix
change-category: widget
github-links: https://github.com/TiddlyWiki/TiddlyWiki5/pull/9458
github-contributors: Flibbles
Fixed issue where exceptions occurring during widget rendering could result in junk DOM nodes remaining in widget tree. This was very obvious when max recursion depth exceptions occurred.