From 97dff042f752ee29cc2b08453652a74935ff2825 Mon Sep 17 00:00:00 2001 From: "jeremy@jermolene.com" Date: Wed, 4 Aug 2021 17:00:42 +0100 Subject: [PATCH] Reveal widget: fix crash when popup tiddler is refreshed but the popup is not displayed --- core/modules/widgets/reveal.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/modules/widgets/reveal.js b/core/modules/widgets/reveal.js index aedca6183..46e55e99e 100755 --- a/core/modules/widgets/reveal.js +++ b/core/modules/widgets/reveal.js @@ -226,7 +226,7 @@ RevealWidget.prototype.refresh = function(changedTiddlers) { this.refreshSelf(); return true; } - } else if(this.type === "popup" && this.updatePopupPosition && (changedTiddlers[this.state] || changedTiddlers[this.stateTitle])) { + } else if(this.type === "popup" && this.isOpen && this.updatePopupPosition && (changedTiddlers[this.state] || changedTiddlers[this.stateTitle])) { this.positionPopup(this.domNode); } if(changedAttributes.style) {