mirrors/TiddlyWiki5
1
0
Fork 0
mirror of https://github.com/Jermolene/TiddlyWiki5 synced 2025-09-10 14:56:06 +00:00
Code Issues Releases Wiki Activity

No indeterminate checkboxes in simple modes

Browse Source 
The simple checkbox modes (field and index) should not produce
indeterminate checkboxes. That should be reserved for the advanced modes
(list and filter).
This commit is contained in:
Robin Munn
2022-03-25 10:37:17 +07:00
parent 45215b9e7c
commit 88854720f5
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
core/modules/widgets/checkbox.js
View File

@@ -92,9 +92,7 @@ CheckboxWidget.prototype.getValue = function() {
if(this.checkboxUnchecked && !this.checkboxChecked) { if(this.checkboxUnchecked && !this.checkboxChecked) {
return true; // Absence of unchecked value return true; // Absence of unchecked value
} }
if(this.checkboxChecked && this.checkboxUnchecked) { // Do *not* return `undefined` in field or index mode: no indeterminate checkboxes in these modes
return undefined; // Will be rendered as indeterminate
}
} }
if(this.checkboxListField || this.checkboxFilter) { if(this.checkboxListField || this.checkboxFilter) {
// Same logic applies to lists and filters // Same logic applies to lists and filters