From 847727146ef401242ef4e000d8411f6180e4a2fe Mon Sep 17 00:00:00 2001 From: Rob Hoelz Date: Thu, 29 Jun 2017 11:07:23 -0500 Subject: [PATCH] Fix issue 2850 (#2852) * Trim tiddler titles imported via JSON Otherwise, it's possible to create a tiddler with a trailing space (or a leading one, I suppose) in its title. TiddlyWiki, in general, trims titles before operating on a tiddler, so having a tiddler with a trailing space ends up making that tiddler, for all intents and purposes, uneditable. Fixes GH #2850 * Signing the CLA --- core/modules/widgets/navigator.js | 1 + licenses/cla-individual.md | 2 ++ 2 files changed, 3 insertions(+) diff --git a/core/modules/widgets/navigator.js b/core/modules/widgets/navigator.js index 24a10ac9f..db68d18dd 100755 --- a/core/modules/widgets/navigator.js +++ b/core/modules/widgets/navigator.js @@ -532,6 +532,7 @@ NavigatorWidget.prototype.handleImportTiddlersEvent = function(event) { // Process each tiddler importData.tiddlers = importData.tiddlers || {}; $tw.utils.each(tiddlers,function(tiddlerFields) { + tiddlerFields.title = $tw.utils.trim(tiddlerFields.title); var title = tiddlerFields.title; if(title) { incomingTiddlers.push(title); diff --git a/licenses/cla-individual.md b/licenses/cla-individual.md index d800bfa74..044a21de9 100644 --- a/licenses/cla-individual.md +++ b/licenses/cla-individual.md @@ -317,4 +317,6 @@ Richard Decal, @crypdick, 2017/04/04 Adrian Morosanu, @morosanuae, 2017/06/02 +Rob Hoelz, @hoelzro, 2017/05/08 + Saq Imtiaz, @saqimtiaz, 2017/06/14