From 7f6d770ca6b7de2d5621706c0402d14bd65f7556 Mon Sep 17 00:00:00 2001 From: Jeremy Ruston Date: Wed, 16 Oct 2013 16:29:35 +0100 Subject: [PATCH] The reveal widget should generate a span when in inline mode The only reason that the reveal widget generates an element is so that we can use `display:none/block;` (as did the pre-refactored code) as a quick way of hiding and showing the content. We don't do that yet, and it may be best never to do it. --- core/modules/new_widgets/reveal.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/modules/new_widgets/reveal.js b/core/modules/new_widgets/reveal.js index 9bab01071..f4a4f00c4 100755 --- a/core/modules/new_widgets/reveal.js +++ b/core/modules/new_widgets/reveal.js @@ -30,7 +30,7 @@ RevealWidget.prototype.render = function(parent,nextSibling) { this.parentDomNode = parent; this.computeAttributes(); this.execute(); - var domNode = this.document.createElement("div"); + var domNode = this.document.createElement(this.parseTreeNode.isBlock ? "div" : "span"); parent.insertBefore(domNode,nextSibling); this.renderChildren(domNode,null); if(!domNode.isTiddlyWikiFakeDom && this.type === "popup" && this.isOpen) {