mirrors/TiddlyWiki5
1
0
Fork 0
mirror of https://github.com/Jermolene/TiddlyWiki5 synced 2025-06-23 17:04:06 +00:00
Code Issues Releases Wiki Activity

Consider non-existent tiddlers untagged (#6478)

Browse Source 
Fixes regression introduced in 575c23359.

Fixes: #6119
See-also: 575c23359 (Update untagged filter to avoid $tw.utils.pushTop (#6034), 2021-09-18)
This commit is contained in:
Ben Webber 2022-02-23 12:46:34 +00:00 committed by GitHub
parent d0b5b2124a
commit 7a7472833f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/modules/filters/untagged.js
View File

@ -19,7 +19,7 @@ exports.untagged = function(source,operator,options) {
var results = [], var results = [],
expected = (operator.prefix === "!"); expected = (operator.prefix === "!");
source(function(tiddler,title) { source(function(tiddler,title) {
if((tiddler && $tw.utils.isArray(tiddler.fields.tags) && tiddler.fields.tags.length > 0) === expected) { if(((tiddler && $tw.utils.isArray(tiddler.fields.tags) && tiddler.fields.tags.length > 0) === expected) || (!tiddler && !expected)) {
results.push(title); results.push(title);
} }
}); });

3
editions/test/tiddlers/tests/test-filters.js
View File

@ -428,6 +428,9 @@ Tests the filtering mechanism.
it("should handle the untagged operator", function() { it("should handle the untagged operator", function() {
expect(wiki.filterTiddlers("[untagged[]sort[title]]").join(",")).toBe("$:/ShadowPlugin,a fourth tiddler,filter regexp test,has filter,hasList,one"); expect(wiki.filterTiddlers("[untagged[]sort[title]]").join(",")).toBe("$:/ShadowPlugin,a fourth tiddler,filter regexp test,has filter,hasList,one");
expect(wiki.filterTiddlers("[!untagged[]sort[title]]").join(",")).toBe("$:/TiddlerTwo,Tiddler Three,TiddlerOne"); expect(wiki.filterTiddlers("[!untagged[]sort[title]]").join(",")).toBe("$:/TiddlerTwo,Tiddler Three,TiddlerOne");
// Should consider non-existent tiddlers untagged.
expect(wiki.filterTiddlers("[enlist[a b c]untagged[]]").join(",")).toBe("a,b,c");
expect(wiki.filterTiddlers("[enlist[a b c]!untagged[]]").join(",")).toBe("");
}); });
it("should handle the links operator", function() { it("should handle the links operator", function() {