mirrors/TiddlyWiki5
1
0
Fork 0
mirror of https://github.com/Jermolene/TiddlyWiki5 synced 2025-06-06 08:34:08 +00:00
Code Issues Releases Wiki Activity

Fix for "Open" tab placeholders in FireFox (#3806)

Browse Source 
* fix for "Open" tab placeholders in FireFox

this PR fixes the placeholders in FireFox not being removed on drag-leave from time to time

it consists of 2 mods where apparently both are needed:

- creating a `droppable-item` macro where whitespace is trimmed. that macro contains the droppable and inserts the placeholders
- removing the ` ` entity in favor of an inline style `height:2em;` on the placeholder div, putting it in a macro where whitespace can be trimmed, too

I'm investigating if there's a similar fix for the top page dropzone

* remove unnecessary whitespace trim, add css classes

`.tc-sidebar-tab-open-item { position: relative; }`

`.tc-sidebar-tab-open .tc-droppable-placeholer {  line-height:2em; height:2em; } `

* replace times entity with close-button

* add sidebar-open-tab styles
This commit is contained in:
Simon Huber 2019-03-02 14:54:23 +01:00 committed by Jeremy Ruston
parent 41e338dc41
commit 77e6f5c0e3
2 changed files with 31 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
core/ui/SideBar/Open.tid
View File

@ -9,23 +9,29 @@ caption: {{$:/language/SideBar/Open/Caption}}
<$action-listops $tiddler="$:/StoryList" $subfilter="+[insertbefore:currentTiddler<actionTiddler>]"/> <$action-listops $tiddler="$:/StoryList" $subfilter="+[insertbefore:currentTiddler<actionTiddler>]"/>
\end \end
<$list filter="[list[$:/StoryList]]" history="$:/HistoryList" storyview="pop"> \define placeholder()
<div style="position: relative;"> <div class="tc-droppable-placeholder"/>
\end
\define droppable-item(button)
\whitespace trim
<$droppable actions=<<drop-actions>>> <$droppable actions=<<drop-actions>>>
<div class="tc-droppable-placeholder"> <<placeholder>>
&nbsp;
</div>
<div> <div>
<$button message="tm-close-tiddler" tooltip={{$:/language/Buttons/Close/Hint}} aria-label={{$:/language/Buttons/Close/Caption}} class="tc-btn-invisible tc-btn-mini">&times;</$button> <$link to={{!!title}}><$view field="title"/></$link> $button$
</div> </div>
</$droppable> </$droppable>
\end
<div class="tc-sidebar-tab-open">
<$list filter="[list[$:/StoryList]]" history="$:/HistoryList" storyview="pop">
<div class="tc-sidebar-tab-open-item">
<$macrocall $name="droppable-item" button="""<$button message="tm-close-tiddler" tooltip={{$:/language/Buttons/Close/Hint}} aria-label={{$:/language/Buttons/Close/Caption}} class="tc-btn-invisible tc-btn-mini">{{$:/core/images/close-button}}</$button>&nbsp;<$link to={{!!title}}><$view field="title"/></$link>"""/>
</div> </div>
</$list> </$list>
<$tiddler tiddler=""> <$tiddler tiddler="">
<$droppable actions=<<drop-actions>>> <div>
<div class="tc-droppable-placeholder"> <$macrocall $name="droppable-item" button="""<$button message="tm-close-all-tiddlers" class="tc-btn-invisible tc-btn-mini"><<lingo Button>></$button>"""/>
&nbsp;
</div> </div>
<$button message="tm-close-all-tiddlers" class="tc-btn-invisible tc-btn-mini"><<lingo Button>></$button>
</$droppable>
</$tiddler> </$tiddler>
</div>

14
themes/tiddlywiki/vanilla/base.tid
View File

@ -384,6 +384,20 @@ a.tc-tiddlylink-external:hover {
cursor: move; cursor: move;
} }
.tc-sidebar-tab-open .tc-droppable-placeholder {
line-height: 2em;
height: 2em;
}
.tc-sidebar-tab-open-item {
position: relative;
}
.tc-sidebar-tab-open .tc-btn-invisible.tc-btn-mini svg {
font-size: 0.7em;
fill: <<colour muted-foreground>>;
}
/* /*
** Plugin reload warning ** Plugin reload warning
*/ */