From 74172b35ceae84f254e20d6d7ec4dff2cca692b1 Mon Sep 17 00:00:00 2001
From: Simon Huber <huber.simon@protonmail.com>
Date: Sat, 12 Oct 2019 11:01:27 +0200
Subject: [PATCH] Fix: make tag-picker "add-tag" button more consistent (#4199)

* make tag-picker add-button compliant with enter-actions

... the `$actions$` way throws a filter syntax error in some cases, the `<<add-tag-actions>>` way is more solid

* Update tags.tid

remove tag-picker-actions
---
 core/ui/EditTemplate/tags.tid   | 10 +---------
 core/wiki/macros/tag-picker.tid |  6 ++----
 2 files changed, 3 insertions(+), 13 deletions(-)

diff --git a/core/ui/EditTemplate/tags.tid b/core/ui/EditTemplate/tags.tid
index d368ce491..0bc581592 100644
--- a/core/ui/EditTemplate/tags.tid
+++ b/core/ui/EditTemplate/tags.tid
@@ -25,14 +25,6 @@ color:$(foregroundColor)$;
 <$macrocall $name="tag-body-inner" colour="""$colour$""" fallbackTarget={{$palette$##tag-background}} colourA={{$palette$##foreground}} colourB={{$palette$##background}} icon="""$icon$"""/>
 \end
 
-\define tag-picker-actions()
-<$action-listops
-	$tiddler=<<currentTiddler>>
-	$field="tags"
-	$subfilter="[<tag>] [all[current]tags[]]"
-/>
-\end
-
 <div class="tc-edit-tags">
 <$fieldmangler>
 <$list filter="[all[current]tags[]sort[title]]" storyview="pop">
@@ -40,6 +32,6 @@ color:$(foregroundColor)$;
 </$list>
 </$fieldmangler>
 <$set name="tabIndex" value={{$:/config/EditTabIndex}}>
-<$macrocall $name="tag-picker" actions=<<tag-picker-actions>>/>
+<$macrocall $name="tag-picker"/>
 </$set>
 </div>
diff --git a/core/wiki/macros/tag-picker.tid b/core/wiki/macros/tag-picker.tid
index 52b19bb4b..9f29c3665 100644
--- a/core/wiki/macros/tag-picker.tid
+++ b/core/wiki/macros/tag-picker.tid
@@ -14,8 +14,7 @@ $(actions)$
 </$button>
 \end
 
-\define tag-picker(actions)
-<$set name="actions" value="""$actions$""">
+\define tag-picker()
 <div class="tc-edit-add-tag">
 <span class="tc-add-tag-name">
 <$keyboard key="ENTER" actions=<<add-tag-actions>>>
@@ -24,7 +23,7 @@ $(actions)$
 </span> <$button popup=<<qualify "$:/state/popup/tags-auto-complete">> class="tc-btn-invisible" tooltip={{$:/language/EditTemplate/Tags/Dropdown/Hint}} aria-label={{$:/language/EditTemplate/Tags/Dropdown/Caption}}>{{$:/core/images/down-arrow}}</$button> <span class="tc-add-tag-button">
 <$set name="tag" value={{$:/temp/NewTagName}}>
 <$button set="$:/temp/NewTagName" setTo="" class="">
-$actions$
+<<add-tag-actions>>
 <$action-deletetiddler $tiddler="$:/temp/NewTagName"/>
 {{$:/language/EditTemplate/Tags/Add/Button}}
 </$button>
@@ -46,5 +45,4 @@ $actions$
 </div>
 </$reveal>
 </div>
-</$set>
 \end