Remove undo/redo formatting toolbar buttons

There have been long standing problems with the buttons not working in
Firefox, and now a [further
problem](https://groups.google.com/d/msg/tiddlywiki/GlsruQyPOag/BAhnI2mt
BgAJ) has come to light, and been similarly hard to resolve.

On balance, I’ve decided to remove the undo/redo buttons from the
toolbar (the ctrl/cmd-Z shortcut is still operational), thus avoiding
the problems, and saving some space in the core.
This commit is contained in:
Jermolene 2016-05-01 13:51:45 +01:00
parent 727b7b1ed0
commit 72fb1e22ed
17 changed files with 2 additions and 162 deletions

View File

@ -1,11 +0,0 @@
title: $:/core/images/redo
tags: $:/tags/Image
<svg class="tc-image-redo tc-image-button" width="22pt" height="22pt" viewBox="0 0 128 128">
<g fill-rule="evenodd">
<g transform="translate(180.233611, 192.389922) rotate(75.000000) translate(-180.233611, -192.389922) translate(120.265583, 131.702450)">
<path d="M18.9270186,45.959338 L18.9080585,49.6521741 C18.8884833,53.4648378 21.0574548,58.7482162 23.7526408,61.4434022 L78.5671839,116.257945 C81.2617332,118.952495 85.6348701,118.950391 88.3334363,116.251825 L115.863237,88.7220241 C118.555265,86.0299959 118.564544,81.6509578 115.869358,78.9557717 L61.0548144,24.1412286 C58.3602652,21.4466794 53.0787224,19.2788426 49.2595808,19.3006519 L25.9781737,19.4336012 C22.1633003,19.4553862 19.0471195,22.5673232 19.0275223,26.3842526 L18.9871663,34.2443819 C19.0818862,34.255617 19.1779758,34.2665345 19.2754441,34.2771502 C22.6891275,34.6489512 27.0485594,34.2348566 31.513244,33.2285542 C31.7789418,32.8671684 32.075337,32.5211298 32.4024112,32.1940556 C34.8567584,29.7397084 38.3789778,29.0128681 41.4406288,30.0213822 C41.5958829,29.9543375 41.7503946,29.8866669 41.9041198,29.8183808 L42.1110981,30.2733467 C43.1114373,30.6972371 44.0473796,31.3160521 44.8614145,32.1300869 C48.2842088,35.5528813 48.2555691,41.130967 44.7974459,44.5890903 C41.4339531,47.952583 36.0649346,48.0717177 32.6241879,44.9262969 C27.8170558,45.8919233 23.0726921,46.2881596 18.9270186,45.959338 Z"></path>
</g>
<path d="M18.8529698,78.5795551 C23.3328659,63.5664388 36.4624607,51.963543 53.0163903,50.2236549 C71.9131923,48.237521 89.1174496,59.7506654 95.0305381,76.990276 L81.4478553,74.2761325 C77.1152305,73.4103709 72.9011058,76.2208188 72.0353441,80.5534435 C71.1695825,84.8860683 73.9800304,89.1001931 78.3126552,89.9659547 L110.20387,96.3385789 C114.552025,97.2074438 118.777398,94.374003 119.624223,90.0215022 L125.868734,57.9260056 C126.712534,53.5890501 123.880771,49.3892183 119.543816,48.5454187 C115.20686,47.7016191 111.007029,50.5333814 110.163229,54.8703368 L107.942537,66.2842329 C98.1106587,45.2478605 75.7343285,31.7477709 51.3439349,34.3113046 C27.7065732,36.7956914 9.05626438,53.6441356 3.1546605,75.271795 L3.19465925,75.28219 C2.54845483,78.156707 3.52095928,81.28061 5.9657019,83.2603235 C9.3993488,86.040836 14.4369203,85.5113659 17.2174327,82.077719 C18.0696751,81.0252872 18.6109591,79.8221738 18.8529698,78.5795551 L18.8529698,78.5795551 L18.8529698,78.5795551 Z M112.379785,80.4570687 C112.422777,80.7070229 112.464145,80.9576094 112.503877,81.2088183 L113.33907,80.6487567 L112.379785,80.4570687 L112.379785,80.4570687 L112.379785,80.4570687 Z"></path>
</g>
</svg>

View File

@ -1,8 +0,0 @@
title: $:/core/images/undo
tags: $:/tags/Image
<svg class="tc-image-undo tc-image-button" width="22pt" height="22pt" viewBox="0 0 128 128">
<g fill-rule="evenodd">
<path d="M110.164509,78.5795551 C105.684613,63.5664388 92.5550183,51.963543 76.0010887,50.2236549 C57.1042867,48.237521 39.9000294,59.7506654 33.9869408,76.990276 L47.5696237,74.2761325 C51.9022484,73.4103709 56.1163732,76.2208188 56.9821348,80.5534435 C57.8478965,84.8860683 55.0374486,89.1001931 50.7048238,89.9659547 L18.813609,96.3385789 C14.4654544,97.2074438 10.2400805,94.374003 9.39325638,90.0215022 L3.148745,57.9260056 C2.30494538,53.5890501 5.1367077,49.3892183 9.47366316,48.5454187 C13.8106186,47.7016191 18.0104504,50.5333814 18.85425,54.8703368 L21.0749418,66.2842329 C30.9068203,45.2478605 53.2831505,31.7477709 77.6735441,34.3113046 C101.310906,36.7956914 119.961215,53.6441356 125.862818,75.271795 L125.82282,75.28219 C126.469024,78.156707 125.49652,81.28061 123.051777,83.2603235 C119.61813,86.040836 114.580559,85.5113659 111.800046,82.077719 C110.947804,81.0252872 110.40652,79.8221738 110.164509,78.5795551 L110.164509,78.5795551 Z M16.6376942,80.4570687 C16.594702,80.7070229 16.5533338,80.9576094 16.5136018,81.2088183 L15.6784088,80.6487567 L16.6376942,80.4570687 L16.6376942,80.4570687 Z"></path>
</g>
</svg>

View File

@ -149,8 +149,6 @@ PreviewType/Caption: preview type
PreviewType/Hint: Choose preview type
Quote/Caption: quote
Quote/Hint: Apply quoted text formatting to lines containing selection
Redo/Caption: redo
Redo/Hint: Redo the last action to be undone
Size/Caption: image size
Size/Caption/Height: Height:
Size/Caption/Resize: Resize image
@ -169,6 +167,4 @@ Superscript/Caption: superscript
Superscript/Hint: Apply superscript formatting to selection
Underline/Caption: underline
Underline/Hint: Apply underline formatting to selection
Undo/Caption: undo
Undo/Hint: Undo the last action

View File

@ -196,31 +196,6 @@ FramedEngine.prototype.executeTextOperation = function(operation) {
return newText;
};
/*
Execute a command
*/
FramedEngine.prototype.execCommand = function(command) {
var msg = "Warning: the '" + command + "' button does not work in Firefox without installing the CodeMirror plugin.\n\n(Standard operating system keyboard shortcuts will work correctly)";
this.iframeNode.focus();
this.domNode.focus();
switch(command) {
case "undo":
if($tw.browser.isFirefox) {
alert(msg);
} else {
this.iframeDoc.execCommand("undo",false,null);
}
break;
case "redo":
if($tw.browser.isFirefox) {
alert(msg);
} else {
this.iframeDoc.execCommand("redo",false,null);
}
break;
}
};
exports.FramedEngine = FramedEngine;
})();

View File

@ -1,19 +0,0 @@
/*\
title: $:/core/modules/editor/operations/text/redo.js
type: application/javascript
module-type: texteditoroperation
Text editor operation to tell the browser to perform an redo
\*/
(function(){
/*jslint node: true, browser: true */
/*global $tw: false */
"use strict";
exports["redo"] = function(event,operation) {
this.execCommand("redo");
};
})();

View File

@ -1,19 +0,0 @@
/*\
title: $:/core/modules/editor/operations/text/undo.js
type: application/javascript
module-type: texteditoroperation
Text editor operation to tell the browser to perform an undo
\*/
(function(){
/*jslint node: true, browser: true */
/*global $tw: false */
"use strict";
exports["undo"] = function(event,operation) {
this.execCommand("undo");
};
})();

View File

@ -1,11 +0,0 @@
title: $:/core/ui/EditorToolbar/redo
tags: $:/tags/EditorToolbar
icon: $:/core/images/redo
caption: {{$:/language/Buttons/Redo/Caption}}
description: {{$:/language/Buttons/Redo/Hint}}
condition: [<targetTiddler>!is[image]]
<$action-sendmessage
$message="tm-edit-text-operation"
$param="redo"
/>

View File

@ -1,12 +0,0 @@
title: $:/core/ui/EditorToolbar/undo
tags: $:/tags/EditorToolbar
icon: $:/core/images/undo
caption: {{$:/language/Buttons/Undo/Caption}}
description: {{$:/language/Buttons/Undo/Hint}}
condition: [<targetTiddler>!is[image]]
button-classes: tc-text-editor-toolbar-item-start-group
<$action-sendmessage
$message="tm-edit-text-operation"
$param="undo"
/>

View File

@ -1,2 +1,2 @@
title: $:/tags/EditorToolbar
list: $:/core/ui/EditorToolbar/paint $:/core/ui/EditorToolbar/opacity $:/core/ui/EditorToolbar/line-width $:/core/ui/EditorToolbar/clear $:/core/ui/EditorToolbar/bold $:/core/ui/EditorToolbar/italic $:/core/ui/EditorToolbar/strikethrough $:/core/ui/EditorToolbar/underline $:/core/ui/EditorToolbar/superscript $:/core/ui/EditorToolbar/subscript $:/core/ui/EditorToolbar/mono-line $:/core/ui/EditorToolbar/mono-block $:/core/ui/EditorToolbar/quote $:/core/ui/EditorToolbar/list-bullet $:/core/ui/EditorToolbar/list-number $:/core/ui/EditorToolbar/heading-1 $:/core/ui/EditorToolbar/heading-2 $:/core/ui/EditorToolbar/heading-3 $:/core/ui/EditorToolbar/heading-4 $:/core/ui/EditorToolbar/heading-5 $:/core/ui/EditorToolbar/heading-6 $:/core/ui/EditorToolbar/link $:/core/ui/EditorToolbar/excise $:/core/ui/EditorToolbar/picture $:/core/ui/EditorToolbar/stamp $:/core/ui/EditorToolbar/undo $:/core/ui/EditorToolbar/redo $:/core/ui/EditorToolbar/size $:/core/ui/EditorToolbar/editor-height $:/core/ui/EditorToolbar/more $:/core/ui/EditorToolbar/preview $:/core/ui/EditorToolbar/preview-type
list: $:/core/ui/EditorToolbar/paint $:/core/ui/EditorToolbar/opacity $:/core/ui/EditorToolbar/line-width $:/core/ui/EditorToolbar/clear $:/core/ui/EditorToolbar/bold $:/core/ui/EditorToolbar/italic $:/core/ui/EditorToolbar/strikethrough $:/core/ui/EditorToolbar/underline $:/core/ui/EditorToolbar/superscript $:/core/ui/EditorToolbar/subscript $:/core/ui/EditorToolbar/mono-line $:/core/ui/EditorToolbar/mono-block $:/core/ui/EditorToolbar/quote $:/core/ui/EditorToolbar/list-bullet $:/core/ui/EditorToolbar/list-number $:/core/ui/EditorToolbar/heading-1 $:/core/ui/EditorToolbar/heading-2 $:/core/ui/EditorToolbar/heading-3 $:/core/ui/EditorToolbar/heading-4 $:/core/ui/EditorToolbar/heading-5 $:/core/ui/EditorToolbar/heading-6 $:/core/ui/EditorToolbar/link $:/core/ui/EditorToolbar/excise $:/core/ui/EditorToolbar/picture $:/core/ui/EditorToolbar/stamp $:/core/ui/EditorToolbar/size $:/core/ui/EditorToolbar/editor-height $:/core/ui/EditorToolbar/more $:/core/ui/EditorToolbar/preview $:/core/ui/EditorToolbar/preview-type

View File

@ -19,26 +19,6 @@ Excises the currently selected text into a new tiddler and replaces it with a li
</div>
\end
\define undoDescription()
<div>
Undoes the last action in the editor. Has no additional parameters.
<<.tip "This directly uses the underlying `execCommand` browser method provided by a document in design mode.">>
</div>
\end
\define redoDescription()
<div>
Redoes the last action to be undone in the editor. Has no additional parameters.
<<.tip "This directly uses the underlying `execCommand` browser method provided by a document in design mode.">>
</div>
\end
\define replaceAllDescription()
<div>
@ -116,8 +96,6 @@ At this point the following text operations have been implemented:
|!Name |!Description |
|<<.def "excise">>|<<exciseDescription>> |
|<<.def "undo">>|<<undoDescription>> |
|<<.def "redo">>|<<redoDescription>> |
|<<.def "replace-all">>|<<replaceAllDescription>> |
|<<.def "replace-selection">>|<<replaceSelectionDescription>> |
|<<.def "prefix-lines">>|<<prefixLinesDescription>> |

View File

@ -124,8 +124,6 @@ PreviewType/Caption: forhåndsvisnings type
PreviewType/Hint: Vælg forhåndsvisnings type
Quote/Caption: Citat
Quote/Hint: Føj citat tekst formatering til linier indeholdende udvalgte
Redo/Caption: gentag
Redo/Hint: Gentag sidste handling der skal omgøres
Refresh/Caption: genopfrisk
Refresh/Hint: Udfør en fuld genopfriskning af wiki'en
Save/Caption: gem
@ -156,8 +154,6 @@ Theme/Caption: tema
Theme/Hint: Vælg visningstema
Underline/Caption: understregning
Underline/Hint: Føj understregnings formatering til udvalgte
Undo/Caption: fortryd
Undo/Hint: Fortryd sidste handling
Unfold/Caption: udfold tiddler
Unfold/Hint: Udfold denne tiddlers krop
UnfoldAll/Caption: udfold alle tiddlere

View File

@ -128,8 +128,6 @@ PreviewType/Caption: Tipo de vista previa
PreviewType/Hint: Selecciona el tipo de vista previa
Quote/Caption: Bloque de cita
Quote/Hint: Aplica formato de bloque de cita a la selección
Redo/Caption: Rehacer
Redo/Hint: Rehace la última acción deshecha
Refresh/Caption: Recargar
Refresh/Hint: Actualiza completamente este wiki
Save/Caption: Ok
@ -162,9 +160,7 @@ Theme/Caption: Tema
Theme/Hint: Selecciona un estilo visual para el wiki
Underline/Caption: Subrayado
Underline/Hint: Aplica formato de subrayado a la selección
Undo/Caption: Deshacer
Undo/Hint: Deshace la última acción
Unfold/Caption: Desplegar tiddler
Unfold/Hint: Despliega el cuerpo de este tiddler y muestra su contenido
UnfoldAll/Caption: Desplegar todos
UnfoldAll/Hint: Despliega y muestra el contenido de todos los tiddlers abiertos
UnfoldAll/Hint: Despliega y muestra el contenido de todos los tiddlers abiertos

View File

@ -147,8 +147,6 @@ PreviewType/Caption: type de prévisualisation
PreviewType/Hint: Choisit le type de prévisualisation
Quote/Caption: citation
Quote/Hint: Formate les lignes de la sélection comme une citation
Redo/Caption: rétablir
Redo/Hint: Rétablit la dernière action annulée
Size/Caption: taille de l'image
Size/Caption/Height: Hauteur :
Size/Caption/Resize: Retailler l'image
@ -167,5 +165,3 @@ Superscript/Caption: exposant
Superscript/Hint: Met en exposant le texte sélectionné
Underline/Caption: souligner
Underline/Hint: Souligne le texte sélectionné
Undo/Caption: annuler
Undo/Hint: Annule la dernière action

View File

@ -131,8 +131,6 @@ PreviewType/Caption: 미리 보기 형식
PreviewType/Hint: 미리 보기 형식을 선택합니다
Quote/Caption: 인용
Quote/Hint: 선택을 포함하는 줄에 인용 문구 서식을 적용합니다
Redo/Caption: 다시 실행
Redo/Hint: 실행 취소한 마지막 작업을 다시 실행합니다
Refresh/Caption: 새로 고침
Refresh/Hint: 위키의 전체 새로 고침을 수행합니다
Save/Caption: 확인
@ -165,8 +163,6 @@ Theme/Caption: 테마
Theme/Hint: 보일 테마를 선택합니다
Underline/Caption: 밑줄
Underline/Hint: 선택에 밑줄 서식을 적용합니다
Undo/Caption: 실행 취소
Undo/Hint: 마지막 작업을 실행 취소합니다
Unfold/Caption: 티들러 펼치기
Unfold/Hint: 이 티들러의 본문을 펼칩니다
UnfoldAll/Caption: 모든 티들러 펼치기

View File

@ -131,9 +131,6 @@ PreviewType/Caption: type voorbeeldweergave
PreviewType/Hint: Kies type voorbeeldweergave
Quote/Caption: 'blockquote'
Quote/Hint: Maak van selectie een 'blockqoute'
Redo/Caption: opnieuw
Redo/Hint: Doe opnieuw wat ongedaan gemaakt is
Refresh/Caption: ververs
Refresh/Hint: Ververs deze wiki
Save/Caption: opslaan
@ -166,8 +163,6 @@ Theme/Caption: thema
Theme/Hint: Kies het thema
Underline/Caption: onderstreept
Underline/Hint: Onderstreep het geselecteerde
Undo/Caption: maak ongedaan
Undo/Hint: Maak laatste actie ongedaan
Unfold/Caption: klap tiddler uit
Unfold/Hint: Klap de tekst van deze tiddler uit
UnfoldAll/Caption: klap alle tiddlers uit

View File

@ -149,8 +149,6 @@ PreviewType/Caption: 预览类型
PreviewType/Hint: 选择预览类型
Quote/Caption: 引言
Quote/Hint: 套用引言文本格式于包含所选文本的列
Redo/Caption: 恢复
Redo/Hint: 恢复上一次撤销的操作
Size/Caption: 图像大小
Size/Caption/Height: 高度︰
Size/Caption/Resize: 调整图像的大小
@ -169,5 +167,3 @@ Superscript/Caption: 上标
Superscript/Hint: 套用上标格式于所选文本
Underline/Caption: 下划线
Underline/Hint: 套用下划线格式于所选文本
Undo/Caption: 撤消
Undo/Hint: 撤消上一次的操作

View File

@ -149,8 +149,6 @@ PreviewType/Caption: 預覽類型
PreviewType/Hint: 選擇預覽類型
Quote/Caption: 引言
Quote/Hint: 套用引言文字格式於包含所選文字的列
Redo/Caption: 重做
Redo/Hint: 重做上一次還原的操作
Size/Caption: 圖像大小
Size/Caption/Height: 高度︰
Size/Caption/Resize: 調整圖像的大小
@ -169,5 +167,3 @@ Superscript/Caption: 上標
Superscript/Hint: 套用上標格式於所選文字
Underline/Caption: 底線
Underline/Hint: 套用底線格式於所選文字
Undo/Caption: 還原
Undo/Hint: 還原上一次的操作