From 6ac9592bd7594d77a7c3488791d6361c5322f8cb Mon Sep 17 00:00:00 2001
From: lin onetwo <linonetwo012@gmail.com>
Date: Mon, 5 Aug 2024 02:31:16 +0800
Subject: [PATCH] fix: void node need to handle its children

---
 .../modules/parsers/wikiparser/rules/commentblock.js |  3 ++-
 core/modules/parsers/wikiparser/rules/parsermode.js  |  1 +
 core/modules/widgets/void.js                         | 12 ++++++++----
 3 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/core/modules/parsers/wikiparser/rules/commentblock.js b/core/modules/parsers/wikiparser/rules/commentblock.js
index a1510b8bc..7d9a68f14 100644
--- a/core/modules/parsers/wikiparser/rules/commentblock.js
+++ b/core/modules/parsers/wikiparser/rules/commentblock.js
@@ -25,7 +25,7 @@ Note that the syntax for comments is simplified to an opening "<!--" sequence an
 "use strict";
 
 exports.name = "commentblock";
-exports.types = {block:true};
+exports.types = {block: true, pragma: true};
 
 exports.init = function(parser) {
 	this.parser = parser;
@@ -56,6 +56,7 @@ exports.parse = function() {
 	var commentText = this.parser.source.slice(commentStart, commentEnd);
 	return [{
 			type: "void",
+			children: [],
 			text: commentText,
 			start: commentStart,
 			end: commentEnd
diff --git a/core/modules/parsers/wikiparser/rules/parsermode.js b/core/modules/parsers/wikiparser/rules/parsermode.js
index ba165a283..b57bdae4d 100644
--- a/core/modules/parsers/wikiparser/rules/parsermode.js
+++ b/core/modules/parsers/wikiparser/rules/parsermode.js
@@ -64,6 +64,7 @@ exports.parse = function() {
 	}
 	return [{
 		type: "void",
+		children: [],
 		parseAsInline: this.parser.parseAsInline,
 		start: start,
 		end: this.parser.pos
diff --git a/core/modules/widgets/void.js b/core/modules/widgets/void.js
index e7b982a35..cc8e803c0 100755
--- a/core/modules/widgets/void.js
+++ b/core/modules/widgets/void.js
@@ -3,7 +3,7 @@ title: $:/core/modules/widgets/Void.js
 type: application/javascript
 module-type: widget
 
-Void widget that is not intended for render.
+Void widget that is not intended for render. It still renders all its children.
 
 \*/
 (function(){
@@ -27,21 +27,25 @@ VoidNodeWidget.prototype = new Widget();
 Render this widget into the DOM
 */
 VoidNodeWidget.prototype.render = function(parent,nextSibling) {
-	// Nothing to do for a void node
+	// Nothing to do for a void node, but render the children. Nodes generated by pragma rules are holding everything below it in the children.
+	this.parentDomNode = parent;
+	this.execute();
+	this.renderChildren(parent,nextSibling);
 };
 
 /*
 Compute the internal state of the widget
 */
 VoidNodeWidget.prototype.execute = function() {
-	// Nothing to do for a void node
+	// Nothing to do for a void node, but construct the child widgets
+	this.makeChildWidgets();
 };
 
 /*
 Selectively refreshes the widget if needed. Returns true if the widget or any of its children needed re-rendering
 */
 VoidNodeWidget.prototype.refresh = function(changedTiddlers) {
-	return false;
+	return this.refreshChildren(changedTiddlers);
 };
 
 exports.void = VoidNodeWidget;