mirrors/TiddlyWiki5
1
0
Fork 0
mirror of https://github.com/Jermolene/TiddlyWiki5 synced 2025-11-04 01:23:01 +00:00
Code Issues Releases Wiki Activity

Refactor story macro to use reexecuteInDom()

Browse Source
This commit is contained in:
Jeremy Ruston
2012-10-15 22:02:12 +01:00
parent cec60db30d
commit 5a3e2ce438
1 changed files with 1 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
core/modules/macros/story/story.js
View File

@@ -231,16 +231,7 @@ exports.postRenderInDom = function() {
exports.refreshInDom = function(changes) { exports.refreshInDom = function(changes) {
// If the storyview has changed we'll have to completely re-execute the macro // If the storyview has changed we'll have to completely re-execute the macro
if(this.hasParameter("storyviewTiddler") && $tw.utils.hop(changes,this.params.storyviewTiddler)) { if(this.hasParameter("storyviewTiddler") && $tw.utils.hop(changes,this.params.storyviewTiddler)) {
// This logic should be reused from the base macro class, and not duplicated this.reexecuteInDom();
var child = this.child;
while(!child.domNode && child.child) {
child = child.child;
}
var parentDomNode = child.domNode.parentNode,
insertBefore = child.domNode.nextSibling;
parentDomNode.removeChild(child.domNode);
this.execute(this.parents,this.tiddlerTitle);
this.renderInDom(parentDomNode,insertBefore);
return; return;
} }
// If the story tiddler has changed we need to sync the story elements // If the story tiddler has changed we need to sync the story elements