mirrors/TiddlyWiki5
1
0
Fork 0
mirror of https://github.com/Jermolene/TiddlyWiki5 synced 2025-08-09 07:15:39 +00:00
Code Issues Releases Wiki Activity

Extend tm-open-window to support optional top and left position for new browser window (#6470)

Browse Source 
* feat: extend tm-open-window to support optional top and left position for new browser window

* fix: whitespace correction

* Update WidgetMessage_ tm-open-window.tid
This commit is contained in:
Saq Imtiaz 2022-02-20 12:23:27 +01:00 committed by GitHub
parent 1d16206188
commit 59572cd75d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
core/modules/startup/windows.js
View File

@ -32,13 +32,15 @@ exports.startup = function() {
template = paramObject.template || "$:/core/templates/single.tiddler.window", template = paramObject.template || "$:/core/templates/single.tiddler.window",
width = paramObject.width || "700", width = paramObject.width || "700",
height = paramObject.height || "600", height = paramObject.height || "600",
top = paramObject.top,
left = paramObject.left,
variables = $tw.utils.extend({},paramObject,{currentTiddler: title}); variables = $tw.utils.extend({},paramObject,{currentTiddler: title});
// Open the window // Open the window
var srcWindow, var srcWindow,
srcDocument; srcDocument;
// In case that popup blockers deny opening a new window // In case that popup blockers deny opening a new window
try { try {
srcWindow = window.open("","external-" + title,"scrollbars,width=" + width + ",height=" + height), srcWindow = window.open("","external-" + title,"scrollbars,width=" + width + ",height=" + height + (top ? ",top=" + top : "" ) + (left ? ",left=" + left : "" )),
srcDocument = srcWindow.document; srcDocument = srcWindow.document;
} }
catch(e) { catch(e) {

8
editions/tw5.com/tiddlers/messages/WidgetMessage_ tm-open-window.tid
View File

@ -1,11 +1,11 @@
caption: tm-open-window caption: tm-open-window
created: 20160424181447704 created: 20160424181447704
modified: 20211117042202771 modified: 20220219125413255
tags: Messages tags: Messages
title: WidgetMessage: tm-open-window title: WidgetMessage: tm-open-window
type: text/vnd.tiddlywiki type: text/vnd.tiddlywiki
The `tm-open-window` [[message|Message]] opens a tiddler in a new //browser// window. If no parameters are specified, the current tiddler is opened in a new window. Similiar to `tm-modal` any additional parameters passed via the <<.param "paramObject">> are provided as variables to the new window. The `tm-open-window` [[message|Messages]] opens a tiddler in a new //browser// window. If no parameters are specified, the current tiddler is opened in a new window. Similiar to `tm-modal` any additional parameters passed via the <<.param "paramObject">> are provided as variables to the new window.
|!Name |!Description | |!Name |!Description |
|param |Title of the tiddler to be opened in a new browser window, defaults to <<.var "currentTiddler">> if empty | |param |Title of the tiddler to be opened in a new browser window, defaults to <<.var "currentTiddler">> if empty |
@ -13,12 +13,14 @@ The `tm-open-window` [[message|Message]] opens a tiddler in a new //browser// wi
|windowTitle |Title string for the opened window | |windowTitle |Title string for the opened window |
|width |Width of the new browser window | |width |Width of the new browser window |
|height |Height of the new browser window | |height |Height of the new browser window |
|left|<<.from-version "5.2.2">> Optional, left position of new browser window|
|top|<<.from-version "5.2.2">> Optional, top position of new browser window|
|paramObject |Hashmap of variables to be provided to the modal, contains all extra parameters passed to the widget sending the message. | |paramObject |Hashmap of variables to be provided to the modal, contains all extra parameters passed to the widget sending the message. |
The `tm-open-window` message is best generated with the ActionSendMessageWidget, which in turn is triggered by a widget such as the ButtonWidget. It is handled by the core itself. The `tm-open-window` message is best generated with the ActionSendMessageWidget, which in turn is triggered by a widget such as the ButtonWidget. It is handled by the core itself.
<<.tip """When used with the ActionSendMessageWidget, <<.param 'param'>> becomes <<.param '$param'>> """>> <<.tip """When used with the ActionSendMessageWidget, <<.param 'param'>> becomes <<.param '$param'>> """>>
<<.tip """Parameters <<.param template>>, <<.param windowTitle>>, <<.param width>>, and <<.param height>> require the ActionSendMessageWidget.""">> <<.tip """Parameters <<.param template>>, <<.param windowTitle>>, <<.param width>>, <<.param height>>, <<.param left>> and <<.param top>> require the ActionSendMessageWidget.""">>
<$macrocall $name='wikitext-example-without-html' <$macrocall $name='wikitext-example-without-html'