From 5226c7a2fa64afbf09016655e25495714d565edf Mon Sep 17 00:00:00 2001 From: Devin Weaver Date: Fri, 25 Apr 2014 08:46:51 -0400 Subject: [PATCH] Prevent saving un-modified tiddlers When saving a tiddler we check to see if the tiddler has changed (isModified) if it hasn't then bounce the event to tw-cancel-tiddler instead. Addresses first line item in issue #570 --- core/modules/widgets/navigator.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/core/modules/widgets/navigator.js b/core/modules/widgets/navigator.js index 60c917e38..eb0d5425a 100755 --- a/core/modules/widgets/navigator.js +++ b/core/modules/widgets/navigator.js @@ -296,12 +296,14 @@ NavigatorWidget.prototype.handleSaveTiddlerEvent = function(event) { {title: draftTitle} } )); - } - if(isConfirmed) { + } else if(!tiddler.isModified()) { + event.type = "tw-cancel-tiddler"; + this.dispatchEvent(event); + } else if(isConfirmed) { // Save the draft tiddler as the real tiddler this.wiki.addTiddler(new $tw.Tiddler(this.wiki.getCreationFields(),tiddler,{ title: draftTitle, - "draft.title": undefined, + "draft.title": undefined, "draft.of": undefined },this.wiki.getModificationFields())); // Remove the draft tiddler