mirrors/TiddlyWiki5
1
0
Fork 0
mirror of https://github.com/Jermolene/TiddlyWiki5 synced 2025-06-30 00:52:52 +00:00
Code Issues Releases Wiki Activity

Refactored link classes allocation

Browse Source 
Don't need the classesForLink() method anymore. Also avoid modifying
the argument to adjustClassesForLink().
This commit is contained in:
Jeremy Ruston 2012-01-15 13:48:13 +00:00
parent 4681d14f39
commit 4df13a3e24
1 changed files with 7 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
js/WikiStore.js
View File

@ -235,16 +235,17 @@ WikiStore.prototype.deserializeTiddlers = function(type,text,srcFields) {
}; };
WikiStore.prototype.adjustClassesForLink = function(classes,target) { WikiStore.prototype.adjustClassesForLink = function(classes,target) {
var externalRegExp = /(?:file|http|https|mailto|ftp|irc|news|data):[^\s'"]+(?:\/|\b)/i, var newClasses = classes.slice(0),
externalRegExp = /(?:file|http|https|mailto|ftp|irc|news|data):[^\s'"]+(?:\/|\b)/i,
setClass = function(className) { setClass = function(className) {
if(classes.indexOf(className) === -1) { if(newClasses.indexOf(className) === -1) {
classes.push(className); newClasses.push(className);
} }
}, },
removeClass = function(className) { removeClass = function(className) {
var p = classes.indexOf(className); var p = newClasses.indexOf(className);
if(p !== -1) { if(p !== -1) {
classes.splice(p,1); newClasses.splice(p,1);
} }
}; };
// Make sure we've got the main link class // Make sure we've got the main link class
@ -266,13 +267,7 @@ WikiStore.prototype.adjustClassesForLink = function(classes,target) {
removeClass("tw-tiddlylink-resolves"); removeClass("tw-tiddlylink-resolves");
setClass("tw-tiddlylink-missing"); setClass("tw-tiddlylink-missing");
} }
return classes; return newClasses;
};
WikiStore.prototype.classesForLink = function(target) {
var classes = ["tw-tiddlylink"];
this.adjustClassesForLink(classes,target);
return " class=\"" + classes.join(" ") + "\"";
}; };
WikiStore.prototype.parseText = function(type,text) { WikiStore.prototype.parseText = function(type,text) {