From 4699db9f897e7ce44dd9ad80a6c9449e4198fc7a Mon Sep 17 00:00:00 2001 From: Saq Imtiaz Date: Fri, 10 Apr 2026 12:22:41 +0200 Subject: [PATCH] Revert "Fix side effects of PR 9316 (#9568)" (#9798) This reverts commit bf7c0b575c6278a0154edf24dc6064fb4b7f73ad. --- core/ui/EditTemplate/tags.tid | 2 +- editions/tw5.com/tiddlers/releasenotes/5.4.0/#9316.tid | 2 +- themes/tiddlywiki/seamless/base.tid | 2 +- themes/tiddlywiki/snowwhite/base.tid | 2 +- themes/tiddlywiki/vanilla/base.tid | 5 ----- 5 files changed, 4 insertions(+), 9 deletions(-) diff --git a/core/ui/EditTemplate/tags.tid b/core/ui/EditTemplate/tags.tid index a2bf6b4658..298120606d 100644 --- a/core/ui/EditTemplate/tags.tid +++ b/core/ui/EditTemplate/tags.tid @@ -17,7 +17,7 @@ tags: $:/tags/EditTemplate <$let backgroundColor=<> > > - style=`color:$(foregroundColor)$; background-color:$(backgroundColor)$; --tp-remove-tag-button-color:$(foregroundColor)$` + style=`color:$(foregroundColor)$; background-color:$(backgroundColor)$;` > <$transclude tiddler=<>/> <$view field="title" format="text"/> diff --git a/editions/tw5.com/tiddlers/releasenotes/5.4.0/#9316.tid b/editions/tw5.com/tiddlers/releasenotes/5.4.0/#9316.tid index def69c2606..cb1b24d0f8 100644 --- a/editions/tw5.com/tiddlers/releasenotes/5.4.0/#9316.tid +++ b/editions/tw5.com/tiddlers/releasenotes/5.4.0/#9316.tid @@ -4,7 +4,7 @@ release: 5.4.0 tags: $:/tags/ChangeNote change-type: enhancement change-category: theme -github-links: https://github.com/TiddlyWiki/TiddlyWiki5/pull/9316 https://github.com/TiddlyWiki/TiddlyWiki5/pull/9568 +github-links: https://github.com/TiddlyWiki/TiddlyWiki5/pull/9316 github-contributors: Leilei332 Replaces hardcoded `fill` attributes with one `fill: currentColor` rule to solve the compatibility issues of migrating to lucide icons. \ No newline at end of file diff --git a/themes/tiddlywiki/seamless/base.tid b/themes/tiddlywiki/seamless/base.tid index 4fe2371186..0f07c35295 100644 --- a/themes/tiddlywiki/seamless/base.tid +++ b/themes/tiddlywiki/seamless/base.tid @@ -9,7 +9,7 @@ Rules copied from Snow White */ .tc-page-controls button svg, .tc-tiddler-controls button svg, .tc-topbar button svg { - transition: color 150ms ease-in-out; + <> } .tc-tiddler-controls button.tc-selected svg { diff --git a/themes/tiddlywiki/snowwhite/base.tid b/themes/tiddlywiki/snowwhite/base.tid index ce9250e176..051cc5e8db 100644 --- a/themes/tiddlywiki/snowwhite/base.tid +++ b/themes/tiddlywiki/snowwhite/base.tid @@ -28,7 +28,7 @@ tags: [[$:/tags/Stylesheet]] } .tc-page-controls button svg, .tc-tiddler-controls button svg, .tc-topbar button svg { - transition: color 150ms ease-in-out; + transition: fill 150ms ease-in-out; } .tc-tiddler-controls button.tc-selected, diff --git a/themes/tiddlywiki/vanilla/base.tid b/themes/tiddlywiki/vanilla/base.tid index 1ffd25c456..b5bedd5fbc 100644 --- a/themes/tiddlywiki/vanilla/base.tid +++ b/themes/tiddlywiki/vanilla/base.tid @@ -852,7 +852,6 @@ button.tc-untagged-label { .tc-edit-tags button.tc-remove-tag-button svg { font-size: 0.7em; vertical-align: middle; - color: var(--tp-remove-tag-button-color); } .tc-tag-manager-table .tc-tag-label { @@ -2755,10 +2754,6 @@ a.tc-tiddlylink.tc-plugin-info:hover > .tc-plugin-info-chunk .tc-plugin-info-sta padding: 3px; } -.tc-install-plugin > svg { - color: white; -} - .tc-install-plugin.tc-reinstall-downgrade { background: red; }