From 4425a891bc33b3e7eaffa5d6bb934cce84e57c97 Mon Sep 17 00:00:00 2001
From: Cameron Fischer <fischer.cameron@gmail.com>
Date: Fri, 14 Feb 2025 12:57:06 -0500
Subject: [PATCH] Addresses #7836: Noisy $fill widgets (#8930)

$fill widgets will get ignored when encountered by ts-raw slots
---
 core/modules/widgets/fill.js                  |  4 +++
 .../transclude/CustomWidget-RawAndSlotted.tid | 34 +++++++++++++++++++
 2 files changed, 38 insertions(+)
 create mode 100644 editions/test/tiddlers/tests/data/transclude/CustomWidget-RawAndSlotted.tid

diff --git a/core/modules/widgets/fill.js b/core/modules/widgets/fill.js
index de88c95af..870bf7878 100644
--- a/core/modules/widgets/fill.js
+++ b/core/modules/widgets/fill.js
@@ -24,6 +24,10 @@ Inherit from the base widget class
 */
 FillWidget.prototype = new Widget();
 
+FillWidget.prototype.execute = function() {
+	// Do nothing. Make no child widgets. $Fill widgets should be invisible when naturally encountered. Instead, their parseTreeNodes are made available to $slot widgets that want it.
+};
+
 exports.fill = FillWidget;
 
 })();
diff --git a/editions/test/tiddlers/tests/data/transclude/CustomWidget-RawAndSlotted.tid b/editions/test/tiddlers/tests/data/transclude/CustomWidget-RawAndSlotted.tid
new file mode 100644
index 000000000..a8e6feb68
--- /dev/null
+++ b/editions/test/tiddlers/tests/data/transclude/CustomWidget-RawAndSlotted.tid
@@ -0,0 +1,34 @@
+title: Transclude/CustomWidget/RawAndSlotted
+description: Custom widget can mix ts-raw and custom slots
+type: text/vnd.tiddlywiki-multiple
+tags: [[$:/tags/wiki-test-spec]]
+
+title: Output
+
+\whitespace trim
+\widget $my.widget()
+\whitespace trim
+<$slot $name="ts-header">
+	Default Header
+</$slot>
+-
+<$slot $name="ts-raw"/>
+\end
+<$my.widget>
+	First Body
+</$my.widget>
+
+
+<$my.widget>
+	<$fill $name="ts-header">
+		Custom Header
+	</$fill>
+	<$fill $name="ts-never">
+		<$log RawAndSlotted="Transclude/CustomWidget/RawAndSlotted is actually failing. $fill slots are executing silently when they weren't invoked." />
+	</$fill>
+	Second Body
+</$my.widget>
++
+title: ExpectedResult
+
+<p>Default Header-First Body</p><p>Custom Header-Second Body</p>
\ No newline at end of file