mirrors/TiddlyWiki5
1
0
Fork 0
mirror of https://github.com/Jermolene/TiddlyWiki5 synced 2024-11-26 19:47:20 +00:00
Code Issues Releases Wiki Activity

Fix: variables in functions should not pollute upstream widgets (#8641)

Browse Source
This commit is contained in:
Saq Imtiaz 2024-09-30 15:26:36 +02:00 committed by GitHub
parent 96840b886f
commit 3f4067ef7b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/modules/widgets/widget.js
View File

@ -335,7 +335,7 @@ Widget.prototype.makeFakeWidgetWithVariables = function(variables) {
};
} else {
opts = opts || {};
opts.variables = $tw.utils.extend(variables,opts.variables);
opts.variables = $tw.utils.extend({},variables,opts.variables);
return self.getVariableInfo(name,opts);
};
},

20
editions/test/tiddlers/tests/data/functions/FunctionFilterrunVariables4.tid Normal file
View File

@ -0,0 +1,20 @@
title: Functions/FunctionFilterrunVariables4
description: Nested functions in filter runs that set variables should not pollute upstream widget tree
type: text/vnd.tiddlywiki-multiple
tags: [[$:/tags/wiki-test-spec]]
title: Output
\function .a() [.b[]]
\function .b() [all[]] :map[subtract[1].c[]]
\function .c() [all[]] :map[subtract[1].d[]]
\function .d() [all[]] :map[subtract[1].e[]]
\function .e() [all[]] :map[subtract[1]]
<$text text={{{ [[10]] :map:flat[.a[]then<currentTiddler>] }}}/>
+
title: ExpectedResult
10