From ae9250622f0ff5f697718348607e207c8bc42203 Mon Sep 17 00:00:00 2001 From: Jeremy Ruston Date: Thu, 22 Feb 2024 17:17:23 +0000 Subject: [PATCH 1/2] Let's have performance instrumentation in the prerelease I believe it was turned off by accident at some point --- .../tiddlers/system/configPerformanceInstrumentation.tid | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 editions/prerelease/tiddlers/system/configPerformanceInstrumentation.tid diff --git a/editions/prerelease/tiddlers/system/configPerformanceInstrumentation.tid b/editions/prerelease/tiddlers/system/configPerformanceInstrumentation.tid new file mode 100644 index 000000000..e4220f287 --- /dev/null +++ b/editions/prerelease/tiddlers/system/configPerformanceInstrumentation.tid @@ -0,0 +1,2 @@ +title: $:/config/Performance/Instrumentation +text: yes From 6d721c728fb1743875cf7b8e88590c9938ed7e34 Mon Sep 17 00:00:00 2001 From: Jeremy Ruston Date: Thu, 22 Feb 2024 17:17:38 +0000 Subject: [PATCH 2/2] Confetti Plugin: Don't pass undefined for missing parameters --- plugins/tiddlywiki/confetti/startup.js | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/plugins/tiddlywiki/confetti/startup.js b/plugins/tiddlywiki/confetti/startup.js index 773d8e9fe..6634cbbca 100644 --- a/plugins/tiddlywiki/confetti/startup.js +++ b/plugins/tiddlywiki/confetti/startup.js @@ -25,13 +25,19 @@ exports.startup = function() { var paramObject = event.paramObject || {}, options = {}, extractNumericParameter = function(name) { - options[name] = paramObject[name] && $tw.utils.parseNumber(paramObject[name]); + if(paramObject[name]) { + options[name] = $tw.utils.parseNumber(paramObject[name]); + } }, extractListParameter = function(name) { - options[name] = paramObject[name] && $tw.utils.parseStringArray(paramObject[name]); + if(paramObject[name]) { + options[name] = $tw.utils.parseStringArray(paramObject[name]); + } }, extractBooleanParameter = function(name) { - options[name] = paramObject[name] && paramObject[name] === "yes"; + if(paramObject[name]) { + options[name] = paramObject[name] === "yes"; + } }; $tw.utils.each("particleCount angle spread startVelocity decay gravity drift ticks scalar zIndex".split(" "),function(name) { extractNumericParameter(name); @@ -39,10 +45,12 @@ exports.startup = function() { $tw.utils.each("colors shapes".split(" "),function(name) { extractListParameter(name); }); - options.origin = { - x: paramObject.originX && $tw.utils.parseNumber(paramObject.originX), - y: paramObject.originY && $tw.utils.parseNumber(paramObject.originY) - }; + if(paramObject.originX && paramObject.originY) { + options.origin = { + x: paramObject.originX && $tw.utils.parseNumber(paramObject.originX), + y: paramObject.originY && $tw.utils.parseNumber(paramObject.originY) + }; + } extractBooleanParameter("disableForReducedMotion"); var delay = paramObject.delay ? $tw.utils.parseNumber(paramObject.delay) : 0; $tw.confettiManager.launch(delay,options);