From 335c47079701be6481ec9cc0769ea4211c0f86c2 Mon Sep 17 00:00:00 2001 From: Jermolene Date: Mon, 3 Nov 2014 23:00:11 +0000 Subject: [PATCH] Include double square brackets when dragging titles MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Dragging a tiddler link into a tiddler editor, or outside the browser into another app, will now add double square brackets around the title if it includes spaces. Suggested by @tgirod. I’m not 100% sure about this change. It breaks one habit that I had developed: typing `[[sometext|]]` and then dragging a title in between the vertical bar and the first closing square bracket. What do others think? --- core/modules/widgets/link.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/core/modules/widgets/link.js b/core/modules/widgets/link.js index 972610059..7996fcdc8 100755 --- a/core/modules/widgets/link.js +++ b/core/modules/widgets/link.js @@ -154,15 +154,16 @@ LinkWidget.prototype.handleDragStartEvent = function(event) { // Then the data dataTransfer.clearData(); var jsonData = this.wiki.getTiddlerAsJson(this.to), - textData = this.wiki.getTiddlerText(this.to,""); + textData = this.wiki.getTiddlerText(this.to,""), + title = this.to.indexOf(" ") === -1 ? this.to : "[[" + this.to + "]]"; // IE doesn't like these content types if(!$tw.browser.isIE) { dataTransfer.setData("text/vnd.tiddler",jsonData); - dataTransfer.setData("text/plain",this.to); + dataTransfer.setData("text/plain",title); dataTransfer.setData("text/x-moz-url","data:text/vnd.tiddler," + encodeURI(jsonData)); } dataTransfer.setData("URL","data:text/vnd.tiddler," + encodeURI(jsonData)); - dataTransfer.setData("Text",this.to); + dataTransfer.setData("Text",title); event.stopPropagation(); } else { event.preventDefault();