From 31e7dbf020ddbbc5a7b88cbfc9acdd3168fe72c5 Mon Sep 17 00:00:00 2001 From: Simon Huber Date: Tue, 6 Aug 2019 14:12:21 +0200 Subject: [PATCH] Add "preventScroll" option to tm-focus-selector message (#4157) * add "delayed" option to tm-focus-selector message this delays the focussing for the time of the animation duration if delayed="yes" or delayed="true" this is useful when navigating the story river up and down with keyboard shortcuts and the shortcuts focus the title input if a navigated tiddler is in edit mode -> navigation doesn't jump but stays smooth * Update rootwidget.js * Update WidgetMessage_ tm-focus-selector.tid * add preventScroll="true" tip --- core/modules/startup/rootwidget.js | 2 +- .../tiddlers/messages/WidgetMessage_ tm-focus-selector.tid | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/core/modules/startup/rootwidget.js b/core/modules/startup/rootwidget.js index bf96c6fbd..d02748b28 100644 --- a/core/modules/startup/rootwidget.js +++ b/core/modules/startup/rootwidget.js @@ -44,7 +44,7 @@ exports.startup = function() { console.log("Error in selector: ",selector) } if(element && element.focus) { - element.focus(); + element.focus(event.paramObject); } }); // Install the scroller diff --git a/editions/tw5.com/tiddlers/messages/WidgetMessage_ tm-focus-selector.tid b/editions/tw5.com/tiddlers/messages/WidgetMessage_ tm-focus-selector.tid index dc41ad393..b3cb9011d 100644 --- a/editions/tw5.com/tiddlers/messages/WidgetMessage_ tm-focus-selector.tid +++ b/editions/tw5.com/tiddlers/messages/WidgetMessage_ tm-focus-selector.tid @@ -9,4 +9,6 @@ The `tm-focus-selector` message sets the focus to the DOM element identified by |!Name |!Description | |param |Selector identifying the DOM element to be focussed | +|paramObject |Optional hashmap of additional parameters passed to the `focus` command | +<<.tip """preventScroll="true" prevents the browser from scrolling to the focused element""">>