mirrors/TiddlyWiki5
1
0
Fork 0
mirror of https://github.com/Jermolene/TiddlyWiki5 synced 2024-11-27 03:57:21 +00:00
Code Issues Releases Wiki Activity

Make the insert- and remove-animations of storyviews work in new windows (#5755)

Browse Source 
* Make classic storyview work in new windows, too

* Make pop storyview work in new windows, too

* Make zoomin storyview insert and remove animation work in new windows, too
This commit is contained in:
Simon Huber 2021-06-04 17:59:45 +02:00 committed by GitHub
parent 056e6541a1
commit 2b911ac11f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
core/modules/storyviews/classic.js
View File

@ -43,7 +43,7 @@ ClassicStoryView.prototype.insert = function(widget) {
if(duration) { if(duration) {
var targetElement = widget.findFirstDomNode(); var targetElement = widget.findFirstDomNode();
// Abandon if the list entry isn't a DOM element (it might be a text node) // Abandon if the list entry isn't a DOM element (it might be a text node)
if(!(targetElement instanceof Element)) { if(targetElement.nodeType === Node.TEXT_NODE) {
return; return;
} }
// Get the current height of the tiddler // Get the current height of the tiddler
@ -83,7 +83,7 @@ ClassicStoryView.prototype.remove = function(widget) {
widget.removeChildDomNodes(); widget.removeChildDomNodes();
}; };
// Abandon if the list entry isn't a DOM element (it might be a text node) // Abandon if the list entry isn't a DOM element (it might be a text node)
if(!(targetElement instanceof Element)) { if(targetElement.nodeType === Node.TEXT_NODE) {
removeElement(); removeElement();
return; return;
} }
@ -118,4 +118,4 @@ ClassicStoryView.prototype.remove = function(widget) {
exports.classic = ClassicStoryView; exports.classic = ClassicStoryView;
})(); })();

4
core/modules/storyviews/pop.js
View File

@ -35,7 +35,7 @@ PopStoryView.prototype.insert = function(widget) {
var targetElement = widget.findFirstDomNode(), var targetElement = widget.findFirstDomNode(),
duration = $tw.utils.getAnimationDuration(); duration = $tw.utils.getAnimationDuration();
// Abandon if the list entry isn't a DOM element (it might be a text node) // Abandon if the list entry isn't a DOM element (it might be a text node)
if(!(targetElement instanceof Element)) { if(targetElement.nodeType === Node.TEXT_NODE) {
return; return;
} }
// Reset once the transition is over // Reset once the transition is over
@ -77,7 +77,7 @@ PopStoryView.prototype.remove = function(widget) {
} }
}; };
// Abandon if the list entry isn't a DOM element (it might be a text node) // Abandon if the list entry isn't a DOM element (it might be a text node)
if(!(targetElement instanceof Element)) { if(targetElement.nodeType === Node.TEXT_NODE) {
removeElement(); removeElement();
return; return;
} }

4
core/modules/storyviews/zoomin.js
View File

@ -130,7 +130,7 @@ function findTitleDomNode(widget,targetClass) {
ZoominListView.prototype.insert = function(widget) { ZoominListView.prototype.insert = function(widget) {
var targetElement = widget.findFirstDomNode(); var targetElement = widget.findFirstDomNode();
// Abandon if the list entry isn't a DOM element (it might be a text node) // Abandon if the list entry isn't a DOM element (it might be a text node)
if(!(targetElement instanceof Element)) { if(targetElement.nodeType === Node.TEXT_NODE) {
return; return;
} }
// Make the newly inserted node position absolute and hidden // Make the newly inserted node position absolute and hidden
@ -147,7 +147,7 @@ ZoominListView.prototype.remove = function(widget) {
widget.removeChildDomNodes(); widget.removeChildDomNodes();
}; };
// Abandon if the list entry isn't a DOM element (it might be a text node) // Abandon if the list entry isn't a DOM element (it might be a text node)
if(!(targetElement instanceof Element)) { if(targetElement.nodeType === Node.TEXT_NODE) {
removeElement(); removeElement();
return; return;
} }