From 25f8b3f9038cc39ff7d13a7cd377814b05b9d4b4 Mon Sep 17 00:00:00 2001 From: saqimtiaz Date: Thu, 11 Jun 2020 13:11:56 +0200 Subject: [PATCH] Check for DOM node existence before removing class. (#4696) Can cause issues if dragstart and dragend actions trigger a refresh. --- core/modules/widgets/droppable.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/core/modules/widgets/droppable.js b/core/modules/widgets/droppable.js index 066e88cef..45f11bf68 100644 --- a/core/modules/widgets/droppable.js +++ b/core/modules/widgets/droppable.js @@ -75,7 +75,9 @@ DroppableWidget.prototype.leaveDrag = function(event) { // Remove highlighting if we're leaving externally. The hacky second condition is to resolve a problem with Firefox whereby there is an erroneous dragenter event if the node being dragged is within the dropzone if(this.currentlyEntered.length === 0 || (this.currentlyEntered.length === 1 && this.currentlyEntered[0] === $tw.dragInProgress)) { this.currentlyEntered = []; - $tw.utils.removeClass(this.domNodes[0],"tc-dragover"); + if(this.domNodes[0]) { + $tw.utils.removeClass(this.domNodes[0],"tc-dragover"); + } } };