From 23c2d90ee8e28f8c68f9ba58fcbc13a56f838d61 Mon Sep 17 00:00:00 2001 From: Jermolene Date: Sat, 27 Sep 2014 10:47:31 +0100 Subject: [PATCH] Added error handling to upload saver A further fix for #251 --- core/modules/savers/upload.js | 6 +++++- editions/tw5.com/tiddlers/saving/Saving on TiddlySpot.tid | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/core/modules/savers/upload.js b/core/modules/savers/upload.js index bb426ed26..897496b6a 100644 --- a/core/modules/savers/upload.js +++ b/core/modules/savers/upload.js @@ -64,7 +64,11 @@ UploadSaver.prototype.save = function(text,method,callback) { } } }; - http.send(data); + try { + http.send(data); + } catch(ex) { + return callback("Error:" + ex); + } $tw.notifier.display("$:/language/Notifications/Save/Starting"); return true; }; diff --git a/editions/tw5.com/tiddlers/saving/Saving on TiddlySpot.tid b/editions/tw5.com/tiddlers/saving/Saving on TiddlySpot.tid index e41123495..f6435bef7 100644 --- a/editions/tw5.com/tiddlers/saving/Saving on TiddlySpot.tid +++ b/editions/tw5.com/tiddlers/saving/Saving on TiddlySpot.tid @@ -14,7 +14,11 @@ You can upload an existing TiddlyWiki document from your local disc to TiddlySpo # Click the "Save Changes" button. You should get a confirmation notification at the top right saying ''Saved wiki''. Saving can take several seconds if you're on a slow connection or working with a large wiki. # Navigate to your TiddlySpot URL at http://{wikiname}.tiddlyspot.com/ -Note that your password is sent unencrypted when using TiddlySpot. From http://faq.tiddlyspot.com/: +Note that this procedure does not work in Firefox. + +!! TiddlySpot Security + +Your password is sent unencrypted when using TiddlySpot. From http://faq.tiddlyspot.com/: <<< ''Is Tiddlyspot secure?''