mirrors/TiddlyWiki5
1
0
Fork 0
mirror of https://github.com/Jermolene/TiddlyWiki5 synced 2024-06-25 23:03:15 +00:00
Code Issues Releases Wiki Activity

[pagescroller] add callback function option (#3473)

Browse Source 
this allows using the pagescroller for scrolling elements into view where the rect gets calculated somewhere else

Example: CodeMirror has the `cm.cursorCoords()` function that returns the rect of the textselection (or cursor coordinates)

this scrolls the cursor or text selection into view using tiddlywikis pagescroller:

`$tw.pageScroller.scrollIntoView(undefined, function() { return self.cm.cursorCoords(true,"window"); });`
This commit is contained in:
BurningTreeC 2018-11-15 15:58:32 +01:00 committed by Jeremy Ruston
parent c82edbe6bc
commit 0ff96f9caf
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
core/modules/utils/dom/scroller.js
View File

@ -53,10 +53,10 @@ PageScroller.prototype.handleEvent = function(event) {
/* /*
Handle a scroll event hitting the page document Handle a scroll event hitting the page document
*/ */
PageScroller.prototype.scrollIntoView = function(element) { PageScroller.prototype.scrollIntoView = function(element,callback) {
var self = this, var self = this,
duration = $tw.utils.getAnimationDuration(), duration = $tw.utils.getAnimationDuration(),
srcWindow = element.ownerDocument.defaultView; srcWindow = element ? element.ownerDocument.defaultView : window;
// Now get ready to scroll the body // Now get ready to scroll the body
this.cancelScroll(srcWindow); this.cancelScroll(srcWindow);
this.startTime = Date.now(); this.startTime = Date.now();
@ -68,8 +68,8 @@ PageScroller.prototype.scrollIntoView = function(element) {
} }
// Get the client bounds of the element and adjust by the scroll position // Get the client bounds of the element and adjust by the scroll position
var getBounds = function() { var getBounds = function() {
var clientBounds = element.getBoundingClientRect(), var clientBounds = typeof callback === 'function' ? callback() : element.getBoundingClientRect(),
scrollPosition = $tw.utils.getScrollPosition(srcWindow); scrollPosition = $tw.utils.getScrollPosition();
return { return {
left: clientBounds.left + scrollPosition.x, left: clientBounds.left + scrollPosition.x,
top: clientBounds.top + scrollPosition.y - offset, top: clientBounds.top + scrollPosition.y - offset,